Skip to content
This repository was archived by the owner on Jan 31, 2020. It is now read-only.

Commit c7a94f8

Browse files
committed
New methods should not implement fluent interfaces
In these particular cases, you really do not want to operate on the return value, as it's ambiguous what that would mean.
1 parent f9c47f6 commit c7a94f8

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/Helper/Placeholder.php

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,24 +101,22 @@ public function containerExists($key)
101101
/**
102102
* Delete a specific container by name
103103
*
104-
* @param string $key
105-
* @return self
104+
* @param string $key
105+
* @return void
106106
*/
107107
public function deleteContainer($key)
108108
{
109109
$key = (string) $key;
110110
unset($this->items[$key]);
111-
return $this;
112111
}
113112

114113
/**
115114
* Remove all containers
116115
*
117-
* @return self
116+
* @return void
118117
*/
119118
public function clearContainers()
120119
{
121120
$this->items = [];
122-
return $this;
123121
}
124122
}

0 commit comments

Comments
 (0)