Skip to content

Commit a598364

Browse files
committed
add tooltip over delay column for large numbers in short time format
1 parent a159311 commit a598364

File tree

7 files changed

+18
-11
lines changed

7 files changed

+18
-11
lines changed

jest/tests/time.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ describe('Stopper', () => {
5959
expect(Stopper.toString(999.123456)).toMatch('999ms');
6060
expect(Stopper.toString(5432.123456)).toMatch('5.432s');
6161
expect(Stopper.toString(5 * 60e3)).toMatch('0:05:00');
62+
expect(Stopper.toString(987654321.0123456789)).toMatch('274:20:54');
6263
});
6364
});
6465

src/api/const.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ export const ERRORS_IGNORED = [
22
'Could not establish connection. Receiving end does not exist.',
33
'The message port closed before a response was received.',
44
];
5-
export const TELEMETRY_FREQUENCY_30PS = 33.3333333333; //MS
5+
export const TELEMETRY_FREQUENCY_30PS = 33.3333333333; // ms
66
export const TELEMETRY_FREQUENCY_1PS = 1000; // ms
77
export const MAX_TRAFFIC_DURATION_BEFORE_AUTOPAUSE = 2e3; // ms
8-
export const FRAME_1of60 = 0.0166666666667;
8+
export const FRAME_1of60 = 0.0166666666667; // ms
99
export const VARIABLE_ANIMATION_THROTTLE = 3500; // eye blinking average frequency
1010
export const CALLED_ABORTED_TOOLTIP = '<called>-<aborted>/<abort-locations>';
1111

@@ -99,7 +99,7 @@ export const MEDIA_ELEMENT_PROPS = [
9999
'videoHeight',
100100
];
101101

102-
export const MEDIA_ELEMENT_TOGGABLE_PROPS = new Set([
102+
export const MEDIA_ELEMENT_TOGGABLE_PROPS = /*@__PURE__*/ new Set([
103103
'autoplay',
104104
'playsInline',
105105
'loop',

src/api/time.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ export class Stopper {
6565
return `${s}.${ms.toString().padStart(3, '0')}s`;
6666
}
6767

68-
const h = Math.trunc(msTime / 1e3 / 60 / 60);
69-
const m = Math.trunc(msTime / 1e3 / 60) % 60;
68+
const h = Math.trunc(msTime / 3600e3);
69+
const m = Math.trunc(msTime / 60e3) % 60;
7070
const s = Math.trunc(msTime / 1e3) % 60;
7171

7272
return `${h.toString().padStart(2, '0')}:${m
@@ -246,3 +246,7 @@ export class MeanAggregator {
246246
export function trim2microsecond(ms: number | null) {
247247
return ms === null ? null : Math.trunc(ms * 1e3) / 1e3;
248248
}
249+
250+
export function delayTitle(delay: number | unknown): string | undefined {
251+
return delay && Number(delay) > 10e3 ? Stopper.toString(delay) : undefined;
252+
}

src/view/components/ActiveTimers.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
<script lang="ts">
22
import type { TOnlineTimerMetrics } from '../../api/wrappers.ts';
33
import { portPost } from '../../api/communication.ts';
4+
import { delayTitle } from '../../api/time.ts';
45
import Variable from './Variable.svelte';
56
import Trace from './Trace.svelte';
67
import TraceDomain from './TraceDomain.svelte';
@@ -33,7 +34,7 @@
3334

3435
{#each metrics as metric (metric.handler)}
3536
<tr class="t-zebra">
36-
<td class="ta-r">{metric.delay}</td>
37+
<td class="ta-r" title={delayTitle(metric.delay)}>{metric.delay}</td>
3738
<td class="ta-c handler-cell">
3839
<span class="handler-value">{metric.handler}</span>
3940
<!-- svelte-ignore a11y_click_events_have_key_events -->

src/view/components/IdleCallbackRequestHistory.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
} from '../../api/settings.ts';
1414
import { compareByFieldOrder } from '../../api/comparator.ts';
1515
import { CALLED_ABORTED_TOOLTIP } from '../../api/const.ts';
16-
import { Stopper } from '../../api/time.ts';
16+
import { delayTitle, Stopper } from '../../api/time.ts';
1717
import Variable from './Variable.svelte';
1818
import Trace from './Trace.svelte';
1919
import TraceDomain from './TraceDomain.svelte';
@@ -171,7 +171,7 @@
171171
{/if}
172172
</td>
173173
<td class="ta-c">{metric.handler}</td>
174-
<td class="ta-r">{metric.delay}</td>
174+
<td class="ta-r" title={delayTitle(metric.delay)}>{metric.delay}</td>
175175
<td>
176176
{#if metric.isOnline}
177177
<span title="Scheduled" class="icon -scheduled -small"></span>

src/view/components/TimersClearHistoryMetric.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<script lang="ts">
22
import type { TClearTimerHistory } from '../../api/wrappers.ts';
3+
import { delayTitle } from '../../api/time.ts';
34
import Trace from './Trace.svelte';
45
import TraceDomain from './TraceDomain.svelte';
56
import Variable from './Variable.svelte';
@@ -13,5 +14,5 @@
1314
>
1415
<td class="ta-c"><Variable value={metric.calls} /></td>
1516
<td class="ta-c">{metric.handler}</td>
16-
<td class="ta-r">{metric.delay}</td>
17+
<td class="ta-r" title={delayTitle(metric.delay)}>{metric.delay}</td>
1718
</tr>

src/view/components/TimersSetHistory.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
} from '../../api/settings.ts';
1414
import { compareByFieldOrder } from '../../api/comparator.ts';
1515
import { CALLED_ABORTED_TOOLTIP } from '../../api/const.ts';
16-
import { Stopper } from '../../api/time.ts';
16+
import { delayTitle, Stopper } from '../../api/time.ts';
1717
import Variable from './Variable.svelte';
1818
import Trace from './Trace.svelte';
1919
import TraceDomain from './TraceDomain.svelte';
@@ -173,7 +173,7 @@
173173
{/if}
174174
</td>
175175
<td class="ta-c">{metric.handler}</td>
176-
<td class="ta-r">{metric.delay}</td>
176+
<td class="ta-r" title={delayTitle(metric.delay)}>{metric.delay}</td>
177177
<td>
178178
{#if metric.isOnline}
179179
<span title="Scheduled" class="icon -scheduled -small"></span>

0 commit comments

Comments
 (0)