Reduced complexity for temp var assignment.

adamculp · adamculp · commit 02d2b07edf8b · 2014-09-27T09:22:41.000-04:00
diff --git a/ToolkitApi/ToolkitPCML.php b/ToolkitApi/ToolkitPCML.php
@@ -353,6 +353,8 @@ public function singlePcmlToParam(\SimpleXmlElement $dataElement)
                 $passBy = 'val'; // rare. PCML calls it 'value'. XMLSERVICE calls it 'val'.
             }
             
+            $newtype = '';
+            
             // find new toolkit equivalent of PCML data type
             if (isset($this->_pcmlTypeMap[$type])) {
                 // a simple type mapping
@@ -367,8 +369,6 @@ public function singlePcmlToParam(\SimpleXmlElement $dataElement)
                     $newType = ''; // no match
                 } //(length == 2, et al.)
     
-            } else {
-                $newtype = '';
             }
                 
             $newInout = (isset($this->_pcmlInoutMap[$usage])) ? (string) $this->_pcmlInoutMap[$usage] : '';

Original file line number	Diff line number	Diff line change
`@@ -353,6 +353,8 @@ public function singlePcmlToParam(\SimpleXmlElement $dataElement)`
`353`	`353`	`$passBy = 'val'; // rare. PCML calls it 'value'. XMLSERVICE calls it 'val'.`
`354`	`354`	`}`
`355`	`355`
	`356`	`+ $newtype = '';`
	`357`	`+`
`356`	`358`	`// find new toolkit equivalent of PCML data type`
`357`	`359`	`if (isset($this->_pcmlTypeMap[$type])) {`
`358`	`360`	`// a simple type mapping`
`@@ -367,8 +369,6 @@ public function singlePcmlToParam(\SimpleXmlElement $dataElement)`
`367`	`369`	`$newType = ''; // no match`
`368`	`370`	`} //(length == 2, et al.)`
`369`	`371`
`370`		`- } else {`
`371`		`- $newtype = '';`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`$newInout = (isset($this->_pcmlInoutMap[$usage])) ? (string) $this->_pcmlInoutMap[$usage] : '';`