Skip to content

Commit d541014

Browse files
refactor: remove dimenstions from SidebarHeader Icon (#35)
* refactor: remove dimensions from SidebarHeader Icon * chore: add changeset
1 parent 4a79333 commit d541014

File tree

5 files changed

+14
-9
lines changed

5 files changed

+14
-9
lines changed

.changeset/nice-jeans-film.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@zenml-io/react-component-library": patch
3+
---
4+
5+
remove dimenstions from SidebarHeader Icon

src/components/Sidebar/Sidebar.stories.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export const defaultStory: Story = {
3939
args: {
4040
children: (
4141
<>
42-
<SidebarHeader icon={<CloseButton />} title="ZenML Tenant">
42+
<SidebarHeader icon={<CloseButton className="w-6 h-6" />} title="ZenML Tenant">
4343
<SidebarHeaderImage>
4444
<img src={`https://avatar.vercel.sh/ZenMLTenant?size=32`} />
4545
</SidebarHeaderImage>
@@ -50,29 +50,29 @@ export const defaultStory: Story = {
5050
<li className="w-full">
5151
<SidebarItem isActive={true}>
5252
<div>
53-
<SidebarItemContent isActive={true} icon={<CPU />} label="Models" />
53+
<SidebarItemContent svgStroke isActive={true} icon={<CPU />} label="Models" />
5454
</div>
5555
</SidebarItem>
5656
</li>
5757
<li className="w-full">
5858
<SidebarItem isActive={false}>
5959
<div>
60-
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
60+
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
6161
</div>
6262
</SidebarItem>
6363
</li>
6464
<li className="w-full">
6565
<SidebarItem isActive={false}>
6666
<div>
67-
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
67+
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
6868
</div>
6969
</SidebarItem>
7070
</li>
7171
</SidebarList>
7272
<div style={{ marginTop: "auto" }}>
7373
<SidebarItem>
7474
<div>
75-
<SidebarItemContent isActive={false} icon={<CPU />} label="Models" />
75+
<SidebarItemContent svgStroke isActive={false} icon={<CPU />} label="Models" />
7676
</div>
7777
</SidebarItem>
7878
</div>

src/components/Sidebar/Sidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const SidebarHeader = forwardRef<HTMLDivElement, SidebarHeaderProps>(
6262

6363
const iconClasses = cn(
6464
existingIconClasses,
65-
"w-6 ml-auto shrink-0 h-6 opacity-0 group-hover:opacity-100 duration-300 transition-all"
65+
"ml-auto shrink-0 opacity-0 group-hover:opacity-100 duration-300 transition-all"
6666
);
6767

6868
return (

src/components/Sidebar/SidebarHeader.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const sidebarHeader: Story = {
2525
name: "Sidebar Header",
2626
args: {
2727
title: "ZenML Tenant",
28-
icon: <CloseButton />,
28+
icon: <CloseButton className="w-6 h-6" />,
2929
children: (
3030
<SidebarHeaderImage>
3131
<img src={`https://avatar.vercel.sh/ZenMLTenant?size=32`} />

src/components/Sidebar/SidebarItem.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export const inactive: Story = {
2727
isActive: false,
2828
children: (
2929
<div>
30-
<SidebarItemContent icon={<CPU />} label="Models" />
30+
<SidebarItemContent svgStroke icon={<CPU />} label="Models" />
3131
</div>
3232
)
3333
}
@@ -39,7 +39,7 @@ export const active: Story = {
3939
isActive: true,
4040
children: (
4141
<div>
42-
<SidebarItemContent isActive={true} icon={<CPU />} label="Models" />
42+
<SidebarItemContent svgStroke isActive={true} icon={<CPU />} label="Models" />
4343
</div>
4444
)
4545
}

0 commit comments

Comments
 (0)