Skip to content

Commit 4662a90

Browse files
author
marwan37
committed
revert change to pipeline code, skip expected failure for robust_pipeline, set analytics ignore env variable
1 parent 45675b2 commit 4662a90

File tree

2 files changed

+18
-16
lines changed

2 files changed

+18
-16
lines changed

.github/workflows/test-pipelines.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ on:
1313
jobs:
1414
test-pipelines:
1515
runs-on: ubuntu-latest
16+
env:
17+
ZENML_ANALYTICS_OPT_IN: false
1618

1719
steps:
1820
- name: Checkout repository
@@ -59,11 +61,12 @@ jobs:
5961
"pipelines/yamlConfig/yaml_pipeline.py"; do
6062
6163
echo "Running $p…"
62-
if ! PYTHONPATH=$GITHUB_WORKSPACE:$PYTHONPATH python "$p"; then
63-
echo "❌ $p failed"
64-
failed+=("$p")
65-
fi
66-
done
64+
if [[ "$p" == *"retries/robust_pipeline.py" ]]; then
65+
PYTHONPATH=$GITHUB_WORKSPACE:$PYTHONPATH python "$p" || echo "⚠ robust_pipeline demo: failure expected"
66+
else
67+
PYTHONPATH=$GITHUB_WORKSPACE:$PYTHONPATH python "$p" || failed+=("$p")
68+
fi
69+
done
6770
6871
if [ "${#failed[@]}" -gt 0 ]; then
6972
echo "Failed pipelines:"

pipelines/retries/robust_pipeline.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,13 @@ def robust_pipeline():
4141

4242
# ──────────────── run & inspect ────────────────
4343
if __name__ == "__main__":
44-
try:
45-
run = robust_pipeline()
46-
step_run = run.steps["flaky"]
47-
if step_run.status != "COMPLETED":
48-
logger.warning("Demo pipeline ended in %s (expected occasionally)", step_run.status)
49-
except Exception as e:
50-
logger.warning("Demo pipeline failed after retries (expected): %s", e)
51-
finally:
52-
log_dashboard_urls("robust_pipeline")
53-
# Always succeed so GH Actions won’t mark this script as a failure
54-
exit(0)
44+
run = robust_pipeline()
45+
46+
step_run = run.steps["flaky"]
47+
if step_run.status == "COMPLETED":
48+
msg = step_run.outputs["result"][0].load()
49+
logger.info(f"▶︎ Final result: {msg}")
50+
else:
51+
logger.info(f"▶︎ Pipeline ended in state: {step_run.status}")
52+
53+
log_dashboard_urls("robust_pipeline")

0 commit comments

Comments
 (0)