remove polling from runs (all-runs and pipeline runs) (#497)

Author: talhainvenxion

src/ui/layouts/AllRuns/Runs/List/useService.ts

@@ -1,11 +1,11 @@
-import { useEffect } from 'react';
-import { runsActions } from '../../../../../redux/actions';
+// import { useEffect } from 'react';
+// import { runsActions } from '../../../../../redux/actions';
 import {
   runSelectors,
   runPagesSelectors,
-  workspaceSelectors,
+  // workspaceSelectors,
 } from '../../../../../redux/selectors';
-import { useDispatch, useSelector } from '../../../../hooks';
+import { useSelector } from '../../../../hooks';
 import { Run } from '../../../../../api/types';
 
 interface ServiceInterface {
@@ -33,30 +33,30 @@ export const useService = ({
   }[];
 }): ServiceInterface => {
   const fetching = useSelector(runPagesSelectors.fetching);
-  const dispatch = useDispatch();
+  // const dispatch = useDispatch();
   const runs = useSelector(runSelectors.myRuns);
-  const selectedWorkspace = useSelector(workspaceSelectors.selectedWorkspace);
+  // const selectedWorkspace = useSelector(workspaceSelectors.selectedWorkspace);
   const runsPaginated = useSelector(runSelectors.myRunsPaginated);
-  const isValidFilter = filter?.map((f) => f.value).join('');
+  // const isValidFilter = filter?.map((f) => f.value).join('');
 
-  useEffect(() => {
-    if (!isValidFilter && !isExpended) {
-      const intervalId = setInterval(() => {
-        //assign interval to a variable to clear it.
-        dispatch(
-          runsActions.allRuns({
-            sort_by: sortBy,
-            logical_operator: 'and',
-            workspace: selectedWorkspace,
-            page: runsPaginated.page,
-            size: runsPaginated.size,
-          }),
-        );
-      }, 5000);
+  // useEffect(() => {
+  //   if (!isValidFilter && !isExpended) {
+  //     const intervalId = setInterval(() => {
+  //       //assign interval to a variable to clear it.
+  //       dispatch(
+  //         runsActions.allRuns({
+  //           sort_by: sortBy,
+  //           logical_operator: 'and',
+  //           workspace: selectedWorkspace,
+  //           page: runsPaginated.page,
+  //           size: runsPaginated.size,
+  //         }),
+  //       );
+  //     }, 5000);
 
-      return () => clearInterval(intervalId); //This is important
-    }
-  });
+  //     return () => clearInterval(intervalId); //This is important
+  //   }
+  // });
   const runIds = runs.map((run: Run) => run.id);
 
   return {

src/ui/layouts/pipelines/PipelineDetail/Runs/useService.ts

@@ -1,6 +1,6 @@
 import { useEffect } from 'react';
-import { useDispatch, useSelector } from 'react-redux';
-import { pipelinesActions } from '../../../../../redux/actions';
+import { useSelector } from 'react-redux';
+// import { pipelinesActions } from '../../../../../redux/actions';
 import {
   runPagesSelectors,
   runSelectors,
@@ -33,34 +33,34 @@ export const useService = ({
   sortBy: string;
   pipelineId: TId;
 }): ServiceInterface => {
-  const dispatch = useDispatch();
+  // const dispatch = useDispatch();
   const fetching = useSelector(runPagesSelectors.fetching);
   const runs: Run[] = useSelector(runSelectors.runsForPipelineId(pipelineId));
   const runsPaginated = useSelector(runSelectors.myRunsPaginated);
-  const isValidFilter = filter.map((f) => f.value).join('');
+  // const isValidFilter = filter.map((f) => f.value).join('');
 
   useEffect(() => {}, [runs]);
-  useEffect(() => {
-    if (!isValidFilter && !isExpended) {
-      const intervalId = setInterval(() => {
-        //assign interval to a variable to clear it.
+  // useEffect(() => {
+  //   if (!isValidFilter && !isExpended) {
+  //     const intervalId = setInterval(() => {
+  //       //assign interval to a variable to clear it.
 
-        dispatch(
-          pipelinesActions.allRunsByPipelineId({
-            sort_by: sortBy,
-            logical_operator: 'and',
-            pipelineId: pipelineId,
-            page: runsPaginated.page,
-            size: runsPaginated.size,
-          }),
-        );
-      }, 5000);
+  //       dispatch(
+  //         pipelinesActions.allRunsByPipelineId({
+  //           sort_by: sortBy,
+  //           logical_operator: 'and',
+  //           pipelineId: pipelineId,
+  //           page: runsPaginated.page,
+  //           size: runsPaginated.size,
+  //         }),
+  //       );
+  //     }, 5000);
 
-      return () => clearInterval(intervalId);
-    }
-    //This is important
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [pipelineId, runsPaginated]);
+  //     return () => clearInterval(intervalId);
+  //   }
+  //   //This is important
+  //   // eslint-disable-next-line react-hooks/exhaustive-deps
+  // }, [pipelineId, runsPaginated]);
 
   const runIds = runs.map((run: Run) => run.id);