Skip to content

Commit 195e732

Browse files
talhainvenxiontalhainvenxion
committed
remove some dead code
1 parent 62b3f68 commit 195e732

File tree

17 files changed

+46
-345
lines changed

17 files changed

+46
-345
lines changed

‎src/ui/layouts/stacks/RunDetail/Configuration/useService.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
import { useSelector } from 'react-redux';
2-
import {
3-
// pipelineSelectors,
4-
runSelectors,
5-
} from '../../../../../redux/selectors';
2+
import { runSelectors } from '../../../../../redux/selectors';
63

74
import YAML from 'json2yaml';
85

‎src/ui/layouts/stacks/RunDetail/DAG/useService.ts‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
import { useEffect } from 'react';
22
import { useSelector } from 'react-redux';
33

4-
import {
5-
// pipelineSelectors,
6-
runSelectors,
7-
} from '../../../../../redux/selectors';
4+
import { runSelectors } from '../../../../../redux/selectors';
85

96
export const useService = ({ runId }: { runId: TId }) => {
107
const graph = useSelector(runSelectors.graphByRunId(runId));
11-
// debugger;
8+
129
useEffect(() => {}, [graph]);
13-
// const graph: any = useSelector(runSelectors.graphByRunId(runId));
10+
1411
return { graph };
1512
};

‎src/ui/layouts/stacks/RunDetail/components.tsx‎

Lines changed: 8 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -47,16 +47,8 @@ export const RunStatus: React.FC<{ run: TRun }> = ({ run }) => {
4747
)}
4848
</If>
4949
</div>
50-
<ReactTooltip
51-
id={run.status}
52-
place="top"
53-
effect="solid"
54-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
55-
>
56-
<Paragraph color="white">
57-
{run.status}
58-
{/* {truncate(pipeline.id, ID_MAX_LENGTH)} */}
59-
</Paragraph>
50+
<ReactTooltip id={run.status} place="top" effect="solid">
51+
<Paragraph color="white">{run.status}</Paragraph>
6052
</ReactTooltip>
6153
</FlexBox>
6254

@@ -73,27 +65,11 @@ export const RunStatus: React.FC<{ run: TRun }> = ({ run }) => {
7365
)}
7466
</If>
7567
</div>
76-
<ReactTooltip
77-
id={run.status}
78-
place="top"
79-
effect="solid"
80-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
81-
>
82-
<Paragraph color="white">
83-
{run.status}
84-
{/* {truncate(pipeline.id, ID_MAX_LENGTH)} */}
85-
</Paragraph>
68+
<ReactTooltip id={run.status} place="top" effect="solid">
69+
<Paragraph color="white">{run.status}</Paragraph>
8670
</ReactTooltip>
8771
</FlexBox>
8872

89-
{/* <If condition={status === runStatus.FAILED}>
90-
{() => (
91-
<ColoredCircle color="red" size="xs">
92-
<icons.close color={iconColors.white} size={iconSizes.xs} />
93-
</ColoredCircle>
94-
)}
95-
</If> */}
96-
9773
<FlexBox alignItems="center">
9874
<div data-tip data-for={run.status}>
9975
<If condition={run.status === runStatus.FAILED}>
@@ -104,16 +80,8 @@ export const RunStatus: React.FC<{ run: TRun }> = ({ run }) => {
10480
)}
10581
</If>
10682
</div>
107-
<ReactTooltip
108-
id={run.status}
109-
place="top"
110-
effect="solid"
111-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
112-
>
113-
<Paragraph color="white">
114-
{run.status}
115-
{/* {truncate(pipeline.id, ID_MAX_LENGTH)} */}
116-
</Paragraph>
83+
<ReactTooltip id={run.status} place="top" effect="solid">
84+
<Paragraph color="white">{run.status}</Paragraph>
11785
</ReactTooltip>
11886
</FlexBox>
11987

@@ -127,16 +95,8 @@ export const RunStatus: React.FC<{ run: TRun }> = ({ run }) => {
12795
)}
12896
</If>
12997
</div>
130-
<ReactTooltip
131-
id={run.status}
132-
place="top"
133-
effect="solid"
134-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
135-
>
136-
<Paragraph color="white">
137-
{run.status}
138-
{/* {truncate(pipeline.id, ID_MAX_LENGTH)} */}
139-
</Paragraph>
98+
<ReactTooltip id={run.status} place="top" effect="solid">
99+
<Paragraph color="white">{run.status}</Paragraph>
140100
</ReactTooltip>
141101
</FlexBox>
142102
</>

‎src/ui/layouts/stacks/RunDetail/index.tsx‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,21 +23,16 @@ const getTabPages = ({
2323
return [
2424
{
2525
text: 'DAG',
26-
// <Statistics runId={runId} stackId={stackId} />
26+
2727
Component: () => <DAG runId={runId} fetching={fetching} />,
2828
path: routePaths.run.stack.statistics(runId, stackId),
2929
},
3030
{
3131
text: 'Configuration',
32-
// <Results runId={runId} stackId={stackId} />
32+
3333
Component: () => <Configuration runId={runId} />,
3434
path: routePaths.run.stack.results(runId, stackId),
3535
},
36-
// {
37-
// text: translate('tabs.tensorboard.text'),
38-
// Component: () => <Tensorboard runId={runId} stackId={stackId} />,
39-
// path: routePaths.run.stack.tensorboard(runId, stackId),
40-
// },
4136
];
4237
};
4338

@@ -73,7 +68,6 @@ export interface RunDetailRouteParams {
7368
}
7469

7570
export const RunDetail: React.FC = () => {
76-
// const { runId, stackId } = useService();
7771
const { runId, stackId, run, fetching } = useService();
7872
const history = useHistory();
7973
const tabPages = getTabPages({

‎src/ui/layouts/stacks/RunDetail/useService.ts‎

Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,7 @@ import {
66
runPagesSelectors,
77
runSelectors,
88
} from '../../../../redux/selectors';
9-
import {
10-
useDispatch,
11-
useParams,
12-
// useRequestOnMount,
13-
useSelector,
14-
} from '../../../hooks';
9+
import { useDispatch, useParams, useSelector } from '../../../hooks';
1510

1611
interface ServiceInterface {
1712
runId: TId;
@@ -25,19 +20,7 @@ export const useService = (): ServiceInterface => {
2520
const dispatch = useDispatch();
2621
const { id, stackId } = useParams<RunDetailRouteParams>();
2722
const [isMounted, setIsMounted] = useState(false);
28-
// useRequestOnMount(() =>
29-
// runsActions.runForId({
30-
// pipelineId,
31-
// runId: id,
32-
// }),
33-
// );
34-
// useRequestOnMount(() =>
35-
// runsActions.graphForRun({
36-
// runId: id,
37-
// onSuccess: () => setFetching(false),
38-
// onFailure: () => setFetching(false),
39-
// }),
40-
// );
23+
4124
useEffect(() => {
4225
if (!isMounted) {
4326
setFetching(true);
@@ -61,17 +44,6 @@ export const useService = (): ServiceInterface => {
6144
// eslint-disable-next-line react-hooks/exhaustive-deps
6245
}, [isMounted, setIsMounted]);
6346

64-
// useEffect(() => {
65-
// setFetching(true);
66-
67-
// dispatch(
68-
// runsActions.graphForRun({
69-
// runId: id,
70-
// onSuccess: () => setFetching(false),
71-
// onFailure: () => setFetching(false),
72-
// }),
73-
// );
74-
// }, [id]);
7547
const fetching = useSelector(runPagesSelectors.fetching);
7648
const setFetching = (fetching: boolean) => {
7749
dispatch(runPagesActions.setFetching({ fetching }));

‎src/ui/layouts/stacks/RunsTable/HeaderCols/index.tsx‎

Lines changed: 12 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import _ from 'lodash';
22
import React from 'react';
3-
// import cn from 'classnames';
43

5-
// import styles from '../index.module.scss';
64
import { iconColors, iconSizes, ID_MAX_LENGTH } from '../../../../../constants';
7-
// import { translate } from '../translate';
5+
86
import {
97
formatDateToDisplay,
108
truncate,
@@ -16,20 +14,17 @@ import { routePaths } from '../../../../../routes/routePaths';
1614
import {
1715
FlexBox,
1816
Paragraph,
19-
// LinkBox,
2017
Box,
2118
icons,
2219
ColoredCircle,
2320
} from '../../../../components';
2421
import { HeaderCol } from '../../../common/Table';
2522
import { RunStatus } from '../RunStatus';
26-
// import { RunTime } from '../../RunTime';
27-
// import { RunUser } from '../RunUser';
23+
2824
import { SortingHeader } from '../SortingHeader';
2925
import { Sorting, SortingDirection } from '../types';
3026
import { useService } from './useService';
3127
import ReactTooltip from 'react-tooltip';
32-
// import { PipelineName } from '../PipelineName';
3328

3429
export const useHeaderCols = ({
3530
runs,
@@ -46,14 +41,7 @@ export const useHeaderCols = ({
4641
setActiveSortingDirection: (direction: SortingDirection | null) => void;
4742
setActiveSorting: (sorting: Sorting | null) => void;
4843
}): HeaderCol[] => {
49-
const {
50-
// toggleSelectRun,
51-
// isRunSelected,
52-
// selectRuns,
53-
// unselectRuns,
54-
// allRunsSelected,
55-
sortMethod,
56-
} = useService({
44+
const { sortMethod } = useService({
5745
setActiveSortingDirection,
5846
setActiveSorting,
5947
setRuns,
@@ -91,16 +79,8 @@ export const useHeaderCols = ({
9179
{truncate(run.id, ID_MAX_LENGTH)}
9280
</Paragraph>
9381
</div>
94-
<ReactTooltip
95-
id={run.id}
96-
place="top"
97-
effect="solid"
98-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
99-
>
100-
<Paragraph color="white">
101-
{run.id}
102-
{/* {truncate(pipeline.id, ID_MAX_LENGTH)} */}
103-
</Paragraph>
82+
<ReactTooltip id={run.id} place="top" effect="solid">
83+
<Paragraph color="white">{run.id}</Paragraph>
10484
</ReactTooltip>
10585
</FlexBox>
10686
),
@@ -126,18 +106,9 @@ export const useHeaderCols = ({
126106
<div style={{ alignItems: 'center' }}>
127107
<div data-tip data-for={run.name}>
128108
<Paragraph size="small">{run.name}</Paragraph>
129-
{/* <Paragraph size="small">{pipeline.name}</Paragraph> */}
130109
</div>
131-
<ReactTooltip
132-
id={run.name}
133-
place="top"
134-
effect="solid"
135-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
136-
>
137-
<Paragraph color="white">
138-
{run.name}
139-
{/* {translate(`tooltips.${invoice.status}`)} */}
140-
</Paragraph>
110+
<ReactTooltip id={run.name} place="top" effect="solid">
111+
<Paragraph color="white">{run.name}</Paragraph>
141112
</ReactTooltip>
142113
</div>
143114
),
@@ -178,18 +149,9 @@ export const useHeaderCols = ({
178149
>
179150
{run.pipeline?.name}
180151
</Paragraph>
181-
{/* <Paragraph size="small">{pipeline.name}</Paragraph> */}
182152
</div>
183-
<ReactTooltip
184-
id={run.pipeline?.name}
185-
place="top"
186-
effect="solid"
187-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
188-
>
189-
<Paragraph color="white">
190-
{run.pipeline?.name}
191-
{/* {translate(`tooltips.${invoice.status}`)} */}
192-
</Paragraph>
153+
<ReactTooltip id={run.pipeline?.name} place="top" effect="solid">
154+
<Paragraph color="white">{run.pipeline?.name}</Paragraph>
193155
</ReactTooltip>
194156
</FlexBox>
195157
),
@@ -248,18 +210,9 @@ export const useHeaderCols = ({
248210
>
249211
{run.stack?.name}
250212
</Paragraph>
251-
{/* <Paragraph size="small">{pipeline.name}</Paragraph> */}
252213
</div>
253-
<ReactTooltip
254-
id={run.stack?.name}
255-
place="top"
256-
effect="solid"
257-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
258-
>
259-
<Paragraph color="white">
260-
{run.stack?.name}
261-
{/* {translate(`tooltips.${invoice.status}`)} */}
262-
</Paragraph>
214+
<ReactTooltip id={run.stack?.name} place="top" effect="solid">
215+
<Paragraph color="white">{run.stack?.name}</Paragraph>
263216
</ReactTooltip>
264217
</FlexBox>
265218
),
@@ -281,9 +234,6 @@ export const useHeaderCols = ({
281234
AUTHOR
282235
</Paragraph>
283236
</SortingHeader>
284-
// <Paragraph size="small" color="black" style={{ fontSize: '12px' }}>
285-
// AUTHOR
286-
// </Paragraph>
287237
),
288238
width: '10%',
289239
renderRow: (run: TRun) => {
@@ -311,11 +261,9 @@ export const useHeaderCols = ({
311261
id={run.user.full_name ? run.user.full_name : run.user.name}
312262
place="top"
313263
effect="solid"
314-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
315264
>
316265
<Paragraph color="white">
317266
{run.user.full_name ? run.user.full_name : run.user.name}
318-
{/* {translate(`tooltips.${invoice.status}`)} */}
319267
</Paragraph>
320268
</ReactTooltip>
321269
</FlexBox>
@@ -361,12 +309,8 @@ export const useHeaderCols = ({
361309
id={formatDateToSort(run.created)}
362310
place="top"
363311
effect="solid"
364-
// backgroundColor={getBGColorFromInvoiceStatus(invoice.status)}
365312
>
366-
<Paragraph color="white">
367-
{run.created}
368-
{/* {translate(`tooltips.${invoice.status}`)} */}
369-
</Paragraph>
313+
<Paragraph color="white"></Paragraph>
370314
</ReactTooltip>
371315
</FlexBox>
372316
),

0 commit comments

Comments
 (0)