Skip to content

Commit 258818c

Browse files
fixed flicker issue while sorting ( remove sorting from FE )
1 parent a074f94 commit 258818c

File tree

8 files changed

+24
-24
lines changed

8 files changed

+24
-24
lines changed

src/ui/layouts/pipelines/Pipelines/List/ForSorting/useServiceForSorting.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,17 +94,17 @@ export const useService = ({
9494
) => () => {
9595
if (sorting === activeSorting) {
9696
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
97-
sort && setFilteredPipelines(sort.desc(filteredPipelines));
97+
// sort && setFilteredPipelines(sort.desc(filteredPipelines));
9898
setActiveSortingDirection('DESC');
9999
} else if (
100100
!!activeSortingDirection &&
101101
activeSortingDirection === 'DESC'
102102
) {
103-
sort && setFilteredPipelines(sort.asc(filteredPipelines));
103+
// sort && setFilteredPipelines(sort.asc(filteredPipelines));
104104
setActiveSortingDirection('ASC');
105105
}
106106
} else {
107-
sort && setFilteredPipelines(sort.desc(filteredPipelines));
107+
// sort && setFilteredPipelines(sort.desc(filteredPipelines));
108108
setActiveSortingDirection('DESC');
109109
}
110110
setActiveSorting(sorting);

src/ui/layouts/pipelines/RunsTable/HeaderCols/useService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,17 +74,17 @@ export const useService = ({
7474
) => () => {
7575
if (sorting === activeSorting) {
7676
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
77-
sort && setRuns(sort.desc(runs));
77+
// sort && setRuns(sort.desc(runs));
7878
setActiveSortingDirection('DESC');
7979
} else if (
8080
!!activeSortingDirection &&
8181
activeSortingDirection === 'DESC'
8282
) {
83-
sort && setRuns(sort.asc(runs));
83+
// sort && setRuns(sort.asc(runs));
8484
setActiveSortingDirection('ASC');
8585
}
8686
} else {
87-
sort && setRuns(sort.desc(runs));
87+
// sort && setRuns(sort.desc(runs));
8888
setActiveSortingDirection('DESC');
8989
}
9090
setActiveSorting(sorting);

src/ui/layouts/runs/RunsTable/HeaderCols/useService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,17 +79,17 @@ export const useService = ({
7979
) => () => {
8080
if (sorting === activeSorting) {
8181
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
82-
sort && setRuns(sort.desc(runs));
82+
// sort && setRuns(sort.desc(runs));
8383
setActiveSortingDirection('DESC');
8484
} else if (
8585
!!activeSortingDirection &&
8686
activeSortingDirection === 'DESC'
8787
) {
88-
sort && setRuns(sort.asc(runs));
88+
// sort && setRuns(sort.asc(runs));
8989
setActiveSortingDirection('ASC');
9090
}
9191
} else {
92-
sort && setRuns(sort.desc(runs));
92+
// sort && setRuns(sort.desc(runs));
9393
setActiveSortingDirection('DESC');
9494
}
9595
setActiveSorting(sorting);

src/ui/layouts/settings/Organization/ForSorting/useServiceForSorting.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,17 @@ export const useService = ({
8888
) => () => {
8989
if (sorting === activeSorting) {
9090
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
91-
sort && setFilteredMembers(sort.desc(filteredMembers));
91+
// sort && setFilteredMembers(sort.desc(filteredMembers));
9292
setActiveSortingDirection('DESC');
9393
} else if (
9494
!!activeSortingDirection &&
9595
activeSortingDirection === 'DESC'
9696
) {
97-
sort && setFilteredMembers(sort.asc(filteredMembers));
97+
// sort && setFilteredMembers(sort.asc(filteredMembers));
9898
setActiveSortingDirection('ASC');
9999
}
100100
} else {
101-
sort && setFilteredMembers(sort.desc(filteredMembers));
101+
// sort && setFilteredMembers(sort.desc(filteredMembers));
102102
setActiveSortingDirection('DESC');
103103
}
104104
setActiveSorting(sorting);

src/ui/layouts/stackComponents/RunsTable/HeaderCols/useService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,17 +79,17 @@ export const useService = ({
7979
) => () => {
8080
if (sorting === activeSorting) {
8181
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
82-
sort && setRuns(sort.desc(runs));
82+
// sort && setRuns(sort.desc(runs));
8383
setActiveSortingDirection('DESC');
8484
} else if (
8585
!!activeSortingDirection &&
8686
activeSortingDirection === 'DESC'
8787
) {
88-
sort && setRuns(sort.asc(runs));
88+
// sort && setRuns(sort.asc(runs));
8989
setActiveSortingDirection('ASC');
9090
}
9191
} else {
92-
sort && setRuns(sort.desc(runs));
92+
// sort && setRuns(sort.desc(runs));
9393
setActiveSortingDirection('DESC');
9494
}
9595
setActiveSorting(sorting);

src/ui/layouts/stackComponents/Stacks/List/ForSorting/useServiceForSorting.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,17 @@ export const useService = ({
8888
) => () => {
8989
if (sorting === activeSorting) {
9090
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
91-
sort && setFilteredStacks(sort.desc(filteredStacks));
91+
// sort && setFilteredStacks(sort.desc(filteredStacks));
9292
setActiveSortingDirection('DESC');
9393
} else if (
9494
!!activeSortingDirection &&
9595
activeSortingDirection === 'DESC'
9696
) {
97-
sort && setFilteredStacks(sort.asc(filteredStacks));
97+
// sort && setFilteredStacks(sort.asc(filteredStacks));
9898
setActiveSortingDirection('ASC');
9999
}
100100
} else {
101-
sort && setFilteredStacks(sort.desc(filteredStacks));
101+
// sort && setFilteredStacks(sort.desc(filteredStacks));
102102
setActiveSortingDirection('DESC');
103103
}
104104
setActiveSorting(sorting);

src/ui/layouts/stacks/RunsTable/HeaderCols/useService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,17 +79,17 @@ export const useService = ({
7979
) => () => {
8080
if (sorting === activeSorting) {
8181
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
82-
sort && setRuns(sort.desc(runs));
82+
// sort && setRuns(sort.desc(runs));
8383
setActiveSortingDirection('DESC');
8484
} else if (
8585
!!activeSortingDirection &&
8686
activeSortingDirection === 'DESC'
8787
) {
88-
sort && setRuns(sort.asc(runs));
88+
// sort && setRuns(sort.asc(runs));
8989
setActiveSortingDirection('ASC');
9090
}
9191
} else {
92-
sort && setRuns(sort.desc(runs));
92+
// sort && setRuns(sort.desc(runs));
9393
setActiveSortingDirection('DESC');
9494
}
9595
setActiveSorting(sorting);

src/ui/layouts/stacks/Stacks/List/ForSorting/useServiceForSorting.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,17 +88,17 @@ export const useService = ({
8888
) => () => {
8989
if (sorting === activeSorting) {
9090
if (!!activeSortingDirection && activeSortingDirection === 'ASC') {
91-
sort && setFilteredStacks(sort.desc(filteredStacks));
91+
// sort && setFilteredStacks(sort.desc(filteredStacks));
9292
setActiveSortingDirection('DESC');
9393
} else if (
9494
!!activeSortingDirection &&
9595
activeSortingDirection === 'DESC'
9696
) {
97-
sort && setFilteredStacks(sort.asc(filteredStacks));
97+
// sort && setFilteredStacks(sort.asc(filteredStacks));
9898
setActiveSortingDirection('ASC');
9999
}
100100
} else {
101-
sort && setFilteredStacks(sort.desc(filteredStacks));
101+
// sort && setFilteredStacks(sort.desc(filteredStacks));
102102
setActiveSortingDirection('DESC');
103103
}
104104
setActiveSorting(sorting);

0 commit comments

Comments
 (0)