Skip to content

Commit 3e8840d

Browse files
authored
Merge pull request #59 from zenml-io/talha/feedback-fixes
fixed issue on side bar.
2 parents 26eb60d + d7be819 commit 3e8840d

File tree

3 files changed

+19
-12
lines changed

3 files changed

+19
-12
lines changed
Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,30 @@
11
import React, { useState } from 'react';
22

33
import { FlexBox, Box } from '../../../../components';
4+
import { useLocationPath } from '../../../../hooks';
45
import { AuthenticatedHeader } from './AuthenticatedHeader';
56
import { AuthenticatedSidebar } from './AuthenticatedSidebar';
67

78
import styles from './index.module.scss';
89

9-
export const AuthenticatedLayout: React.FC = ({ children }) => {
10-
const [mobileMenuOpen, setMobileMenuOpen] = useState(false);
10+
export const AuthenticatedLayout: React.FC = ({ children }) => {
11+
const locationPath = useLocationPath();
12+
const [mobileMenuOpen, setMobileMenuOpen] = useState(
13+
locationPath.includes('components') ? true : false,
14+
);
1115

1216
return (
13-
<FlexBox>
14-
<AuthenticatedSidebar setMobileMenuOpen={setMobileMenuOpen} mobileMenuOpen={mobileMenuOpen} />
15-
<FlexBox flexDirection='column' className={styles.content} flex={1}>
16-
<Box><AuthenticatedHeader setMobileMenuOpen={setMobileMenuOpen} /></Box>
17-
<FlexBox>
18-
{children}
19-
</FlexBox>
20-
</FlexBox>
17+
<FlexBox>
18+
<AuthenticatedSidebar
19+
setMobileMenuOpen={setMobileMenuOpen}
20+
mobileMenuOpen={mobileMenuOpen}
21+
/>
22+
<FlexBox flexDirection="column" className={styles.content} flex={1}>
23+
<Box>
24+
<AuthenticatedHeader setMobileMenuOpen={setMobileMenuOpen} />
25+
</Box>
26+
<FlexBox>{children}</FlexBox>
2127
</FlexBox>
28+
</FlexBox>
2229
);
2330
};

src/ui/layouts/pipelines/Pipelines/useService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const useService = (): ServiceInterface => {
3131
onFailure: () => setFetching(false),
3232
}),
3333
);
34-
});
34+
}, []);
3535

3636
const setFetching = (fetching: boolean) => {
3737
dispatch(pipelinePagesActions.setFetching({ fetching }));

src/ui/layouts/stacks/RunsTable/HeaderCols/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ export const useHeaderCols = ({
309309
place="top"
310310
effect="solid"
311311
>
312-
<Paragraph color="white"></Paragraph>
312+
<Paragraph color="white">{run.created}</Paragraph>
313313
</ReactTooltip>
314314
</FlexBox>
315315
),

0 commit comments

Comments
 (0)