Skip to content

Commit 5ffa36f

Browse files
talhainvenxiontalhainvenxion
authored
Merge pull request #130 from zenml-io/QA-Fixes
hotfix to remove icon column
2 parents 556d917 + 3c057c9 commit 5ffa36f

File tree

8 files changed

+117
-124
lines changed

8 files changed

+117
-124
lines changed

‎src/ui/layouts/common/Table/index.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,8 @@ export const Table: React.FC<TableProps> = ({
370370

371371
<div
372372
style={{ height: tableHeight }}
373-
onMouseDown={() => i !== 0 && mouseDown(i)}
373+
// onMouseDown={() => i !== 0 && mouseDown(i)}
374+
onMouseDown={() => mouseDown(i)}
374375
className={`resize-handle ${
375376
activeIndex === i ? 'active' : 'idle'
376377
}`}

‎src/ui/layouts/pipelines/Pipelines/List/getHeaderCols.tsx‎

Lines changed: 45 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -49,51 +49,51 @@ export const GetHeaderCols = ({
4949
});
5050
console.log('expendedRow', expendedRow);
5151
return [
52-
{
53-
width: '3%',
54-
renderRow: (pipeline: TPipeline) => (
55-
<FlexBox
56-
justifyContent="center"
57-
style={{ paddingTop: '5px', paddingBottom: '5px' }}
58-
>
59-
{expendedRow?.length === 1 ? (
60-
<icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
61-
) : (
62-
<icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
63-
)}
64-
</FlexBox>
65-
// <LinkBox
66-
// style={{ padding: 0 }}
67-
// onClick={(e: Event) => {
68-
// e.stopPropagation();
69-
// if (openPipelineIds.indexOf(pipeline.id) === -1) {
70-
// setOpenPipelineIds([...openPipelineIds, pipeline.id]);
71-
// } else {
72-
// setOpenPipelineIds(
73-
// openPipelineIds.filter((id: TId) => id !== pipeline.id),
74-
// );
75-
// }
76-
// }}
77-
// >
78-
// <FlexBox
79-
// justifyContent="center"
80-
// style={{ paddingTop: '5px', paddingBottom: '5px' }}
81-
// >
82-
// {openPipelineIds.indexOf(pipeline.id) === -1 ? (
83-
// <icons.chevronDownLight
84-
// color={iconColors.grey}
85-
// size={iconSizes.sm}
86-
// />
87-
// ) : (
88-
// <icons.chevronUpLight
89-
// color={iconColors.grey}
90-
// size={iconSizes.sm}
91-
// />
92-
// )}
93-
// </FlexBox>
94-
// </LinkBox>
95-
),
96-
},
52+
// {
53+
// width: '3%',
54+
// renderRow: (pipeline: TPipeline) => (
55+
// <FlexBox
56+
// justifyContent="center"
57+
// style={{ paddingTop: '5px', paddingBottom: '5px' }}
58+
// >
59+
// {expendedRow?.length === 1 ? (
60+
// <icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
61+
// ) : (
62+
// <icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
63+
// )}
64+
// </FlexBox>
65+
// // <LinkBox
66+
// // style={{ padding: 0 }}
67+
// // onClick={(e: Event) => {
68+
// // e.stopPropagation();
69+
// // if (openPipelineIds.indexOf(pipeline.id) === -1) {
70+
// // setOpenPipelineIds([...openPipelineIds, pipeline.id]);
71+
// // } else {
72+
// // setOpenPipelineIds(
73+
// // openPipelineIds.filter((id: TId) => id !== pipeline.id),
74+
// // );
75+
// // }
76+
// // }}
77+
// // >
78+
// // <FlexBox
79+
// // justifyContent="center"
80+
// // style={{ paddingTop: '5px', paddingBottom: '5px' }}
81+
// // >
82+
// // {openPipelineIds.indexOf(pipeline.id) === -1 ? (
83+
// // <icons.chevronDownLight
84+
// // color={iconColors.grey}
85+
// // size={iconSizes.sm}
86+
// // />
87+
// // ) : (
88+
// // <icons.chevronUpLight
89+
// // color={iconColors.grey}
90+
// // size={iconSizes.sm}
91+
// // />
92+
// // )}
93+
// // </FlexBox>
94+
// // </LinkBox>
95+
// ),
96+
// },
9797
{
9898
render: () => (
9999
<SortingHeader

‎src/ui/layouts/pipelines/RunsTable/HeaderCols/index.tsx‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -231,19 +231,19 @@ export const useHeaderCols = ({
231231
},
232232
]
233233
: [
234-
{
235-
render: () => (
236-
<FlexBox justifyContent="center">
237-
<Paragraph
238-
size="small"
239-
color="grey"
240-
style={{ fontSize: '12px' }}
241-
></Paragraph>
242-
</FlexBox>
243-
),
244-
width: '3%',
245-
renderRow: (run: TRun) => <></>,
246-
},
234+
// {
235+
// render: () => (
236+
// <FlexBox justifyContent="center">
237+
// <Paragraph
238+
// size="small"
239+
// color="grey"
240+
// style={{ fontSize: '12px' }}
241+
// ></Paragraph>
242+
// </FlexBox>
243+
// ),
244+
// width: '3%',
245+
// renderRow: (run: TRun) => <></>,
246+
// },
247247
{
248248
render: () => (
249249
<SortingHeader

‎src/ui/layouts/runs/RunsTable/HeaderCols/index.tsx‎

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,9 @@ import React from 'react';
33

44
import { iconColors, iconSizes, ID_MAX_LENGTH } from '../../../../../constants';
55

6-
import {
7-
truncate,
8-
formatDateToDisplayOnTable,
9-
} from '../../../../../utils';
6+
import { truncate, formatDateToDisplayOnTable } from '../../../../../utils';
107

11-
import {
12-
FlexBox,
13-
Paragraph,
14-
Box,
15-
icons,
16-
} from '../../../../components';
8+
import { FlexBox, Paragraph, Box, icons } from '../../../../components';
179
import { HeaderCol } from '../../../common/Table';
1810
import { RunStatus } from '../RunStatus';
1911

@@ -46,10 +38,10 @@ export const useHeaderCols = ({
4638
runs,
4739
});
4840
return [
49-
{
50-
width: '2%',
51-
renderRow: (stack: TStack) => <></>,
52-
},
41+
// {
42+
// width: '2%',
43+
// renderRow: (stack: TStack) => <></>,
44+
// },
5345
{
5446
render: () => (
5547
<SortingHeader

‎src/ui/layouts/stackComponents/RunsTable/HeaderCols/index.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ export const useHeaderCols = ({
4343
const selectedWorkspace = useSelector(workspaceSelectors.selectedWorkspace);
4444

4545
return [
46-
{
47-
width: '2%',
48-
renderRow: (stack: TStack) => <></>,
49-
},
46+
// {
47+
// width: '2%',
48+
// renderRow: (stack: TStack) => <></>,
49+
// },
5050
{
5151
render: () => (
5252
<SortingHeader

‎src/ui/layouts/stackComponents/Stacks/List/getHeaderCols.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export const GetHeaderCols = ({
4646

4747
console.log(expendedRow, 'expendedRow');
4848
return [
49-
{
50-
width: '2%',
51-
renderRow: (stackComponent: TStack) => <></>,
52-
},
49+
// {
50+
// width: '2%',
51+
// renderRow: (stackComponent: TStack) => <></>,
52+
// },
5353

5454
{
5555
render: () => (

‎src/ui/layouts/stacks/RunsTable/HeaderCols/index.tsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@ export const useHeaderCols = ({
4343
const selectedWorkspace = useSelector(workspaceSelectors.selectedWorkspace);
4444

4545
return [
46-
{
47-
width: '2%',
48-
renderRow: (stack: TStack) => <></>,
49-
},
46+
// {
47+
// width: '2%',
48+
// renderRow: (stack: TStack) => <></>,
49+
// },
5050
{
5151
render: () => (
5252
<SortingHeader

‎src/ui/layouts/stacks/Stacks/List/getHeaderCols.tsx‎

Lines changed: 39 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -51,45 +51,45 @@ export const GetHeaderCols = ({
5151

5252
// const [toggle, setToggle] = useState(false);
5353
return [
54-
{
55-
width: '3%',
56-
renderRow: (stack: TStack) => (
57-
<FlexBox
58-
justifyContent="center"
59-
style={{ paddingTop: '5px', paddingBottom: '5px' }}
60-
>
61-
{expendedRow.length === 1 ? (
62-
<icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
63-
) : (
64-
<icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
65-
)}
66-
</FlexBox>
67-
// <LinkBox
68-
// onClick={(e: Event) => {
69-
// setToggle(!toggle);
70-
// e.stopPropagation();
71-
// if (openStackIds.indexOf(stack.id) === -1) {
72-
// setOpenStackIds([...openStackIds, stack.id]);
73-
// } else {
74-
// setOpenStackIds(
75-
// openStackIds.filter((id: TId) => id !== stack.id),
76-
// );
77-
// }
78-
// }}
79-
// >
80-
// <FlexBox
81-
// justifyContent="center"
82-
// style={{ paddingTop: '5px', paddingBottom: '5px' }}
83-
// >
84-
// {openStackIds.indexOf(stack.id) === -1 ? (
85-
// <icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
86-
// ) : (
87-
// <icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
88-
// )}
89-
// </FlexBox>
90-
// </LinkBox>
91-
),
92-
},
54+
// {
55+
// width: '3%',
56+
// renderRow: (stack: TStack) => (
57+
// <FlexBox
58+
// justifyContent="center"
59+
// style={{ paddingTop: '5px', paddingBottom: '5px' }}
60+
// >
61+
// {expendedRow.length === 1 ? (
62+
// <icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
63+
// ) : (
64+
// <icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
65+
// )}
66+
// </FlexBox>
67+
// // <LinkBox
68+
// // onClick={(e: Event) => {
69+
// // setToggle(!toggle);
70+
// // e.stopPropagation();
71+
// // if (openStackIds.indexOf(stack.id) === -1) {
72+
// // setOpenStackIds([...openStackIds, stack.id]);
73+
// // } else {
74+
// // setOpenStackIds(
75+
// // openStackIds.filter((id: TId) => id !== stack.id),
76+
// // );
77+
// // }
78+
// // }}
79+
// // >
80+
// // <FlexBox
81+
// // justifyContent="center"
82+
// // style={{ paddingTop: '5px', paddingBottom: '5px' }}
83+
// // >
84+
// // {openStackIds.indexOf(stack.id) === -1 ? (
85+
// // <icons.rightArrow color={iconColors.grey} size={iconSizes.sm} />
86+
// // ) : (
87+
// // <icons.chevronDown color={iconColors.grey} size={iconSizes.sm} />
88+
// // )}
89+
// // </FlexBox>
90+
// // </LinkBox>
91+
// ),
92+
// },
9393
{
9494
render: () => (
9595
<SortingHeader

0 commit comments

Comments
 (0)