Skip to content

Commit c31ed4a

Browse files
Merge pull request #157 from zenml-io/QA-Fixes
Qa fixes
2 parents 32a3103 + 8b33363 commit c31ed4a

File tree

2 files changed

+20
-9
lines changed

2 files changed

+20
-9
lines changed

src/ui/components/Filters/index.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ export const getInitialFilterStateForRuns = () => {
293293
},
294294
{
295295
value: 'pipeline_id',
296-
label: 'Pipeline Name',
296+
label: 'Pipeline',
297297
type: 'string',
298298
},
299299
{
@@ -582,7 +582,7 @@ const FilterComponent = ({
582582

583583
return member[0].name;
584584
}
585-
if (typeName === 'Pipeline Name') {
585+
if (typeName === 'Pipeline') {
586586
const pipeline = pipelines.filter((item) => item.id === value);
587587
return `${pipeline[0].name} ( v${pipeline[0].version} )`;
588588
}
@@ -627,7 +627,7 @@ const FilterComponent = ({
627627
}) as any;
628628
const pipelinesOptions = pipelines.map((item: any) => {
629629
return {
630-
label: `${item.name} ( v${item.version} )` as string,
630+
label: `${item.name} ( v${item.version})` as string,
631631
value: item.id as string,
632632
};
633633
}) as any;
@@ -834,8 +834,7 @@ const FilterComponent = ({
834834
filter.column.selectedValue.label === 'Shared' ||
835835
filter.column.selectedValue.label === 'Status'
836836
? 'is'
837-
: filter.column.selectedValue.label ===
838-
'Pipeline Name' ||
837+
: filter.column.selectedValue.label === 'Pipeline' ||
839838
filter.column.selectedValue.label ===
840839
'Stack Name' ||
841840
filter.column.selectedValue.label === 'Author'

src/ui/layouts/stackComponents/Stacks/List/getHeaderCols.tsx

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,11 @@ export const GetHeaderCols = ({
153153
width: '15%',
154154
renderRow: (stackComponent: TStack) => (
155155
<FlexBox alignItems="center" style={{ marginLeft: '-24px' }}>
156-
<div data-tip data-for={stackComponent.flavor.name} style={{ margin: ' 0 auto 0 auto' }}>
156+
<div
157+
data-tip
158+
data-for={stackComponent?.flavor?.name || stackComponent?.flavor}
159+
style={{ margin: ' 0 auto 0 auto' }}
160+
>
157161
<img
158162
alt={stackComponent.flavor.logoUrl}
159163
src={stackComponent.flavor.logoUrl}
@@ -165,7 +169,11 @@ export const GetHeaderCols = ({
165169
</div>
166170

167171
<ReactTooltip
168-
id={stackComponent.flavor.name}
172+
id={
173+
// stackComponent?.flavor
174+
// ? stackComponent?.flavor
175+
stackComponent?.flavor?.name || stackComponent?.flavor
176+
}
169177
place="top"
170178
effect="solid"
171179
>
@@ -195,8 +203,12 @@ export const GetHeaderCols = ({
195203
),
196204
width: '15%',
197205
renderRow: (stackComponent: TStack) => (
198-
<FlexBox alignItems="center" style={{ marginLeft: '-24px' }}>
199-
<div data-tip data-for={stackComponent.isShared} style={{ margin: '0 auto 0 auto' }}>
206+
<FlexBox alignItems="center" style={{ marginLeft: '-24px' }}>
207+
<div
208+
data-tip
209+
data-for={stackComponent.isShared}
210+
style={{ margin: '0 auto 0 auto' }}
211+
>
200212
<Box>
201213
<FlexBox
202214
justifyContent="center"

0 commit comments

Comments
 (0)