fix: use output over input names

Author: Cahllagerfeld

src/components/dag-visualizer/layout/helper.ts

@@ -68,6 +68,18 @@ export function mergeRealAndPlacehodlerData({
 		const duplicateRealArtifacts = finalNodes.filter((node) => node.id === realArtifact.id);
 		if (duplicateRealArtifacts.length === 0) {
 			finalNodes.push(realArtifact);
+		} else {
+			if (realArtifact.data.artifactType === "output") {
+				for (const node of duplicateRealArtifacts) {
+					// remove node from finalNodes based on id
+					const index = finalNodes.findIndex((finalNode) => finalNode.id === node.id);
+					if (index !== -1) {
+						finalNodes.splice(index, 1);
+					}
+				}
+
+				finalNodes.push(realArtifact);
+			}
 		}
 	});
 

src/components/dag-visualizer/layout/real-data.ts

@@ -36,7 +36,7 @@ function extractNodes(stepConfig: StepDict, substitutions: Record<string, Record
 					placeholderId,
 					type: "artifact",
 					substitutions: substitutions[stepName] || {},
-					data: { ...version, name: outputName }
+					data: { ...version, name: outputName, artifactType: "output" }
 				});
 			});
 		});
@@ -49,7 +49,7 @@ function extractNodes(stepConfig: StepDict, substitutions: Record<string, Record
 				id: artifactVersion.id,
 				placeholderId,
 				type: "artifact",
-				data: { ...artifactVersion, name: inputName }
+				data: { ...artifactVersion, name: inputName, artifactType: "input" }
 			});
 		});
 	});

src/types/pipeline-runs.ts

@@ -11,7 +11,7 @@ export type PipelineRunOvervieweParams = NonNullable<
 >;
 export type PipelineRunPage = components["schemas"]["Page_PipelineRunResponse_"];
 
-type ArtifactNodeDetails = ArtifactVersion & { name: string };
+type ArtifactNodeDetails = ArtifactVersion & { name: string; artifactType: "input" | "output" };
 export type ArtifactNode = {
 	id: string;
 	placeholderId: string;