validate-stack-name-regexp #915
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .min(1, "Stack name is required") | ||
| .max(255, "Stack name must be less than 255 characters") | ||
| .refine((name) => validateStackName(name), "Stack name is already in use"); | ||
| .max(32, "Stack name must be less than 32 characters") |
There was a problem hiding this comment.
How do you come to the conclusion of this?
I just checked the Swagger-Docs and the only restriction is the length of 255 characters that we had before 🤔
There was a problem hiding this comment.
In the designs it was 32, but yes, api is king, so back to 255
| .max(255, "Stack name must be less than 255 characters") | ||
| .refine((name) => validateStackName(name), "Stack name is already in use"); | ||
| .max(32, "Stack name must be less than 32 characters") | ||
| .refine((name) => validateStackNameNotInUse(name), "Stack name is already in use") |
There was a problem hiding this comment.
As sending the request is the most expensive operation during the validation, we should run it as the last validator. Imo only after all the other checks were good, we should run it. Wdyt?
There was a problem hiding this comment.
ok, swapped the order, not sure how much it improves, but if earlier rule fails first, it will show up sooner.
|
PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.