Skip to content

Conversation

@marwan37
Copy link
Contributor

@marwan37 marwan37 commented Apr 11, 2025

This PR adds customized Dockerfile.sandbox files to all demo projects to support our upcoming VS Code sandbox containers.

  1. Created Dockerfile.sandbox for all projects
  2. Added generate_sandbox_dockerfile.py script that:
    • Automatically extracts project dependencies from requirements.txt
    • Detects API keys and environment variables by scanning project files
    • Generates properly formatted Dockerfile.sandbox files with project-specific configurations

Note: The workflow file for automatically building and pushing these Docker images will be submitted in a separate PR to avoid triggering simultaneous builds for all projects, which would overload the runner.

@marwan37 marwan37 added the enhancement New feature or request label Apr 11, 2025
@marwan37 marwan37 merged commit 604767d into main Apr 13, 2025
3 of 4 checks passed
@strickvl strickvl deleted the sandbox/add-dockerfiles-for-remaining-projects branch April 13, 2025 13:43
@strickvl
Copy link
Contributor

@marwan37 for stuff like this, you might want to add someone to review these PRs, not only because it's good in general, but more so that people are aware of what functionality / code etc is in the code base. FYI for future PRs :)

@marwan37
Copy link
Contributor Author

@strickvl You're absolutely right. I merged this one quickly to test the main functionality in the other open PR. I wanted to avoid pushing all project docker images to dockerhub at once... but then I found a safer approach 🙂. In any case, sorry about that, will definitely add reviewers to future PRs.

marwan37 pushed a commit that referenced this pull request Apr 16, 2025
…-for-remaining-projects"

This reverts commit 604767d, reversing
changes made to b820cc9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants