Skip to content

Commit 10f0fcb

Browse files
authored
Ensure visualizations are committed before potential transaction rollback (#3769)
* Ensure visualizations are committed before potential transaction rollback * Remove wrong usage of nested session
1 parent e9a7085 commit 10f0fcb

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/zenml/zen_stores/sql_zen_store.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3037,18 +3037,17 @@ def _get_or_create_artifact_for_name(
30373037

30383038
if artifact is None:
30393039
try:
3040-
with session.begin_nested():
3041-
artifact_request = ArtifactRequest(
3042-
name=name,
3043-
project=project_id,
3044-
has_custom_name=has_custom_name,
3045-
)
3046-
self._set_request_user_id(
3047-
request_model=artifact_request, session=session
3048-
)
3049-
artifact = ArtifactSchema.from_request(artifact_request)
3050-
session.add(artifact)
3051-
session.commit()
3040+
artifact_request = ArtifactRequest(
3041+
name=name,
3042+
project=project_id,
3043+
has_custom_name=has_custom_name,
3044+
)
3045+
self._set_request_user_id(
3046+
request_model=artifact_request, session=session
3047+
)
3048+
artifact = ArtifactSchema.from_request(artifact_request)
3049+
session.add(artifact)
3050+
session.commit()
30523051
session.refresh(artifact)
30533052
except IntegrityError:
30543053
# We have to rollback the failed session first in order to
@@ -3218,6 +3217,7 @@ def create_artifact_version(
32183217
artifact_version_id=artifact_version_schema.id,
32193218
)
32203219
session.add(vis_schema)
3220+
session.commit()
32213221

32223222
# Save tags of the artifact
32233223
self._attach_tags_to_resources(

0 commit comments

Comments
 (0)