Skip to content

Commit 65c4e52

Browse files
authored
Fix secret tags and logs for the AWS deployer (#4056)
* Fix secret tags and logs for the AWS deployer * Fix linter
1 parent 8b6af43 commit 65c4e52

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/zenml/integrations/aws/deployers/aws_deployer.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,9 @@ def _create_or_update_secret(
582582
response = self.secrets_manager_client.update_secret(
583583
SecretId=secret_name,
584584
SecretString=secret_value,
585+
)
586+
self.secrets_manager_client.tag_resource(
587+
SecretId=response["ARN"],
585588
Tags=self.get_tags(deployment, settings),
586589
)
587590
logger.debug(f"Updated existing secret {secret_name}")
@@ -1619,14 +1622,17 @@ def do_get_deployment_state_logs(
16191622
deployment
16201623
)
16211624
service_name = existing_metadata.service_name
1622-
if not service_name:
1625+
service_id = existing_metadata.service_id
1626+
if not service_name or not service_id:
16231627
raise RuntimeError(
1624-
f"Service name not found in deployment metadata for "
1628+
f"Service name or ID not found in deployment metadata for "
16251629
f"deployment '{deployment.name}'"
16261630
)
16271631

16281632
# App Runner automatically creates CloudWatch log groups
1629-
log_group_name = f"/aws/apprunner/{service_name}/service"
1633+
log_group_name = (
1634+
f"/aws/apprunner/{service_name}/{service_id}/application"
1635+
)
16301636

16311637
try:
16321638
streams_response = self.logs_client.describe_log_streams(

0 commit comments

Comments
 (0)