Upgrading mypy (#4062)

* adding new version, removing old version

* use 3.10 for migration tests

* ignore tensorflow for dev environments in 3.13 too

* remove 0.40.3 from the migration tests

* remove importlib_metadata properly

* formatting

* updated pytest-split for 3.13

* some integration changes

* tensorboard changes

* more tensorboard

* ignoring deepchecks tests on 3.13

* skip windows 3.13 due to numpy failures

* ignore 3.13 windows as well

* mypy changes

* middlewares

* ignore

* fixing ignores

* ignores

* name change

Author: bcdurak

pyproject.toml

@@ -121,7 +121,7 @@ dev = [
     "yamlfix>=1.16.0",
     "coverage[toml]>=5.5,<6.0.0",
     "pytest>=7.4.0,<8.0.0",
-    "mypy==1.7.1",
+    "mypy==1.18.1",
     "pre-commit",
     "pyment>=0.3.3,<0.4.0",
     "tox>=3.24.3",

src/zenml/integrations/bentoml/model_deployers/bentoml_model_deployer.py

@@ -142,11 +142,11 @@ def get_model_server_info(
             )
 
         predictions_apis_urls = ""
-        if service_instance.prediction_apis_urls is not None:  # type: ignore
+        if service_instance.prediction_apis_urls is not None:
             predictions_apis_urls = ", ".join(
                 [
                     api
-                    for api in service_instance.prediction_apis_urls  # type: ignore
+                    for api in service_instance.prediction_apis_urls
                     if api is not None
                 ]
             )

src/zenml/integrations/databricks/orchestrators/databricks_orchestrator_entrypoint_config.py

@@ -82,7 +82,9 @@ def run(self) -> None:
         wheel_package = self.entrypoint_args[WHEEL_PACKAGE_OPTION]
 
         dist = distribution(wheel_package)
-        project_root = os.path.join(dist.locate_file("."), wheel_package)
+        project_root = os.path.join(
+            str(dist.locate_file(".")), str(wheel_package)
+        )
 
         if project_root not in sys.path:
             sys.path.insert(0, project_root)

src/zenml/integrations/kubernetes/orchestrators/kubernetes_orchestrator_entrypoint.py

@@ -158,8 +158,10 @@ def _reconstruct_nodes(
     )
     for job in job_list.items:
         annotations = job.metadata.annotations or {}
-        if step_name := annotations.get(STEP_NAME_ANNOTATION_KEY, None):
-            node = nodes[step_name]
+        if step_name_annotation := annotations.get(
+            STEP_NAME_ANNOTATION_KEY, None
+        ):
+            node = nodes[str(step_name_annotation)]
             node.metadata["job_name"] = job.metadata.name
 
             if node.status == NodeStatus.NOT_READY:

src/zenml/integrations/seldon/services/seldon_deployment.py

@@ -72,7 +72,7 @@ class SeldonDeploymentConfig(ServiceConfig):
     model_metadata: Dict[str, Any] = Field(default_factory=dict)
     extra_args: Dict[str, Any] = Field(default_factory=dict)
     is_custom_deployment: Optional[bool] = False
-    spec: Optional[Dict[Any, Any]] = Field(default_factory=dict)  # type: ignore[arg-type]
+    spec: Optional[Dict[Any, Any]] = Field(default_factory=dict)
     serviceAccountName: Optional[str] = None
 
     def get_seldon_deployment_labels(self) -> Dict[str, str]:

src/zenml/models/v2/base/filter.py

@@ -290,7 +290,7 @@ def _handle_numeric_comparison(self, column: Any) -> Any:
                 ),
             }
 
-            return operations[self.operation](numeric_column, self.value)  # type: ignore[no-untyped-call]
+            return operations[self.operation](numeric_column, self.value)
         except Exception as e:
             raise ValueError(
                 f"Failed to compare the column '{column}' to the "
@@ -990,7 +990,7 @@ def apply_sorting(
         column, operand = self.sorting_params
 
         if operand == SorterOps.DESCENDING:
-            sort_clause = desc(getattr(table, column))  # type: ignore[var-annotated]
+            sort_clause = desc(getattr(table, column))
         else:
             sort_clause = asc(getattr(table, column))
 

src/zenml/utils/function_utils.py

@@ -143,7 +143,7 @@ def _cli_wrapped_function(func: F) -> F:
     )
     invalid_types = {}
     for arg_name, arg_type, arg_default in input_args_dict:
-        if _is_valid_optional_arg(arg_type):
+        if arg_type is not None and _is_valid_optional_arg(arg_type):
             arg_type = arg_type.__args__[0]
         arg_name = _cli_arg_name(arg_name)
         if arg_type is bool:
@@ -156,7 +156,7 @@ def _cli_wrapped_function(func: F) -> F:
                     required=False,
                 )
             )
-        elif _is_valid_collection_arg(arg_type):
+        elif arg_type is not None and _is_valid_collection_arg(arg_type):
             member_type = arg_type.__args__[0]
             options.append(
                 click.option(

src/zenml/utils/json_utils.py

@@ -114,7 +114,7 @@ def pydantic_encoder(obj: Any) -> Any:
 
     if isinstance(obj, BaseModel):
         return obj.model_dump(mode="json")
-    elif is_dataclass(obj):
+    elif is_dataclass(obj) and not isinstance(obj, type):
         return asdict(obj)
 
     # Check the class type and its superclasses for a matching encoder

src/zenml/utils/proxy_utils.py

@@ -207,6 +207,6 @@ def _inner_decorator(_cls: C) -> C:
             if method_name not in interface.__abstractmethods__
         )
 
-        return cast(C, _cls)
+        return cast(C, _cls)  # type: ignore[redundant-cast]
 
     return _inner_decorator

src/zenml/utils/string_utils.py

@@ -232,7 +232,7 @@ def substitute_string(value: V, substitution_func: Callable[[str], str]) -> V:
 
             model_values[k] = new_value
 
-        return cast(V, type(value).model_validate(model_values))
+        return cast(V, type(value).model_validate(model_values))  # type: ignore[redundant-cast]
     elif isinstance(value, Dict):
         return cast(
             V, {substitute_(k): substitute_(v) for k, v in value.items()}