[basisbank-ge] add initial support (#941)

Author: logunovFGP

.gitignore

@@ -53,3 +53,20 @@ Thumbs.db
 /yarn-error.log
 /.yarnrc
 /.yarn/
+
+# repository docs/plans
+AGENT.md
+AGENTS.md
+*PLAN*.md
+plans/archive/
+**/plans/archive/
+
+# local AI/context artifacts
+*llm.txt
+review/
+
+# local capture/debug artifacts
+.local/
+.tmp-*/
+.tmp-*
+BASISBANK_LOCAL_TEST_STEPS.md

scripts/wrapper.js

@@ -9,8 +9,21 @@ if (pluginIndex !== -1) {
   args = args.slice(0, pluginIndex).concat(`PLUGIN=${pluginValue}`)
 }
 
-const result = spawnSync(command, args, {
+const spawnOptions = {
   env: { ...process.env, NODE_OPTIONS: `--max-old-space-size=${Math.floor(os.totalmem() / (1024 * 1024))}` },
-  stdio: 'inherit'
-})
+  stdio: 'inherit',
+  shell: process.platform === 'win32'
+}
+
+const result = spawnSync(command, args, spawnOptions)
+
+if (result.error) {
+  console.error(`Failed to start command "${command}":`, result.error.message)
+  process.exit(1)
+}
+
+if (typeof result.status !== 'number') {
+  process.exit(1)
+}
+
 process.exit(result.status)

src/handleMessageFromWindow.js

@@ -1,5 +1,61 @@
 import { ZPAPI } from './ZPAPI'
 
+function toSerializableError (error) {
+  if (error == null) {
+    return {
+      name: 'Error',
+      message: 'Unknown error',
+      fatal: false,
+      allowRetry: false,
+      allow_retry: false
+    }
+  }
+
+  const seen = new WeakSet()
+  const sanitize = (value) => {
+    if (value == null || typeof value === 'string' || typeof value === 'number' || typeof value === 'boolean') {
+      return value
+    }
+    if (typeof value === 'function' || typeof value === 'symbol' || typeof value === 'bigint') {
+      return undefined
+    }
+    if (Array.isArray(value)) {
+      return value.map(sanitize)
+    }
+    if (typeof value === 'object') {
+      if (seen.has(value)) {
+        return '[Circular]'
+      }
+      seen.add(value)
+      const out = {}
+      for (const [key, nested] of Object.entries(value)) {
+        const clean = sanitize(nested)
+        if (clean !== undefined) {
+          out[key] = clean
+        }
+      }
+      return out
+    }
+    return undefined
+  }
+
+  const payload = sanitize(error)
+  const result = typeof payload === 'object' && payload != null ? payload : { message: String(error) }
+  if (typeof error.name === 'string' && result.name == null) {
+    result.name = error.name
+  }
+  if (typeof error.message === 'string' && result.message == null) {
+    result.message = error.message
+  }
+  if (typeof error.stack === 'string' && result.stack == null) {
+    result.stack = error.stack
+  }
+  result.fatal = Boolean(result.fatal)
+  result.allowRetry = Boolean(result.allowRetry || result.allow_retry)
+  result.allow_retry = result.allowRetry
+  return result
+}
+
 const messageHandlers = {
   ':commands/execute-sync': async ({ payload: { manifest, preferences, data }, reply }) => {
     reply({ type: ':events/scrape-started' })
@@ -16,7 +72,7 @@ const messageHandlers = {
     } catch (error) {
       reply({
         type: ':events/scrape-error',
-        payload: error
+        payload: toSerializableError(error)
       })
     }
   },

src/plugins/basisbank/README.md

@@ -0,0 +1,28 @@
+# BasisBank Plugin (User Flow)
+
+## What This Plugin Uses
+- BasisBank user internet-banking flow at `https://www.bankonline.ge`
+- Session cookies persisted through ZenMoney cookie storage
+- Card/account endpoints used by the web cabinet:
+  - `GET/POST /Login.aspx`
+  - `GET/POST /Balance.aspx`
+  - `POST /Handlers/BToolkit.ashx?Action=GetSessionId&Type=Login|DeviceBinding`
+  - `POST /Handlers/SendSms.ashx?Module=BankOnlineTransfer`
+  - `POST /Handlers/CardModule.ashx?funq=checksession|getcardlist|getlasttransactionlist`
+
+## Preferences
+- `login`: internet-banking login
+- `password`: internet-banking password
+- `requestSmsCode` (default `true`): trigger bank SMS endpoint before OTP prompt
+- `trustDevice` (default `true`): attempt trusted-device confirmation when bank requests it
+- `startDate`: initial sync date
+
+## Authentication Behavior
+- Plugin restores saved cookies first.
+- If session is dead, plugin performs login flow and OTP confirmation.
+- If trusted-device popup flow is presented, plugin can complete it using OTP and then persist updated cookies.
+
+## Known Limits
+- Flow depends on current bank web behavior and endpoint contracts.
+- If bank changes markup/hidden fields, login flow may need parser updates.
+- If OTP is required and code is not entered in time, synchronization fails with OTP error.

src/plugins/basisbank/ZenmoneyManifest.xml

@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="utf-8"?>
+<provider>
+    <id>basisbank</id>
+    <version>1.0</version>
+    <build>1</build>
+    <company>0</company>
+    <modular>true</modular>
+    <codeRequired>false</codeRequired>
+    <files>
+        <js>index.js</js>
+        <preferences>preferences.xml</preferences>
+    </files>
+    <description>
+        BasisBank Internet Banking synchronization plugin (user flow).
+        Uses login/password with OTP and trusted-device session persistence.
+    </description>
+</provider>