feat(policy): post-update policies (#275)

Author: ymc9

TODO.md

@@ -101,6 +101,7 @@
     - [ ] Short-circuit pre-create check for scalar-field only policies
     - [x] Inject "on conflict do update"
     - [x] `check` function
+    - [ ] Accessing tables not in the schema
 - [x] Migration
 - [ ] Databases
     - [x] SQLite

packages/language/res/stdlib.zmodel

@@ -666,7 +666,7 @@ attribute @@@deprecated(_ message: String)
  * @param operation: comma-separated list of "create", "read", "update", "delete". Use "all" to denote all operations.
  * @param condition: a boolean expression that controls if the operation should be allowed.
  */
-attribute @@allow(_ operation: String @@@completionHint(["'create'", "'read'", "'update'", "'delete'", "'all'"]), _ condition: Boolean)
+attribute @@allow(_ operation: String @@@completionHint(["'create'", "'read'", "'update'", "'post-update'","'delete'", "'all'"]), _ condition: Boolean)
 
 /**
  * Defines an access policy that allows the annotated field to be read or updated.
@@ -684,7 +684,7 @@ attribute @allow(_ operation: String @@@completionHint(["'create'", "'read'", "'
  * @param operation: comma-separated list of "create", "read", "update", "delete". Use "all" to denote all operations.
  * @param condition: a boolean expression that controls if the operation should be denied.
  */
-attribute @@deny(_ operation: String @@@completionHint(["'create'", "'read'", "'update'", "'delete'", "'all'"]), _ condition: Boolean)
+attribute @@deny(_ operation: String @@@completionHint(["'create'", "'read'", "'update'", "'post-update'","'delete'", "'all'"]), _ condition: Boolean)
 
 /**
  * Defines an access policy that denies the annotated field to be read or updated.
@@ -705,8 +705,8 @@ function check(field: Any, operation: String?): Boolean {
 } @@@expressionContext([AccessPolicy])
 
 /**
- * Gets entities value before an update. Only valid when used in a "update" policy rule.
+ * Gets entity's value before an update. Only valid when used in a "post-update" policy rule.
  */
-function future(): Any {
+function before(): Any {
 } @@@expressionContext([AccessPolicy])
 

packages/language/src/utils.ts

@@ -145,10 +145,6 @@ export function isRelationshipField(field: DataField) {
     return isDataModel(field.type.reference?.ref);
 }
 
-export function isFutureExpr(node: AstNode) {
-    return isInvocationExpr(node) && node.function.ref?.name === 'future' && isFromStdlib(node.function.ref);
-}
-
 export function isDelegateModel(node: AstNode) {
     return isDataModel(node) && hasAttribute(node, '@@delegate');
 }
@@ -450,8 +446,8 @@ export function getAuthDecl(decls: (DataModel | TypeDef)[]) {
     return authModel;
 }
 
-export function isFutureInvocation(node: AstNode) {
-    return isInvocationExpr(node) && node.function.ref?.name === 'future' && isFromStdlib(node.function.ref);
+export function isBeforeInvocation(node: AstNode) {
+    return isInvocationExpr(node) && node.function.ref?.name === 'before' && isFromStdlib(node.function.ref);
 }
 
 export function isCollectionPredicate(node: AstNode): node is BinaryExpr {

packages/language/src/validators/attribute-application-validator.ts

@@ -23,10 +23,10 @@ import {
     getAllAttributes,
     getStringLiteral,
     isAuthOrAuthMemberAccess,
+    isBeforeInvocation,
     isCollectionPredicate,
     isDataFieldReference,
     isDelegateModel,
-    isFutureExpr,
     isRelationshipField,
     mapBuiltinTypeToExpressionType,
     resolved,
@@ -166,13 +166,20 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
             });
             return;
         }
-        this.validatePolicyKinds(kind, ['create', 'read', 'update', 'delete', 'all'], attr, accept);
+        this.validatePolicyKinds(kind, ['create', 'read', 'update', 'post-update', 'delete', 'all'], attr, accept);
 
         if ((kind === 'create' || kind === 'all') && attr.args[1]?.value) {
             // "create" rules cannot access non-owned relations because the entity does not exist yet, so
             // there can't possibly be a fk that points to it
             this.rejectNonOwnedRelationInExpression(attr.args[1].value, accept);
         }
+
+        if (kind !== 'post-update' && attr.args[1]?.value) {
+            const beforeCall = AstUtils.streamAst(attr.args[1]?.value).find(isBeforeInvocation);
+            if (beforeCall) {
+                accept('error', `"before()" is only allowed in "post-update" policy rules`, { node: beforeCall });
+            }
+        }
     }
 
     private rejectNonOwnedRelationInExpression(expr: Expression, accept: ValidationAcceptor) {
@@ -251,8 +258,8 @@ export default class AttributeApplicationValidator implements AstValidator<Attri
         const kindItems = this.validatePolicyKinds(kind, ['read', 'update', 'all'], attr, accept);
 
         const expr = attr.args[1]?.value;
-        if (expr && AstUtils.streamAst(expr).some((node) => isFutureExpr(node))) {
-            accept('error', `"future()" is not allowed in field-level policy rules`, { node: expr });
+        if (expr && AstUtils.streamAst(expr).some((node) => isBeforeInvocation(node))) {
+            accept('error', `"before()" is not allowed in field-level policy rules`, { node: expr });
         }
 
         // 'update' rules are not allowed for relation fields

packages/language/src/validators/expression-validator.ts

@@ -11,13 +11,15 @@ import {
     isNullExpr,
     isReferenceExpr,
     isThisExpr,
+    MemberAccessExpr,
     type ExpressionType,
 } from '../generated/ast';
 
 import {
     findUpAst,
     isAuthInvocation,
     isAuthOrAuthMemberAccess,
+    isBeforeInvocation,
     isDataFieldReference,
     isEnumFieldReference,
     typeAssignable,
@@ -59,12 +61,21 @@ export default class ExpressionValidator implements AstValidator<Expression> {
 
         // extra validations by expression type
         switch (expr.$type) {
+            case 'MemberAccessExpr':
+                this.validateMemberAccessExpr(expr, accept);
+                break;
             case 'BinaryExpr':
                 this.validateBinaryExpr(expr, accept);
                 break;
         }
     }
 
+    private validateMemberAccessExpr(expr: MemberAccessExpr, accept: ValidationAcceptor) {
+        if (isBeforeInvocation(expr.operand) && isDataModel(expr.$resolvedType?.decl)) {
+            accept('error', 'relation fields cannot be accessed from `before()`', { node: expr });
+        }
+    }
+
     private validateBinaryExpr(expr: BinaryExpr, accept: ValidationAcceptor) {
         switch (expr.operator) {
             case 'in': {

packages/language/src/zmodel-linker.ts

@@ -57,7 +57,7 @@ import {
     getAuthDecl,
     getContainingDataModel,
     isAuthInvocation,
-    isFutureExpr,
+    isBeforeInvocation,
     isMemberContainer,
     mapBuiltinTypeToExpressionType,
 } from './utils';
@@ -292,8 +292,8 @@ export class ZModelLinker extends DefaultLinker {
                 if (authDecl) {
                     node.$resolvedType = { decl: authDecl, nullable: true };
                 }
-            } else if (isFutureExpr(node)) {
-                // future() function is resolved to current model
+            } else if (isBeforeInvocation(node)) {
+                // before() function is resolved to current model
                 node.$resolvedType = { decl: getContainingDataModel(node) };
             } else {
                 this.resolveToDeclaredType(node, funcDecl.returnType);

packages/language/src/zmodel-scope.ts

@@ -37,7 +37,7 @@ import {
     getRecursiveBases,
     isAuthInvocation,
     isCollectionPredicate,
-    isFutureInvocation,
+    isBeforeInvocation,
     resolveImportUri,
 } from './utils';
 
@@ -170,8 +170,8 @@ export class ZModelScopeProvider extends DefaultScopeProvider {
                     return this.createScopeForAuth(node, globalScope);
                 }
 
-                if (isFutureInvocation(operand)) {
-                    // resolve `future()` to the containing model
+                if (isBeforeInvocation(operand)) {
+                    // resolve `before()` to the containing model
                     return this.createScopeForContainingModel(node, globalScope);
                 }
                 return EMPTY_SCOPE;

packages/language/test/attribute-application.test.ts

@@ -0,0 +1,23 @@
+import { describe, it } from 'vitest';
+import { loadSchemaWithError } from './utils';
+
+describe('Attribute application validation tests', () => {
+    it('rejects before in non-post-update policies', async () => {
+        await loadSchemaWithError(
+            `
+            datasource db {
+                provider = 'sqlite'
+                url      = 'file:./dev.db'
+            }
+            
+            model Foo {
+                id Int @id @default(autoincrement())
+                x  Int
+                @@allow('all', true)
+                @@deny('update', before(x) > 2)
+            }
+            `,
+            `"before()" is only allowed in "post-update" policy rules`,
+        );
+    });
+});

packages/runtime/src/client/contract.ts

@@ -213,11 +213,21 @@ export interface ClientConstructor {
  */
 export type CRUD = 'create' | 'read' | 'update' | 'delete';
 
+/**
+ * Extended CRUD operations including 'post-update'.
+ */
+export type CRUD_EXT = CRUD | 'post-update';
+
 /**
  * CRUD operations.
  */
 export const CRUD = ['create', 'read', 'update', 'delete'] as const;
 
+/**
+ * Extended CRUD operations including 'post-update'.
+ */
+export const CRUD_EXT = [...CRUD, 'post-update'] as const;
+
 //#region Model operations
 
 export type AllModelOperations<Schema extends SchemaDef, Model extends GetModels<Schema>> = {

packages/runtime/src/client/crud/operations/base.ts

@@ -1296,8 +1296,9 @@ export abstract class BaseOperationHandler<Schema extends SchemaDef> {
             return { count: Number(result.numAffectedRows) } as Result;
         } else {
             const idFields = requireIdFields(this.schema, model);
-            const result = await query.returning(idFields as any).execute();
-            return result as Result;
+            const finalQuery = query.returning(idFields as any);
+            const result = await this.executeQuery(kysely, finalQuery, 'update');
+            return result.rows as Result;
         }
     }