update

Author: ymc9

packages/runtime/src/client/crud/operations/base.ts

@@ -942,6 +942,18 @@ export abstract class BaseOperationHandler<Schema extends SchemaDef> {
         const modelDef = this.requireModel(model);
         let finalData = data;
 
+        // fill in automatically updated fields
+        const autoUpdatedFields: string[] = [];
+        for (const [fieldName, fieldDef] of Object.entries(modelDef.fields)) {
+            if (fieldDef.updatedAt) {
+                if (finalData === data) {
+                    finalData = clone(data);
+                }
+                finalData[fieldName] = this.dialect.transformPrimitive(new Date(), 'DateTime', false);
+                autoUpdatedFields.push(fieldName);
+            }
+        }
+
         if (Object.keys(finalData).length === 0) {
             // nothing to update, return the original filter so that caller can identify the entity
             return combinedWhere;
@@ -1018,20 +1030,13 @@ export abstract class BaseOperationHandler<Schema extends SchemaDef> {
             }
         }
 
-        // fill in automatically updated fields
-        const scalarFields = Object.values(modelDef.fields)
-            .filter((f) => !f.relation)
-            .map((f) => f.name);
-        if (Object.keys(updateFields).some((f) => scalarFields.includes(f))) {
-            // if any scalar fields are being updated, also update the `updatedAt` fields
-            for (const [fieldName, fieldDef] of Object.entries(modelDef.fields)) {
-                if (fieldDef.updatedAt) {
-                    updateFields[fieldName] = this.dialect.transformPrimitive(new Date(), 'DateTime', false);
-                }
-            }
+        let hasFieldUpdate = Object.keys(updateFields).length > 0;
+        if (hasFieldUpdate) {
+            // check if only updating auto-updated fields, if so, we can skip the update
+            hasFieldUpdate = Object.keys(updateFields).some((f) => !autoUpdatedFields.includes(f));
         }
 
-        if (Object.keys(updateFields).length === 0) {
+        if (!hasFieldUpdate) {
             // nothing to update, return the filter so that the caller can identify the entity
             return combinedWhere;
         } else {

tests/e2e/orm/client-api/update.test.ts

@@ -38,7 +38,8 @@ describe('Client update tests', () => {
                 email: user.email,
                 name: user.name,
             });
-            expect(updated.updatedAt.getTime()).toBeGreaterThan(user.updatedAt.getTime());
+            // should not update updatedAt
+            expect(updated.updatedAt.getTime()).toEqual(user.updatedAt.getTime());
 
             // id as filter
             updated = await client.user.update({

tests/e2e/orm/policy/migrated/omit.test.ts

@@ -10,7 +10,7 @@ describe('prisma omit', () => {
               name String
               profile Profile?
               age Int
-              value Int @allow('read', age > 20)
+              value Int
               @@allow('all', age > 18)
             }