fix: make helpers package browser-compatible, fix update args validation (#90)

ymc9 · web-flow · commit 52d95761bf9c · 2025-07-11T23:24:48.000+08:00
* fix: make helpers package browser-compatible, fix update args validation

* update
diff --git a/TODO.md b/TODO.md
@@ -44,6 +44,7 @@
         - [x] Nested to-one
         - [x] Incremental update for numeric fields
         - [x] Array update
+        - [ ] Strict typing for checked/unchecked input
     - [x] Upsert
         - [ ] Implement with "on conflict"
     - [x] Delete
diff --git a/packages/cli/src/actions/action-utils.ts b/packages/cli/src/actions/action-utils.ts
@@ -1,4 +1,3 @@
-import { findUp } from '@zenstackhq/common-helpers';
 import { loadDocument } from '@zenstackhq/language';
 import { PrismaSchemaGenerator } from '@zenstackhq/sdk';
 import colors from 'colors';
@@ -86,3 +85,28 @@ export function getPkgJsonConfig(startPath: string) {
 
     return result;
 }
+
+type FindUpResult<Multiple extends boolean> = Multiple extends true ? string[] | undefined : string | undefined;
+
+function findUp<Multiple extends boolean = false>(
+    names: string[],
+    cwd: string = process.cwd(),
+    multiple: Multiple = false as Multiple,
+    result: string[] = [],
+): FindUpResult<Multiple> {
+    if (!names.some((name) => !!name)) {
+        return undefined;
+    }
+    const target = names.find((name) => fs.existsSync(path.join(cwd, name)));
+    if (multiple === false && target) {
+        return path.join(cwd, target) as FindUpResult<Multiple>;
+    }
+    if (target) {
+        result.push(path.join(cwd, target));
+    }
+    const up = path.resolve(cwd, '..');
+    if (up === cwd) {
+        return (multiple && result.length > 0 ? result : undefined) as FindUpResult<Multiple>;
+    }
+    return findUp(names, up, multiple, result);
+}
diff --git a/packages/cli/src/actions/generate.ts b/packages/cli/src/actions/generate.ts
@@ -24,7 +24,7 @@ export async function run(options: Options) {
 
     // generate TS schema
     const tsSchemaFile = path.join(outputPath, 'schema.ts');
-    await new TsSchemaGenerator().generate(schemaFile, [], tsSchemaFile);
+    await new TsSchemaGenerator().generate(schemaFile, [], outputPath);
 
     await runPlugins(model, outputPath, tsSchemaFile);
 
diff --git a/packages/common-helpers/src/find-up.ts b/packages/common-helpers/src/find-up.ts
diff --git a/packages/common-helpers/src/index.ts b/packages/common-helpers/src/index.ts
@@ -1,4 +1,3 @@
-export * from './find-up';
 export * from './is-plain-object';
 export * from './lower-case-first';
 export * from './param-case';
diff --git a/packages/runtime/src/client/crud/operations/find.ts b/packages/runtime/src/client/crud/operations/find.ts
@@ -5,12 +5,12 @@ import { BaseOperationHandler, type CrudOperation } from './base';
 export class FindOperationHandler<Schema extends SchemaDef> extends BaseOperationHandler<Schema> {
     async handle(operation: CrudOperation, args: unknown, validateArgs = true): Promise<unknown> {
         // normalize args to strip `undefined` fields
-        const normalizeArgs = this.normalizeArgs(args);
+        const normalizedArgs = this.normalizeArgs(args);
 
         // parse args
         const parsedArgs = validateArgs
-            ? this.inputValidator.validateFindArgs(this.model, operation === 'findUnique', normalizeArgs)
-            : normalizeArgs;
+            ? this.inputValidator.validateFindArgs(this.model, operation === 'findUnique', normalizedArgs)
+            : normalizedArgs;
 
         // run query
         const result = await this.read(
diff --git a/packages/runtime/src/client/crud/validator.ts b/packages/runtime/src/client/crud/validator.ts
@@ -924,8 +924,8 @@ export class InputValidator<Schema extends SchemaDef> {
     }
 
     private makeUpdateDataSchema(model: string, withoutFields: string[] = [], withoutRelationFields = false) {
-        const regularAndFkFields: any = {};
-        const regularAndRelationFields: any = {};
+        const uncheckedVariantFields: Record<string, ZodType> = {};
+        const checkedVariantFields: Record<string, ZodType> = {};
         const modelDef = requireModel(this.schema, model);
         const hasRelation = Object.entries(modelDef.fields).some(
             ([key, value]) => value.relation && !withoutFields.includes(key),
@@ -957,7 +957,11 @@ export class InputValidator<Schema extends SchemaDef> {
                 if (fieldDef.optional && !fieldDef.array) {
                     fieldSchema = fieldSchema.nullable();
                 }
-                regularAndRelationFields[field] = fieldSchema;
+                checkedVariantFields[field] = fieldSchema;
+                if (fieldDef.array || !fieldDef.relation.references) {
+                    // non-owned relation
+                    uncheckedVariantFields[field] = fieldSchema;
+                }
             } else {
                 let fieldSchema: ZodType = this.makePrimitiveSchema(fieldDef.type).optional();
 
@@ -1000,17 +1004,18 @@ export class InputValidator<Schema extends SchemaDef> {
                     fieldSchema = fieldSchema.nullable();
                 }
 
-                regularAndFkFields[field] = fieldSchema;
+                uncheckedVariantFields[field] = fieldSchema;
                 if (!fieldDef.foreignKeyFor) {
-                    regularAndRelationFields[field] = fieldSchema;
+                    // non-fk field
+                    checkedVariantFields[field] = fieldSchema;
                 }
             }
         });
 
         if (!hasRelation) {
-            return z.object(regularAndFkFields).strict();
+            return z.object(uncheckedVariantFields).strict();
         } else {
-            return z.union([z.object(regularAndFkFields).strict(), z.object(regularAndRelationFields).strict()]);
+            return z.union([z.object(uncheckedVariantFields).strict(), z.object(checkedVariantFields).strict()]);
         }
     }
 
diff --git a/packages/runtime/test/client-api/update.test.ts b/packages/runtime/test/client-api/update.test.ts
@@ -170,6 +170,50 @@ describe.each(createClientSpecs(PG_DB_NAME))('Client update tests', ({ createCli
                 }),
             ).resolves.toMatchObject({ age: null });
         });
+
+        it('compiles with Prisma checked/unchecked typing', async () => {
+            const user = await client.user.create({
+                data: {
+                    email: 'u1@test.com',
+                    posts: {
+                        create: {
+                            id: '1',
+                            title: 'title',
+                        },
+                    },
+                },
+            });
+
+            // fk and owned-relation are mutually exclusive
+            // TODO: @ts-expect-error
+            client.post.update({
+                where: { id: '1' },
+                data: {
+                    authorId: user.id,
+                    title: 'title',
+                    author: { connect: { id: user.id } },
+                },
+            });
+
+            // fk can work with non-owned relation
+            const comment = await client.comment.create({
+                data: {
+                    content: 'comment',
+                },
+            });
+            await expect(
+                client.post.update({
+                    where: { id: '1' },
+                    data: {
+                        authorId: user.id,
+                        title: 'title',
+                        comments: {
+                            connect: { id: comment.id },
+                        },
+                    },
+                }),
+            ).toResolveTruthy();
+        });
     });
 
     describe('nested to-many', () => {
diff --git a/packages/runtime/test/typing/generate.ts b/packages/runtime/test/typing/generate.ts
@@ -8,7 +8,7 @@ async function main() {
     const dir = path.dirname(fileURLToPath(import.meta.url));
     const zmodelPath = path.join(dir, 'typing-test.zmodel');
     const tsPath = path.join(dir, 'schema.ts');
-    await generator.generate(zmodelPath, [], tsPath);
+    await generator.generate(zmodelPath, [], dir);
 
     const content = fs.readFileSync(tsPath, 'utf-8');
     fs.writeFileSync(tsPath, content.replace(/@zenstackhq\/runtime/g, '../../dist'));
diff --git a/packages/runtime/test/typing/models.ts b/packages/runtime/test/typing/models.ts
@@ -0,0 +1,16 @@
+//////////////////////////////////////////////////////////////////////////////////////////////
+// DO NOT MODIFY THIS FILE                                                                  //
+// This file is automatically generated by ZenStack CLI and should not be manually updated. //
+//////////////////////////////////////////////////////////////////////////////////////////////
+
+/* eslint-disable */
+
+import { type ModelResult } from "@zenstackhq/runtime";
+import { schema } from "./schema";
+export type Schema = typeof schema;
+export type User = ModelResult<Schema, "User">;
+export type Post = ModelResult<Schema, "Post">;
+export type Profile = ModelResult<Schema, "Profile">;
+export type Tag = ModelResult<Schema, "Tag">;
+export type Region = ModelResult<Schema, "Region">;
+export type Meta = ModelResult<Schema, "Meta">;
diff --git a/packages/runtime/tsconfig.test.json b/packages/runtime/tsconfig.test.json
@@ -2,7 +2,8 @@
     "extends": "@zenstackhq/typescript-config/base.json",
     "compilerOptions": {
         "noEmit": true,
-        "noImplicitAny": false
+        "noImplicitAny": false,
+        "rootDir": "."
     },
     "include": ["test/**/*.ts"]
 }
diff --git a/packages/sdk/src/ts-schema-generator.ts b/packages/sdk/src/ts-schema-generator.ts
@@ -42,27 +42,29 @@ import { ModelUtils } from '.';
 import { getAttribute, getAuthDecl, hasAttribute, isIdField, isUniqueField } from './model-utils';
 
 export class TsSchemaGenerator {
-    public async generate(schemaFile: string, pluginModelFiles: string[], outputFile: string) {
+    public async generate(schemaFile: string, pluginModelFiles: string[], outputDir: string) {
         const loaded = await loadDocument(schemaFile, pluginModelFiles);
         if (!loaded.success) {
             throw new Error(`Error loading schema:${loaded.errors.join('\n')}`);
         }
 
-        const { model, warnings } = loaded;
-        const statements: ts.Statement[] = [];
+        const { model } = loaded;
 
-        this.generateSchemaStatements(model, statements);
+        fs.mkdirSync(outputDir, { recursive: true });
 
+        this.generateSchema(model, outputDir);
+        this.generateModels(model, outputDir);
+    }
+    private generateSchema(model: Model, outputDir: string) {
+        const statements: ts.Statement[] = [];
+        this.generateSchemaStatements(model, statements);
         this.generateBannerComments(statements);
 
-        const sourceFile = ts.createSourceFile(outputFile, '', ts.ScriptTarget.ESNext, false, ts.ScriptKind.TS);
+        const schemaOutputFile = path.join(outputDir, 'schema.ts');
+        const sourceFile = ts.createSourceFile(schemaOutputFile, '', ts.ScriptTarget.ESNext, false, ts.ScriptKind.TS);
         const printer = ts.createPrinter();
         const result = printer.printList(ts.ListFormat.MultiLine, ts.factory.createNodeArray(statements), sourceFile);
-
-        fs.mkdirSync(path.dirname(outputFile), { recursive: true });
-        fs.writeFileSync(outputFile, result);
-
-        return { model, warnings };
+        fs.writeFileSync(schemaOutputFile, result);
     }
 
     private generateSchemaStatements(model: Model, statements: ts.Statement[]) {
@@ -954,4 +956,103 @@ export class TsSchemaGenerator {
                 throw new Error(`Unsupported literal type: ${type}`);
             });
     }
+
+    private generateModels(model: Model, outputDir: string) {
+        const statements: ts.Statement[] = [];
+
+        // generate: import type { ModelResult } from '@zenstackhq/runtime';
+        statements.push(
+            ts.factory.createImportDeclaration(
+                undefined,
+                ts.factory.createImportClause(
+                    false,
+                    undefined,
+                    ts.factory.createNamedImports([
+                        ts.factory.createImportSpecifier(true, undefined, ts.factory.createIdentifier('ModelResult')),
+                    ]),
+                ),
+                ts.factory.createStringLiteral('@zenstackhq/runtime'),
+            ),
+        );
+
+        // generate: import { schema } from './schema';
+        statements.push(
+            ts.factory.createImportDeclaration(
+                undefined,
+                ts.factory.createImportClause(
+                    false,
+                    undefined,
+                    ts.factory.createNamedImports([
+                        ts.factory.createImportSpecifier(false, undefined, ts.factory.createIdentifier('schema')),
+                    ]),
+                ),
+                ts.factory.createStringLiteral('./schema'),
+            ),
+        );
+
+        // generate: type Schema = typeof schema;
+        statements.push(
+            ts.factory.createTypeAliasDeclaration(
+                [ts.factory.createModifier(ts.SyntaxKind.ExportKeyword)],
+                'Schema',
+                undefined,
+                ts.factory.createTypeReferenceNode('typeof schema'),
+            ),
+        );
+
+        const dataModels = model.declarations.filter(isDataModel);
+        for (const dm of dataModels) {
+            // generate: export type Model = ModelResult<Schema, 'Model'>;
+            let modelType = ts.factory.createTypeAliasDeclaration(
+                [ts.factory.createModifier(ts.SyntaxKind.ExportKeyword)],
+                dm.name,
+                undefined,
+                ts.factory.createTypeReferenceNode('ModelResult', [
+                    ts.factory.createTypeReferenceNode('Schema'),
+                    ts.factory.createLiteralTypeNode(ts.factory.createStringLiteral(dm.name)),
+                ]),
+            );
+            if (dm.comments.length > 0) {
+                modelType = this.generateDocs(modelType, dm);
+            }
+            statements.push(modelType);
+        }
+
+        // generate enums
+        const enums = model.declarations.filter(isEnum);
+        for (const e of enums) {
+            // generate:
+            // export const enum Enum = {
+            //   value1 = 'value1',
+            //   value2 = 'value2',
+            // }
+            let enumDecl = ts.factory.createEnumDeclaration(
+                [ts.factory.createModifier(ts.SyntaxKind.ExportKeyword)],
+                e.name,
+                e.fields.map((f) => ts.factory.createEnumMember(f.name, ts.factory.createStringLiteral(f.name))),
+            );
+            if (e.comments.length > 0) {
+                enumDecl = this.generateDocs(enumDecl, e);
+            }
+            statements.push(enumDecl);
+        }
+
+        this.generateBannerComments(statements);
+
+        // write to file
+        const outputFile = path.join(outputDir, 'models.ts');
+        const sourceFile = ts.createSourceFile(outputFile, '', ts.ScriptTarget.ESNext, false, ts.ScriptKind.TS);
+        const printer = ts.createPrinter();
+        const result = printer.printList(ts.ListFormat.MultiLine, ts.factory.createNodeArray(statements), sourceFile);
+        fs.writeFileSync(outputFile, result);
+    }
+
+    private generateDocs<T extends ts.TypeAliasDeclaration | ts.EnumDeclaration>(tsDecl: T, decl: DataModel | Enum): T {
+        return ts.addSyntheticLeadingComment(
+            tsDecl,
+            ts.SyntaxKind.MultiLineCommentTrivia,
+            `*\n * ${decl.comments.map((c) => c.replace(/^\s*\/*\s*/, '')).join('\n * ')}\n `,
+            true,
+        );
+    }
 }
diff --git a/packages/testtools/src/schema.ts b/packages/testtools/src/schema.ts
@@ -44,8 +44,7 @@ export async function generateTsSchema(
     const pluginModelFiles = glob.sync(path.resolve(__dirname, '../../runtime/src/plugins/**/plugin.zmodel'));
 
     const generator = new TsSchemaGenerator();
-    const tsPath = path.join(workDir, 'schema.ts');
-    await generator.generate(zmodelPath, pluginModelFiles, tsPath);
+    await generator.generate(zmodelPath, pluginModelFiles, workDir);
 
     if (extraSourceFiles) {
         for (const [fileName, content] of Object.entries(extraSourceFiles)) {
diff --git a/samples/blog/zenstack/models.ts b/samples/blog/zenstack/models.ts
diff --git a/samples/blog/zenstack/schema.zmodel b/samples/blog/zenstack/schema.zmodel

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-export * from './find-up';`
`2`	`1`	`export * from './is-plain-object';`
`3`	`2`	`export * from './lower-case-first';`
`4`	`3`	`export * from './param-case';`