feat(server): migrate rpc api handler and express adapter (#328)

* feat(server): migrate rpc api handler and express adapter

* fix package.json

* misc fixes

* update

* update ot express5 only

* update

* update

* fix test

Author: ymc9

BREAKINGCHANGES.md

@@ -1,3 +1,3 @@
-1. `auth()` cannot be directly compared with a relation anymore
-2. `update` and `delete` policy rejection throws `NotFoundError`
-3. non-optional to-one relation doesn't automatically filter parent read when evaluating access policies
+1. `update` and `delete` policy rejection throws `NotFoundError`
+1. `check()` ORM api has been removed
+1. non-optional to-one relation doesn't automatically filter parent read when evaluating access policies

TODO.md

@@ -86,7 +86,7 @@
         - [ ] DbNull vs JsonNull
         - [ ] Migrate to tsdown
         - [x] @default validation
-    - [ ] Benchmark
+    - [x] Benchmark
 - [x] Plugin
     - [x] Post-mutation hooks should be called after transaction is committed
 - [x] TypeDef and mixin

packages/common-helpers/src/index.ts

@@ -1,6 +1,7 @@
 export * from './is-plain-object';
 export * from './lower-case-first';
 export * from './param-case';
+export * from './safe-json-stringify';
 export * from './sleep';
 export * from './tiny-invariant';
 export * from './upper-case-first';

packages/common-helpers/src/safe-json-stringify.ts

@@ -0,0 +1,12 @@
+/**
+ * A safe JSON stringify that handles bigint values.
+ */
+export function safeJSONStringify(value: unknown) {
+    return JSON.stringify(value, (_, v) => {
+        if (typeof v === 'bigint') {
+            return v.toString();
+        } else {
+            return v;
+        }
+    });
+}

packages/language/package.json

@@ -13,6 +13,7 @@
         "build": "pnpm langium:generate && tsc --noEmit && tsup-node",
         "watch": "tsup-node --watch",
         "lint": "eslint src --ext ts",
+        "test": "vitest run",
         "langium:generate": "langium generate",
         "langium:generate:production": "langium generate --mode=production",
         "pack": "pnpm pack"

packages/language/src/constants.ts

@@ -1,5 +1,5 @@
 /**
- * Supported Prisma db providers
+ * Supported db providers
  */
 export const SUPPORTED_PROVIDERS = [
     'sqlite',

packages/plugins/policy/src/policy-handler.ts

@@ -104,7 +104,7 @@ export class PolicyHandler<Schema extends SchemaDef> extends OperationNodeTransf
                 if (constCondition === true) {
                     needCheckPreCreate = false;
                 } else if (constCondition === false) {
-                    throw new RejectedByPolicyError(mutationModel);
+                    throw new RejectedByPolicyError(mutationModel, RejectedByPolicyReason.NO_ACCESS);
                 }
             }
 
@@ -621,7 +621,7 @@ export class PolicyHandler<Schema extends SchemaDef> extends OperationNodeTransf
 
         const result = await proceed(preCreateCheck);
         if (!result.rows[0]?.$condition) {
-            throw new RejectedByPolicyError(model);
+            throw new RejectedByPolicyError(model, RejectedByPolicyReason.NO_ACCESS);
         }
     }
 

packages/runtime/package.json

@@ -64,7 +64,7 @@
     "dependencies": {
         "@paralleldrive/cuid2": "^2.2.2",
         "@zenstackhq/common-helpers": "workspace:*",
-        "decimal.js": "^10.4.3",
+        "decimal.js": "catalog:",
         "json-stable-stringify": "^1.3.0",
         "nanoid": "^5.0.9",
         "toposort": "^2.0.2",

packages/runtime/src/client/crud/dialects/postgresql.ts

@@ -111,7 +111,12 @@ export class PostgresCrudDialect<Schema extends SchemaDef> extends BaseCrudDiale
     }
 
     private transformOutputBytes(value: unknown) {
-        return Buffer.isBuffer(value) ? Uint8Array.from(value) : value;
+        return Buffer.isBuffer(value)
+            ? Uint8Array.from(value)
+            : // node-pg encode bytea as hex string prefixed with \x when embedded in JSON
+              typeof value === 'string' && value.startsWith('\\x')
+              ? Uint8Array.from(Buffer.from(value.slice(2), 'hex'))
+              : value;
     }
 
     override buildRelationSelection(

packages/runtime/src/client/crud/validator/index.ts

@@ -232,6 +232,7 @@ export class InputValidator<Schema extends SchemaDef> {
         const { error, data } = schema.safeParse(args);
         if (error) {
             throw new InputValidationError(
+                model,
                 `Invalid ${operation} args for model "${model}": ${formatError(error)}`,
                 error,
             );