addressing PR comments

Author: ymc9

packages/runtime/src/client/contract.ts

@@ -213,6 +213,11 @@ export interface ClientConstructor {
  */
 export type CRUD = 'create' | 'read' | 'update' | 'delete';
 
+/**
+ * CRUD operations.
+ */
+export const CRUD = ['create', 'read', 'update', 'delete'] as const;
+
 //#region Model operations
 
 export type AllModelOperations<Schema extends SchemaDef, Model extends GetModels<Schema>> = {

packages/runtime/src/plugins/policy/functions.ts

@@ -1,10 +1,10 @@
+import { invariant } from '@zenstackhq/common-helpers';
 import { ExpressionWrapper, ValueNode, type Expression, type ExpressionBuilder } from 'kysely';
+import { CRUD } from '../../client/contract';
+import { extractFieldName } from '../../client/kysely-utils';
 import type { ZModelFunction, ZModelFunctionContext } from '../../client/options';
-import { invariant } from '@zenstackhq/common-helpers';
 import { buildJoinPairs, requireField } from '../../client/query-utils';
 import { PolicyHandler } from './policy-handler';
-import type { CRUD } from '../../client/contract';
-import { extractFieldName } from '../../client/kysely-utils';
 
 /**
  * Relation checker implementation.
@@ -25,7 +25,7 @@ export const check: ZModelFunction<any> = (
             '"operation" parameter must be a string literal when provided',
         );
         invariant(
-            ['create', 'read', 'update', 'delete'].includes(arg2Node.value),
+            CRUD.includes(arg2Node.value as CRUD),
             '"operation" parameter must be one of "create", "read", "update", "delete"',
         );
     }

samples/blog/main.ts

@@ -8,10 +8,10 @@ async function main() {
         dialect: new SqliteDialect({ database: new SQLite('./zenstack/dev.db') }),
         computedFields: {
             User: {
-                postCount: (eb, { currentModel }) =>
+                postCount: (eb, { modelAlias }) =>
                     eb
                         .selectFrom('Post')
-                        .whereRef('Post.authorId', '=', sql.ref(`${currentModel}.id`))
+                        .whereRef('Post.authorId', '=', sql.ref(`${modelAlias}.id`))
                         .select(({ fn }) => fn.countAll<number>().as('postCount')),
             },
         },