Skip to content

Commit ddd5b4d

Browse files
authored
fix: result type of delete API (#168)
* fix: result type of `delete` API * fix test * update test
1 parent ad704f4 commit ddd5b4d

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

packages/runtime/src/client/contract.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -664,7 +664,7 @@ export type AllModelOperations<Schema extends SchemaDef, Model extends GetModels
664664
*/
665665
delete<T extends DeleteArgs<Schema, Model>>(
666666
args: SelectSubset<T, DeleteArgs<Schema, Model>>,
667-
): ZenStackPromise<Schema, Simplify<ModelResult<Schema, Model>>>;
667+
): ZenStackPromise<Schema, Simplify<ModelResult<Schema, Model, T>>>;
668668

669669
/**
670670
* Deletes multiple entities.

packages/runtime/test/plugin/entity-mutation-hooks.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ describe('Entity mutation hooks tests', () => {
235235
name: 'A user',
236236
}),
237237
expect.objectContaining({
238-
email: 'u1@test.com',
238+
email: 'u2@test.com',
239239
name: 'A user',
240240
}),
241241
]),

packages/runtime/test/plugin/on-query-hooks.test.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import SQLite from 'better-sqlite3';
22
import { SqliteDialect } from 'kysely';
3-
import { beforeEach, describe, expect, it } from 'vitest';
3+
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
44
import { definePlugin, ZenStackClient, type ClientContract } from '../../src/client';
55
import { schema } from '../schemas/basic';
66

@@ -14,6 +14,10 @@ describe('On query hooks tests', () => {
1414
await _client.$pushSchema();
1515
});
1616

17+
afterEach(async () => {
18+
await _client?.$disconnect();
19+
});
20+
1721
it('supports simple interception', async () => {
1822
const user = await _client.user.create({
1923
data: { email: '[email protected]' },

0 commit comments

Comments
 (0)