Skip to content

Commit fc7e96f

Browse files
committed
update
1 parent d28d1df commit fc7e96f

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

packages/runtime/src/client/crud/dialects/base.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1150,7 +1150,7 @@ export abstract class BaseCrudDialect<Schema extends SchemaDef> {
11501150
}
11511151

11521152
if (modelDef.baseModel || modelDef.isDelegate) {
1153-
// delete models require upward/downward joins
1153+
// delegate models require upward/downward joins
11541154
return false;
11551155
}
11561156

packages/runtime/src/client/crud/dialects/postgresql.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,6 @@ export class PostgresCrudDialect<Schema extends SchemaDef> extends BaseCrudDiale
221221
string | ExpressionWrapper<any, any, any> | SelectQueryBuilder<any, any, any> | RawBuilder<any>
222222
> = [];
223223

224-
// TODO: descendant JSON shouldn't be joined and selected if none of its fields are selected
225224
const descendantModels = getDelegateDescendantModels(this.schema, relationModel);
226225
if (descendantModels.length > 0) {
227226
// select all JSONs built from delegate descendants

packages/runtime/src/client/crud/dialects/sqlite.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ export class SqliteCrudDialect<Schema extends SchemaDef> extends BaseCrudDialect
107107
type ArgsType = Expression<any> | RawBuilder<any> | SelectQueryBuilder<any, any, any>;
108108
const objArgs: ArgsType[] = [];
109109

110-
// TODO: descendant JSON shouldn't be joined and selected if none of its fields are selected
111110
const descendantModels = getDelegateDescendantModels(this.schema, relationModel);
112111
if (descendantModels.length > 0) {
113112
// select all JSONs built from delegate descendants

0 commit comments

Comments
 (0)