Skip to content

feat: db pull implementation #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 24 commits into
base: dev
Choose a base branch
from
Draft

feat: db pull implementation #268

wants to merge 24 commits into from
+3,138 −89

Conversation

@svetch
Copy link
Contributor

@svetch svetch commented Sep 23, 2025 •
edited
Loading

Summary

This PR introduces db pull support to zenstack_v3, similar to Prisma’s db pull.
The command enables introspection of the database schema and generates corresponding models within the project.

Current Status

  • Initial implementation of db pull command
  • Relation resolving logic
  • Implement diff update on db pull
    • Multi-schema file update(handle schema imports and update model in their schema file)
    • Add/Remove fields on update
    • Add/Remove Models
    • Update field
    • Update model attributes
  • Make all generation option configurable from cli
    • Option to always add @map for fields/models
    • Name casing strategy
    • quote, indent
  • improve logging
  • Handle the database type mapping per database provider(@db.\<Raw databse type\>, ie: @db.Real)
  • Need to determine the best approach for testing

Notes

  • I appreciate any feedback, suggestions, or requests for changes 🙏

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

sanny-io
sanny-io reviewed Oct 20, 2025
View reviewed changes
@svetch svetch force-pushed the main branch 2 times, most recently from 85bbb6e to 08006cf Compare October 22, 2025 20:13
@ymc9
Copy link
Member

ymc9 commented Oct 24, 2025

Just a heads up, I'm renaming "@zenstackhq/runtime" package to "@zenstackhq/orm".

svetch added 19 commits November 21, 2025 01:13
@svetch
feat: initial db pull implementation
e37359d
@svetch
fix: generate imports and attributes for zmodel-code-generator
fe31243
@svetch
fix: add option to not exclude imports in loadDocument
cdf4d38
@svetch
fix: continue work on db pull
d04fb3d
@svetch
fix: missing import
5b5e0be
@svetch
fix: rewrite model generation
45b9afa 
generate model  from ground up and diff later
@svetch
feat: add ast factory
defcaab
@svetch
fix: ast factory import order
d146335
@svetch
fix: some runtime bugs
1fee4fc
@svetch
fix: lint fix
76fecae
@svetch
fix: update zmodel code generator
a7af852 
- include imports in output
- fix indentaions
- include comments in output
@svetch
feat: add exclude schemas option
c81fe44
@svetch
feat: implement initial diff update
d52f862
@svetch
fix: update format in zmodel code generator
61991d3
@svetch
fix: typo
55ea05f
@svetch
feat: progress on database introspection and syncing
b6db32f
@svetch
fix: make ignore behave it does in prisma with no index models
7ea747c
@svetch
fix: lint fix
fb1dd26
@svetch
feat: make all format options configurable
af3043d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

1 more reviewer

@sanny-io sanny-io sanny-io left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@svetch @ymc9 @sanny-io