update

ymc9 · ymc9 · commit 93e61501389e · 2024-10-20T15:50:06.000-07:00
diff --git a/packages/schema/src/language-server/validator/datamodel-validator.ts b/packages/schema/src/language-server/validator/datamodel-validator.ts
@@ -197,13 +197,8 @@ export default class DataModelValidator implements AstValidator<DataModel> {
         return { attr: relAttr, name, fields, references, valid };
     }
 
-    private isSelfRelation(field: DataModelField, _relationName?: string) {
-        if (field.type.reference?.ref === field.$container) {
-            // field directly references back to its type
-            return true;
-        }
-
-        return false;
+    private isSelfRelation(field: DataModelField) {
+        return field.type.reference?.ref === field.$container;
     }
 
     private validateRelationField(contextModel: DataModel, field: DataModelField, accept: ValidationAcceptor) {

Original file line number	Diff line number	Diff line change
`@@ -197,13 +197,8 @@ export default class DataModelValidator implements AstValidator<DataModel> {`
`197`	`197`	`return { attr: relAttr, name, fields, references, valid };`
`198`	`198`	`}`
`199`	`199`
`200`		`- private isSelfRelation(field: DataModelField, _relationName?: string) {`
`201`		`- if (field.type.reference?.ref === field.$container) {`
`202`		`- // field directly references back to its type`
`203`		`- return true;`
`204`		`- }`
`205`		`-`
`206`		`- return false;`
	`200`	`+ private isSelfRelation(field: DataModelField) {`
	`201`	`+ return field.type.reference?.ref === field.$container;`
`207`	`202`	`}`
`208`	`203`
`209`	`204`	`private validateRelationField(contextModel: DataModel, field: DataModelField, accept: ValidationAcceptor) {`