feat(symfony): prevent using temporary/expiring routes if not supported

Author: kbond

src/Filesystem/Symfony/DependencyInjection/ZenstruckFilesystemExtension.php

@@ -27,6 +27,7 @@
 use Symfony\Component\DependencyInjection\ServiceLocator;
 use Symfony\Component\HttpFoundation\UriSigner;
 use Symfony\Component\HttpKernel\DependencyInjection\ConfigurableExtension;
+use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\String\Slugger\SluggerInterface;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
@@ -359,6 +360,10 @@ private function registerFilesystem(string $name, array $config, ContainerBuilde
                 break;
 
             case isset($config['temporary_url']['route']):
+                if (Kernel::VERSION_ID < 70100) { // @phpstan-ignore smaller.alwaysFalse
+                    throw new LogicException('"temporary_url" requires Symfony 7.1 or higher.');
+                }
+
                 $container->register($id = '.zenstruck_filesystem.filesystem_temporary_url.'.$name, RouteTemporaryUrlGenerator::class)
                     ->setArguments([
                         new Reference('.zenstruck_filesystem.route_url_generator.locator'),

src/Filesystem/Symfony/Routing/RouteUrlGenerator.php

@@ -13,6 +13,7 @@
 
 use Psr\Container\ContainerInterface;
 use Symfony\Component\HttpFoundation\UriSigner;
+use Symfony\Component\HttpKernel\Kernel;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 
 /**
@@ -63,6 +64,10 @@ final protected function generate(string $path, array $routeParameters, string|\
             $expires = new \DateTimeImmutable($expires);
         }
 
+        if ($expires && Kernel::VERSION_ID < 70100) { // @phpstan-ignore smaller.alwaysFalse, booleanAnd.alwaysFalse
+            throw new \LogicException('Expiring URLs requires Symfony 7.1 or higher.');
+        }
+
         return $this->container->get(UriSigner::class)->sign($url, $expires);
     }
 }

tests/Filesystem/Symfony/ZenstruckFilesystemBundleTest.php

@@ -12,6 +12,7 @@
 namespace Zenstruck\Tests\Filesystem\Symfony;
 
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Symfony\Component\HttpKernel\Kernel;
 use Zenstruck\Filesystem\Node\Path\Expression;
 use Zenstruck\Filesystem\Test\InteractsWithFilesystem;
 use Zenstruck\Filesystem\Test\ResetFilesystem;
@@ -101,15 +102,29 @@ public function can_generate_urls(): void
         $privateFile = $this->filesystem()->write('private://bar/file.png', 'content')->ensureImage();
 
         $this->assertStringContainsString('http://localhost/private/bar/file.png', $privateFile->publicUrl());
-        $this->assertStringContainsString('http://localhost/private/bar/file.png', $privateFile->publicUrl(['expires' => 'tomorrow']));
         $this->assertSame('/glide/bar/file.png?w=100&h=200', $privateFile->transformUrl(['w' => 100, 'h' => 200]));
     }
 
     /**
      * @test
      */
-    public function can_generate_signed_and_temporary_urls(): void
+    public function can_generate_signed_urls(): void
     {
+        $privateFile = $this->filesystem()->write('private://bar/file.png', 'content')->ensureImage();
+
+        $this->assertStringContainsString('_hash=', $privateFile->publicUrl());
+        $this->assertStringNotContainsString('_expiration=', $privateFile->publicUrl());
+    }
+
+    /**
+     * @test
+     */
+    public function can_generate_temporary_urls(): void
+    {
+        if (Kernel::VERSION_ID < 70100) {
+            $this->markTestSkipped('Temporary URLs are not supported in Symfony < 7.1.');
+        }
+
         $publicFile = $this->filesystem()->write('public://foo/file.png', 'content')->ensureImage();
 
         $this->assertStringContainsString('/temp/foo/file.png', $publicFile->temporaryUrl('tomorrow'));
@@ -118,15 +133,26 @@ public function can_generate_signed_and_temporary_urls(): void
 
         $privateFile = $this->filesystem()->write('private://bar/file.png', 'content')->ensureImage();
 
-        $this->assertStringContainsString('_hash=', $privateFile->publicUrl());
-        $this->assertStringNotContainsString('_expiration=', $privateFile->publicUrl());
-        $this->assertStringContainsString('_hash=', $privateFile->publicUrl(['expires' => 'tomorrow']));
-        $this->assertStringContainsString('_expiration=', $privateFile->publicUrl(['expires' => 'tomorrow']));
         $this->assertStringContainsString('/private/bar/file.png', $privateFile->temporaryUrl('tomorrow'));
         $this->assertStringContainsString('_hash=', $privateFile->temporaryUrl('tomorrow'));
         $this->assertStringContainsString('_expiration=', $privateFile->temporaryUrl('tomorrow'));
     }
 
+    /**
+     * @test
+     */
+    public function can_generate_expiring_public_urls(): void
+    {
+        if (Kernel::VERSION_ID < 70100) {
+            $this->markTestSkipped('Expiring URLs are not supported in Symfony < 7.1.');
+        }
+
+        $privateFile = $this->filesystem()->write('private://bar/file.png', 'content')->ensureImage();
+
+        $this->assertStringContainsString('_hash=', $privateFile->publicUrl(['expires' => 'tomorrow']));
+        $this->assertStringContainsString('_expiration=', $privateFile->publicUrl(['expires' => 'tomorrow']));
+    }
+
     /**
      * @test
      */

tests/Fixtures/TestKernel.php

@@ -122,7 +122,7 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load
                         'prefix' => '/prefix',
                         'version' => 'size',
                     ],
-                    'temporary_url' => 'route:public_temp',
+                    'temporary_url' => self::VERSION_ID < 70100 ? null : 'route:public_temp',
                     'image_url' => 'route:public_transform',
                     'reset_before_tests' => true,
                     'events' => true,