chore: test Symfony 8

Author: nikophil

bin/tools/phpstan/composer.json

@@ -5,7 +5,8 @@
         "phpstan/phpstan-symfony": "^2.0",
         "phpstan/extension-installer": "^1.2",
         "phpstan/phpstan-doctrine": "^2.0",
-        "phpstan/phpstan-phpunit": "^2.0"
+        "phpstan/phpstan-phpunit": "^2.0",
+        "symfony/var-exporter": "^7"
     },
     "config": {
         "allow-plugins": {

bin/tools/phpstan/composer.lock

@@ -20,36 +20,33 @@
         "fakerphp/faker": "^1.23",
         "symfony/deprecation-contracts": "^2.2|^3.0",
         "symfony/polyfill-php84": "^1.32",
-        "symfony/property-access": "^6.4|^7.0|^8.0",
-        "symfony/property-info": "^6.4|^7.0|^8.0",
+        "symfony/property-access": "^8.0",
+        "symfony/property-info": "^8.0",
         "symfony/var-exporter": "^6.4.9|~7.0.9|^7.1.2|^8.0",
         "zenstruck/assert": "^1.4"
     },
     "require-dev": {
         "bamarni/composer-bin-plugin": "^1.8",
-        "brianium/paratest": "^6|^7",
         "dama/doctrine-test-bundle": "^8.0",
         "doctrine/collections": "^1.7|^2.0",
         "doctrine/common": "^3.2.2",
-        "doctrine/doctrine-bundle": "^2.10",
-        "doctrine/doctrine-migrations-bundle": "^2.2|^3.0",
-        "doctrine/mongodb-odm": "^2.4",
-        "doctrine/mongodb-odm-bundle": "^4.6|^5.0",
-        "doctrine/orm": "^2.16|^3.0",
+        "doctrine/doctrine-bundle": "3.1.x-dev",
+        "doctrine/mongodb-odm": "2.15.x-dev",
+        "doctrine/mongodb-odm-bundle": "5.5.x-dev",
+        "doctrine/orm": "3.5.x-dev",
         "doctrine/persistence": "^2.0|^3.0|^4.0",
         "phpunit/phpunit": "^9.5.0 || ^10.0 || ^11.0 || ^12.0",
-        "symfony/browser-kit": "^6.4|^7.0|^8.0",
-        "symfony/console": "^6.4|^7.0|^8.0",
-        "symfony/dotenv": "^6.4|^7.0|^8.0",
-        "symfony/framework-bundle": "^6.4|^7.0|^8.0",
-        "symfony/maker-bundle": "^1.55",
-        "symfony/phpunit-bridge": "^6.4|^7.0|^8.0",
-        "symfony/routing": "^6.4|^7.0|^8.0",
-        "symfony/runtime": "^6.4|^7.0|^8.0",
+        "symfony/browser-kit": "^8.0",
+        "symfony/console": "^8.0",
+        "symfony/dotenv": "^8.0",
+        "symfony/framework-bundle": "^8.0",
+        "symfony/phpunit-bridge": "^8.0",
+        "symfony/routing": "^8.0",
+        "symfony/runtime": "^8.0",
         "symfony/translation-contracts": "^3.4",
-        "symfony/uid": "^6.4|^7.0|^8.0",
-        "symfony/var-dumper": "^6.4|^7.0|^8.0",
-        "symfony/yaml": "^6.4|^7.0|^8.0",
+        "symfony/uid": "^8.0",
+        "symfony/var-dumper": "^8.0",
+        "symfony/yaml": "^8.0",
         "webmozart/assert": "^1.11"
     },
     "autoload": {
@@ -99,6 +96,6 @@
     "scripts": {
         "post-install-cmd": ["@composer bin phpstan install", "@composer bin phpbench install"]
     },
-    "minimum-stability": "dev",
+    "minimum-stability": "beta",
     "prefer-stable": true
 }

composer.json

@@ -17,6 +17,16 @@ check_phpunit_version() {
     fi
 }
 
+can_use_legacy_proxies() {
+    INSTALLED_SYMFONY_VERSION=$(${COMPOSER_BIN} info symfony/var-exporter | grep versions |  cut -c 15-)
+
+    if [[ "${INSTALLED_SYMFONY_VERSION}" == "8"* ]]; then
+      echo 0;
+    else
+      echo 1;
+    fi
+}
+
 ### >> load env vars from .env files if not in CI and not from a composer script
 if [ -z "${CI:-}" ] ; then
   source .env
@@ -74,6 +84,10 @@ case ${PHPUNIT_VERSION} in
     if [ "${USE_FOUNDRY_PHPUNIT_EXTENSION:-0}" = "1" ]; then
       PHPUNIT_EXEC="${PHPUNIT_EXEC} --extension "${FOUNDRY_EXTENSION}""
     fi
+
+    if [ "$(can_use_legacy_proxies)" = "0" ]; then
+      PHPUNIT_EXEC="${PHPUNIT_EXEC} --exclude-group legacy-proxy"
+    fi
     ;;
 esac
 

phpunit

@@ -14,6 +14,7 @@ Foundry now leverages the native PHP lazy system to auto-refresh objects (it can
 See https://github.com/zenstruck/foundry/blob/2.x/UPGRADE-2.7.md to upgrade.]]></issue>
 
             <issue><![CDATA[Support for MySQL < 8 is deprecated and will be removed in DBAL 5 (AbstractMySQLDriver.php:75 called by AbstractDriverMiddleware.php:32, https://github.com/doctrine/dbal/pull/6343, package doctrine/dbal)]]></issue>
+            <issue><![CDATA[Since doctrine/doctrine-bundle 3.1: The "auto_mapping" option is deprecated and will be removed in DoctrineBundle 4.0, as it only accepts `false` since 3.0.]]></issue>
         </line>
     </file>
     <file path="vendor/doctrine/deprecations/src/Deprecation.php">

phpunit-deprecation-baseline.xml

@@ -182,6 +182,11 @@ public static function triggerProxyDeprecation(?string $additionalMessage = null
             return;
         }
 
+        if (!trait_exists(\Symfony\Component\VarExporter\LazyProxyTrait::class)) {
+            // Deprecation is not needed: PersistentProxyObjectFactory will actually throw when create() is called.
+            return;
+        }
+
         $message = <<<DEPRECATION
             Proxy usage is deprecated in PHP 8.4. You should extend directly PersistentObjectFactory in your factories.
             Foundry now leverages the native PHP lazy system to auto-refresh objects (it can be enabled with "zenstruck_foundry.enable_auto_refresh_with_lazy_objects" configuration).

src/Configuration.php

@@ -40,6 +40,10 @@ abstract public static function class(): string;
      */
     final public function create(callable|array $attributes = []): object
     {
+        if (!trait_exists(\Symfony\Component\VarExporter\LazyProxyTrait::class)) {
+            throw new \LogicException('PersistentProxyObjectFactory can no longer be used with Symfony 8. See https://github.com/zenstruck/foundry/blob/2.x/UPGRADE-2.7.md to upgrade.');
+        }
+
         $configuration = Configuration::instance();
         if ($configuration->inADataProvider() && $this->isPersisting()) {
             return ProxyGenerator::wrapFactory($this, $attributes);

src/Persistence/PersistentProxyObjectFactory.php

@@ -35,15 +35,11 @@ class Contact extends Base
 
     /** @var Collection<int,Tag> */
     #[ORM\ManyToMany(targetEntity: Tag::class, inversedBy: 'contacts')]
-    #[ORM\JoinColumn(nullable: false)]
-    #[ORM\InverseJoinColumn(nullable: false)]
     protected Collection $tags;
 
     /** @var Collection<int,Tag> */
     #[ORM\ManyToMany(targetEntity: Tag::class, inversedBy: 'secondaryContacts')]
     #[ORM\JoinTable(name: 'category_tag_standard_secondary')]
-    #[ORM\JoinColumn(nullable: false)]
-    #[ORM\InverseJoinColumn(nullable: false)]
     protected Collection $secondaryTags;
 
     #[ORM\OneToOne(targetEntity: Address::class, inversedBy: 'contact')]