Adjust custom_url field validation rules and migrations (#1408)

Author: sebastian-zentral

tests/santa/test_serializers.py

@@ -1,10 +1,11 @@
 from django.test import TestCase
 from django.urls import reverse
 from django.utils.crypto import get_random_string
+
 from zentral.conf import settings
 from zentral.contrib.inventory.models import EnrollmentSecret, MetaBusinessUnit
 from zentral.contrib.santa.models import Configuration, Enrollment
-from zentral.contrib.santa.serializers import RuleUpdateSerializer, EnrollmentSerializer
+from zentral.contrib.santa.serializers import EnrollmentSerializer, RuleUpdateSerializer
 
 
 class SantaSerializersTestCase(TestCase):
@@ -112,6 +113,24 @@ def test_rule_custom_msg_allowlist(self):
         ed = serializer.errors["non_field_errors"][0]
         self.assertEqual(str(ed), "Custom message cannot be set for this rule policy")
 
+    def test_rule_custom_url_length(self):
+        custom_url = f"https://zentral.com/{get_random_string(240)}"
+        data = {"rule_type": "BINARY",
+                "identifier": get_random_string(64, "0123456789abcdef"),
+                "custom_url": custom_url,
+                "policy": "BLOCKLIST"}
+        serializer = RuleUpdateSerializer(data=data)
+        self.assertTrue(serializer.is_valid())
+        custom_url = f"https://zentral.com/{get_random_string(840)}"
+        data = {"rule_type": "BINARY",
+                "identifier": get_random_string(64, "0123456789abcdef"),
+                "custom_url": custom_url,
+                "policy": "BLOCKLIST"}
+        serializer = RuleUpdateSerializer(data=data)
+        self.assertFalse(serializer.is_valid())
+        ed = serializer.errors["custom_url"][0]
+        self.assertEqual(str(ed), "Ensure this field has no more than 800 characters.")
+
     def test_rule_custom_url_allowlist(self):
         data = {"rule_type": "BINARY",
                 "identifier": get_random_string(64, "0123456789abcdef"),

zentral/contrib/santa/forms.py

@@ -1,17 +1,27 @@
 import json
 import logging
 import re
+
 from dateutil import parser
 from django import forms
 from django.contrib.postgres.forms import SimpleArrayField
 from django.db import connection, transaction
 from django.db.models import Count, F
-from django.urls import reverse, NoReverseMatch
+from django.urls import NoReverseMatch, reverse
+
 from zentral.conf import settings
 from zentral.contrib.inventory.models import Tag
-from .events import post_santa_rule_update_event
-from .models import Configuration, Enrollment, Rule, RuleSet, Target, TargetState, VotingGroup
 
+from .events import post_santa_rule_update_event
+from .models import (
+    Configuration,
+    Enrollment,
+    Rule,
+    RuleSet,
+    Target,
+    TargetState,
+    VotingGroup,
+)
 
 logger = logging.getLogger("zentral.contrib.santa.forms")
 
@@ -318,7 +328,7 @@ class RuleForm(RuleFormMixin, forms.Form):
                                widget=forms.Textarea(attrs={"cols": "40", "rows": "5"}))
     custom_msg = forms.CharField(label="Custom message", required=False,
                                  widget=forms.Textarea(attrs={"cols": "40", "rows": "2"}))
-    custom_url = forms.URLField(label="Custom URL", required=False,
+    custom_url = forms.URLField(label="Custom URL", required=False, max_length=800,
                                 widget=forms.URLInput(attrs={"size": 40}),)
     description = forms.CharField(required=False, widget=forms.Textarea(attrs={"cols": "40", "rows": "2"}))
     serial_numbers = SimpleArrayField(forms.CharField(), required=False)

zentral/contrib/santa/migrations/0041_alter_rule_custom_url.py

@@ -0,0 +1,18 @@
+# Generated by Django 5.2.11 on 2026-02-25 09:31
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('santa', '0040_rule_custom_url'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='rule',
+            name='custom_url',
+            field=models.URLField(blank=True, max_length=800),
+        ),
+    ]

zentral/contrib/santa/models.py

@@ -1,20 +1,25 @@
-from collections import namedtuple
 import logging
 import uuid
-from django.core.validators import MaxValueValidator, MinLengthValidator, MinValueValidator
+from collections import namedtuple
+
 from django.contrib.postgres.fields import ArrayField
+from django.core.validators import (
+    MaxValueValidator,
+    MinLengthValidator,
+    MinValueValidator,
+)
 from django.db import connection, models
 from django.db.models import Count, Q
 from django.urls import reverse
 from django.utils.crypto import get_random_string
 from django.utils.functional import cached_property
 from django.utils.translation import gettext_lazy as _
 from realms.models import Realm, RealmGroup, RealmUser
-from zentral.core.incidents.models import Severity
+
 from zentral.contrib.inventory.models import BaseEnrollment, Certificate, File, Tag
+from zentral.core.incidents.models import Severity
 from zentral.utils.text import shard
 
-
 logger = logging.getLogger("zentral.contrib.santa.models")
 
 
@@ -987,7 +992,7 @@ def rule_choices(cls):
     policy = models.PositiveSmallIntegerField(choices=Policy.rule_choices())
     cel_expr = models.TextField(blank=True)
     custom_msg = models.TextField(blank=True)
-    custom_url = models.URLField(blank=True)
+    custom_url = models.URLField(blank=True, max_length=800)
     description = models.TextField(blank=True)
     version = models.PositiveIntegerField(default=1)
     is_voting_rule = models.BooleanField(default=False, editable=False)

zentral/contrib/santa/serializers.py

@@ -1,19 +1,20 @@
-from datetime import datetime
-from itertools import chain
 import logging
 import os.path
+from datetime import datetime
+from itertools import chain
 
 from django.db import transaction
 from django.db.models import F
 from django.urls import reverse
 from rest_framework import serializers
+
 from zentral.conf import settings
 from zentral.contrib.inventory.models import EnrollmentSecret
 from zentral.contrib.inventory.serializers import EnrollmentSecretSerializer
+
 from .events import post_santa_rule_update_event
-from .models import Configuration, Rule, Target, Enrollment
 from .forms import cleanup_target_identifier
-
+from .models import Configuration, Enrollment, Rule, Target
 
 logger = logging.getLogger("zentral.contrib.santa.serializers")
 
@@ -218,7 +219,7 @@ class RuleUpdateSerializer(serializers.Serializer):
     sha256 = serializers.RegexField(r'^[a-f0-9]{64}\Z', required=False)  # Legacy field  TODO remove eventually
     identifier = serializers.CharField(required=False)
     custom_msg = serializers.CharField(required=False)
-    custom_url = serializers.CharField(required=False)
+    custom_url = serializers.URLField(required=False, max_length=800)
     description = serializers.CharField(required=False)
     serial_numbers = serializers.ListField(
         child=serializers.CharField(min_length=1),