-
Notifications
You must be signed in to change notification settings - Fork 17
Description
We need to discuss the detailed specifications for node_id and zone_id in node.csv. Specifically, node_id should be an integer, as demonstrated in the standard sample data sets:
https://github.com/zephyr-data-specs/GMNS/blob/main/examples/Lima/GMNS/node.csv
Currently, the specification lists the type as "any," which can cause confusion. Additionally, zone_id might be mistakenly treated as a string or float type, introducing unnecessary complexities for different packages.
See
https://github.com/zephyr-data-specs/GMNS/blob/main/spec/node.schema.json
"fields": [
{
"name": "node_id",
"type": "any",
"description": "Primary key",
"constraints": {
"required": true
}
},
This ambiguity could have downstream implications for from_node_id and to_node_id in the link schema:
https://github.com/zephyr-data-specs/GMNS/blob/main/spec/link.schema.json
To avoid these issues, we should standardize node_id and zone_id as integers in the specifications.