Skip to content

Commit ebe8cfa

Browse files
carlescufifabiobaltieri
authored andcommitted
action: Print reason for N/A in old and new revision columns
To make it easier to identify which projects have been added or removed. Signed-off-by: Carles Cufi <[email protected]>
1 parent 622e99f commit ebe8cfa

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

action.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,8 @@ def main():
460460
old_rev = None if p in aprojs else next(
461461
filter(lambda _p: _p[0] == p[0], old_projs))[1]
462462
new_rev = None if p in rprojs else p[1]
463+
or_note = ' (Added)' if not old_rev else ''
464+
nr_note = ' (Removed)' if not new_rev else ''
463465
url = manifest.get_projects([p[0]])[0].url
464466
re_url = re.compile(r'https://github\.com/'
465467
'([A-Za-z0-9_.-]+/[A-Za-z0-9_.-]+)/?')
@@ -468,21 +470,21 @@ def main():
468470
except (GithubException, TypeError) as error:
469471
log(error)
470472
log(f"Can't get repo for {p[0]}; output will be limited")
471-
strs.append(f'| {p[0]} | {old_rev} | {new_rev} | N/A |')
473+
strs.append(f'| {p[0]} | {old_rev}{or_note} | {new_rev}{nr_note} | N/A |')
472474
continue
473475

474-
line = f'| {p[0]} | {fmt_rev(repo, old_rev)} '
476+
line = f'| {p[0]} | {fmt_rev(repo, old_rev)}{or_note} '
475477
if p in pr_projs:
476478
pr = repo.get_pull(int(re_rev.match(new_rev)[1]))
477-
line += f'| {pr.html_url} '
479+
line += f'| {pr.html_url}{nr_note} '
478480
line += f'| [{repo.full_name}#{pr.number}/files]' + \
479481
f'({pr.html_url}/files) |'
480482
else:
481483
if check_impostor and new_rev and is_impostor(repo, new_rev):
482484
impostor_shas += 1
483-
line += f'|\u274c Impostor SHA: {fmt_rev(repo, new_rev)} '
485+
line += f'|\u274c Impostor SHA: {fmt_rev(repo, new_rev)}{nr_note} '
484486
else:
485-
line += f'| {fmt_rev(repo, new_rev)} '
487+
line += f'| {fmt_rev(repo, new_rev)}{nr_note}'
486488
if p in uprojs:
487489
line += f'| [{repo.full_name}@{shorten_rev(old_rev)}..' + \
488490
f'{shorten_rev(new_rev)}]' + \

0 commit comments

Comments
 (0)