Skip to content

Conversation

@fabiobaltieri
Copy link
Member

@fabiobaltieri fabiobaltieri commented Nov 11, 2024

Add a base-path action input variable and use it on all steps that are using paths, annotate that app-path can only be a single directory. The west tool creates the workspace on the parent of app-path so this is inline with that behavior, and allows using the action on repositories where the manifest lives in a subdirectory.

Fixes #20

@kartben
Copy link
Collaborator

kartben commented Nov 11, 2024

The zephir manufest? 😬

@fabiobaltieri fabiobaltieri force-pushed the env branch 4 times, most recently from d6ceb1d to 2179e25 Compare November 11, 2024 16:52
@fabiobaltieri
Copy link
Member Author

fabiobaltieri commented Nov 11, 2024

The zephir manufest? 😬

Precyseli

Add a base-path action input variable and use it on all steps that are
using paths, annotate that app-path can only be a single directory. The
west tool creates the workspace on the parent of app-path so this is
inline with that behavior, and allows using the action on repositories
where the manifest lives in a subdirectory.

Signed-off-by: Fabio Baltieri <[email protected]>
@fabiobaltieri fabiobaltieri changed the title Set ZEPHIR_BASE for the action Add a base-path action input variable Nov 11, 2024
@fabiobaltieri fabiobaltieri marked this pull request as ready for review November 11, 2024 18:40
@fabiobaltieri
Copy link
Member Author

Ok this should fix #20, I tested it on my super secret github action repository and on zephyrproject-rtos/zephyr#81241, asked the issue reporter to test it as well, default to "." so there should be no changes to current users.

@fabiobaltieri fabiobaltieri self-assigned this Nov 11, 2024
@JtheSaw
Copy link

JtheSaw commented Nov 12, 2024

I have the same problem with a project structure as seen below. What configuration would be needed?

.west/
    config
firmware/
    src/
        ...
    west.yml

The config file looks like this:

[manifest]
path = firmware
file = west.yml

If I remove the config file it works for Github Actions but not if I check out my project and run west update. Is there a way to get your Action running with a .west/config present?

@fabiobaltieri
Copy link
Member Author

@JtheSaw you should not be checking the west config in the repository, that's meant to be generated by west init based on west.yml. See https://github.com/zephyrproject-rtos/example-application/.

@fabiobaltieri fabiobaltieri merged commit cc45ec3 into zephyrproject-rtos:main Nov 15, 2024
4 checks passed
@fabiobaltieri fabiobaltieri deleted the env branch November 15, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

west update fails if app-path is more than 1 folder deep

4 participants