check_compliance.py: run pylint in GIT_TOP

Running pylint outside ZEPHYR_BASE was:
- not intuitive as it required unsetting ZEPHYR_BASE
- crashing when running in subdirectories

Just run it in GIT_TOP and be done.

Signed-off-by: Marc Herbert <[email protected]>

Author: marc-hb

scripts/check_compliance.py

@@ -728,7 +728,7 @@ class PyLint(ComplianceTest):
     _doc = "https://www.pylint.org/"
 
     def run(self):
-        self.prepare(ZEPHYR_BASE)
+        self.prepare(GIT_TOP)
 
         # Path to pylint configuration file
         pylintrc = os.path.join(os.path.dirname(__file__), "pylintrc")
@@ -741,8 +741,10 @@ def run(self):
             ":!boards/xtensa/intel_s1000_crb/support/create_board_img.py") \
             .splitlines()
 
-        # Filter out everything but Python files
-        py_files = filter_py(files)
+        # Filter out everything but Python files. Keep filenames
+        # relative (to GIT_TOP) to stay farther from any command line
+        # limit.
+        py_files = filter_py(GIT_TOP, files)
         if not py_files:
             return
 
@@ -754,7 +756,7 @@ def run(self):
                 pylintcmd,
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE,
-                cwd=ZEPHYR_BASE)
+                cwd=GIT_TOP)
         except FileNotFoundError:
             self.error("pylint not found. Check that the directory it's in is "
                        "listed in the PATH environment variable.")
@@ -767,15 +769,17 @@ def run(self):
             self.add_failure(stdout.decode("utf-8") + stderr.decode("utf-8"))
 
 
-def filter_py(fnames):
+def filter_py(root, fnames):
     # PyLint check helper. Returns all Python script filenames among the
-    # filenames in 'fnames'. Uses the python-magic library, so that we can
-    # detect Python files that don't end in .py as well. python-magic is a
-    # frontend to libmagic, which is also used by 'file'.
+    # filenames in 'fnames', relative to directory 'root'. Uses the
+    # python-magic library, so that we can detect Python files that
+    # don't end in .py as well. python-magic is a frontend to libmagic,
+    # which is also used by 'file'.
 
     return [fname for fname in fnames
             if fname.endswith(".py") or
-               magic.from_file(fname, mime=True) == "text/x-python"]
+               magic.from_file(os.path.join(root, fname),
+                               mime=True) == "text/x-python"]
 
 
 class License(ComplianceTest):