Correct issue ARM-software#197 : missing prototypes

christophe0606 · christophe0606 · commit 60a6ec107d9b · 2024-07-16T08:14:38.000+02:00
diff --git a/Source/DistanceFunctions/arm_boolean_distance_template.h b/Source/DistanceFunctions/arm_boolean_distance_template.h
@@ -52,6 +52,23 @@
 
 #define FUNC(EXT) _FUNC(arm_boolean_distance, EXT)
 
+extern void FUNC(EXT)(const uint32_t *pA
+       , const uint32_t *pB
+       , uint32_t numberOfBools
+#ifdef TT
+       , uint32_t *cTT
+#endif
+#ifdef FF
+       , uint32_t *cFF
+#endif
+#ifdef TF
+       , uint32_t *cTF
+#endif
+#ifdef FT
+       , uint32_t *cFT
+#endif
+       );
+
 /**
  * @brief        Elements of boolean distances
  *
diff --git a/Source/FastMathFunctions/arm_vlog_f16.c b/Source/FastMathFunctions/arm_vlog_f16.c
@@ -72,7 +72,7 @@ static float16_t lut_logf16[NB_LUT_LOGF16]={
    0.0625,-0.00195305,0.0000804357};
 
 
-float16_t logf16_scalar(float16_t x)
+static float16_t logf16_scalar(float16_t x)
 {
     int16_t i =  arm_typecast_s16_f16(x);
 
@@ -108,7 +108,7 @@ float16_t logf16_scalar(float16_t x)
 #include "arm_vec_math_f16.h"
 
 
-float16x8_t vlogq_lut_f16(float16x8_t vecIn)
+static float16x8_t vlogq_lut_f16(float16x8_t vecIn)
 {
     int16x8_t i =  vreinterpretq_s16_f16(vecIn);
 
diff --git a/Source/FastMathFunctions/arm_vlog_q15.c b/Source/FastMathFunctions/arm_vlog_q15.c
@@ -128,7 +128,7 @@ static uint16_t arm_scalar_log_q15(uint16_t src)
 #if defined(ARM_MATH_MVEI) && !defined(ARM_MATH_AUTOVECTORIZE)
 
 
-q15x8_t vlogq_q15(q15x8_t src)
+static q15x8_t vlogq_q15(q15x8_t src)
 {
 
    int i;
diff --git a/Source/FastMathFunctions/arm_vlog_q31.c b/Source/FastMathFunctions/arm_vlog_q31.c
@@ -123,7 +123,7 @@ static uint32_t arm_scalar_log_q31(uint32_t src)
 #if defined(ARM_MATH_MVEI) && !defined(ARM_MATH_AUTOVECTORIZE)
 
 
-q31x4_t vlogq_q31(q31x4_t src)
+static q31x4_t vlogq_q31(q31x4_t src)
 {
 
    int32_t i;
diff --git a/Source/FilteringFunctions/arm_fir_q7.c b/Source/FilteringFunctions/arm_fir_q7.c
@@ -152,7 +152,7 @@ static void arm_fir_q7_49_64_mve(const arm_fir_instance_q7 * S,
 }
 
 
-ARM_DSP_ATTRIBUTE void arm_fir_q7_33_48_mve(const arm_fir_instance_q7 * S,
+static void arm_fir_q7_33_48_mve(const arm_fir_instance_q7 * S,
   const q7_t * __restrict pSrc,
   q7_t * __restrict pDst, uint32_t blockSize)
 {
@@ -175,7 +175,7 @@ static void arm_fir_q7_17_32_mve(const arm_fir_instance_q7 * S,
 }
 
 
-ARM_DSP_ATTRIBUTE void arm_fir_q7_1_16_mve(const arm_fir_instance_q7 * S,
+static void arm_fir_q7_1_16_mve(const arm_fir_instance_q7 * S,
   const q7_t * __restrict pSrc,
   q7_t * __restrict pDst, uint32_t blockSize)
 {
diff --git a/Source/TransformFunctions/arm_bitreversal.c b/Source/TransformFunctions/arm_bitreversal.c
@@ -29,6 +29,11 @@
 #include "dsp/transform_functions.h"
 #include "arm_common_tables.h"
 
+void arm_bitreversal_f32(
+        float32_t * pSrc,
+        uint16_t fftSize,
+        uint16_t bitRevFactor,
+  const uint16_t * pBitRevTab);
 
 /**
   @brief         In-place floating-point bit reversal function.
@@ -99,6 +104,11 @@ ARM_DSP_ATTRIBUTE void arm_bitreversal_f32(
    }
 }
 
+void arm_bitreversal_q31(
+        q31_t * pSrc,
+        uint32_t fftLen,
+        uint16_t bitRevFactor,
+  const uint16_t * pBitRevTab);
 
 /**
   @brief         In-place Q31 bit reversal function.
@@ -168,6 +178,11 @@ ARM_DSP_ATTRIBUTE void arm_bitreversal_q31(
    }
 }
 
+void arm_bitreversal_q15(
+        q15_t * pSrc16,
+        uint32_t fftLen,
+        uint16_t bitRevFactor,
+  const uint16_t * pBitRevTab);
 
 
 /**
diff --git a/Source/TransformFunctions/arm_bitreversal2.c b/Source/TransformFunctions/arm_bitreversal2.c
@@ -29,6 +29,11 @@
 #include "dsp/transform_functions.h"
 #include "arm_common_tables.h"
 
+void arm_bitreversal_64(
+        uint64_t *pSrc,
+  const uint16_t bitRevLen,
+  const uint16_t *pBitRevTab);
+
 
 /**
   @brief         In-place 64 bit reversal function.
@@ -64,6 +69,11 @@ ARM_DSP_ATTRIBUTE void arm_bitreversal_64(
   }
 }
 
+void arm_bitreversal_32(
+        uint32_t *pSrc,
+  const uint16_t bitRevLen,
+  const uint16_t *pBitRevTab);
+
 /**
   @brief         In-place 32 bit reversal function.
   @param[in,out] pSrc        points to in-place buffer of unknown 32-bit data type
@@ -97,6 +107,11 @@ ARM_DSP_ATTRIBUTE void arm_bitreversal_32(
   }
 }
 
+void arm_bitreversal_16(
+        uint16_t *pSrc,
+  const uint16_t bitRevLen,
+  const uint16_t *pBitRevTab);
+
 
 /**
   @brief         In-place 16 bit reversal function.
diff --git a/Source/TransformFunctions/arm_bitreversal_f16.c b/Source/TransformFunctions/arm_bitreversal_f16.c
@@ -28,6 +28,12 @@
 
 #include "dsp/transform_functions_f16.h"
 
+void arm_bitreversal_f16(
+float16_t * pSrc,
+uint16_t fftSize,
+uint16_t bitRevFactor,
+const uint16_t * pBitRevTab);
+
 /*
 * @brief  In-place bit reversal function.
 * @param[in, out] *pSrc        points to the in-place buffer of floating-point data type.
diff --git a/Source/TransformFunctions/arm_cfft_f32.c b/Source/TransformFunctions/arm_cfft_f32.c
@@ -754,7 +754,7 @@ extern void arm_bitreversal_32(
 
  */
 
-ARM_DSP_ATTRIBUTE void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float32_t * p1)
+static void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float32_t * p1)
 {
   uint32_t    L  = S->fftLen;
   float32_t * pCol1, * pCol2, * pMid1, * pMid2;
@@ -868,7 +868,7 @@ ARM_DSP_ATTRIBUTE void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float3
   arm_radix8_butterfly_f32 (pCol2, L, (float32_t *) S->pTwiddle, 2U);
 }
 
-ARM_DSP_ATTRIBUTE void arm_cfft_radix8by4_f32 (arm_cfft_instance_f32 * S, float32_t * p1)
+static void arm_cfft_radix8by4_f32 (arm_cfft_instance_f32 * S, float32_t * p1)
 {
     uint32_t    L  = S->fftLen >> 1;
     float32_t * pCol1, *pCol2, *pCol3, *pCol4, *pEnd1, *pEnd2, *pEnd3, *pEnd4;
diff --git a/Source/TransformFunctions/arm_cfft_f64.c b/Source/TransformFunctions/arm_cfft_f64.c
@@ -186,7 +186,7 @@ ARM_DSP_ATTRIBUTE void arm_radix4_butterfly_f64(
 * @param[in]      twidCoefModifier twiddle coefficient modifier that supports different size FFTs with the same twiddle factor table.
 */
 
-ARM_DSP_ATTRIBUTE void arm_cfft_radix4by2_f64(
+static void arm_cfft_radix4by2_f64(
     float64_t * pSrc,
     uint32_t fftLen,
     const float64_t * pCoef)
diff --git a/Source/TransformFunctions/arm_cfft_radix8_f16.c b/Source/TransformFunctions/arm_cfft_radix8_f16.c
@@ -30,6 +30,11 @@
 
 #if defined(ARM_FLOAT16_SUPPORTED)
 
+void arm_radix8_butterfly_f16(
+  float16_t * pSrc,
+  uint16_t fftLen,
+  const float16_t * pCoef,
+  uint16_t twidCoefModifier);
 
 /* ----------------------------------------------------------------------
  * Internal helper function used by the FFTs
diff --git a/Source/TransformFunctions/arm_cfft_radix8_f32.c b/Source/TransformFunctions/arm_cfft_radix8_f32.c
@@ -33,6 +33,12 @@
  * Internal helper function used by the FFTs
  * -------------------------------------------------------------------- */
 
+void arm_radix8_butterfly_f32(
+  float32_t * pSrc,
+  uint16_t fftLen,
+  const float32_t * pCoef,
+  uint16_t twidCoefModifier);
+
 /**
   brief         Core function for the floating-point CFFT butterfly process.
   param[in,out] pSrc             points to the in-place buffer of floating-point data type.
diff --git a/Testing/cmsis_build/cdefault.yml b/Testing/cmsis_build/cdefault.yml
@@ -28,6 +28,7 @@ default:
         - -Wno-parentheses-equality 
         - -Wno-reserved-identifier
         - -ffunction-sections
+        - -Wmissing-prototypes
         - -DARM_DSP_ATTRIBUTE="__attribute__((weak))"
         - -DARM_DSP_TABLE_ATTRIBUTE="__attribute__((section (\"dsp_table\")))"
       CPP:
@@ -70,6 +71,7 @@ default:
         - -Wno-maybe-uninitialized
         - -fdata-sections
         - -mfp16-format=ieee
+        - -Wmissing-prototypes
         - -DARM_DSP_ATTRIBUTE="__attribute__((weak))"
         - -DARM_DSP_TABLE_ATTRIBUTE="__attribute__((section (\"dsp_table\")))"
       CPP:
@@ -120,6 +122,7 @@ default:
          - -Wno-parentheses-equality 
          - -Wno-reserved-identifier
          - -ffunction-sections
+         - -Wmissing-prototypes
          - -DARM_DSP_ATTRIBUTE="__attribute__((weak))"
          - -DARM_DSP_TABLE_ATTRIBUTE="__attribute__((section (\"dsp_table\")))"
       CPP:

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ static float16_t lut_logf16[NB_LUT_LOGF16]={`
`72`	`72`	`0.0625,-0.00195305,0.0000804357};`
`73`	`73`
`74`	`74`
`75`		`-float16_t logf16_scalar(float16_t x)`
	`75`	`+static float16_t logf16_scalar(float16_t x)`
`76`	`76`	`{`
`77`	`77`	`int16_t i = arm_typecast_s16_f16(x);`
`78`	`78`
`@@ -108,7 +108,7 @@ float16_t logf16_scalar(float16_t x)`
`108`	`108`	`#include "arm_vec_math_f16.h"`
`109`	`109`
`110`	`110`
`111`		`-float16x8_t vlogq_lut_f16(float16x8_t vecIn)`
	`111`	`+static float16x8_t vlogq_lut_f16(float16x8_t vecIn)`
`112`	`112`	`{`
`113`	`113`	`int16x8_t i = vreinterpretq_s16_f16(vecIn);`
`114`	`114`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ static uint16_t arm_scalar_log_q15(uint16_t src)`
`128`	`128`	`#if defined(ARM_MATH_MVEI) && !defined(ARM_MATH_AUTOVECTORIZE)`
`129`	`129`
`130`	`130`
`131`		`-q15x8_t vlogq_q15(q15x8_t src)`
	`131`	`+static q15x8_t vlogq_q15(q15x8_t src)`
`132`	`132`	`{`
`133`	`133`
`134`	`134`	`int i;`
Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ static uint32_t arm_scalar_log_q31(uint32_t src)`
`123`	`123`	`#if defined(ARM_MATH_MVEI) && !defined(ARM_MATH_AUTOVECTORIZE)`
`124`	`124`
`125`	`125`
`126`		`-q31x4_t vlogq_q31(q31x4_t src)`
	`126`	`+static q31x4_t vlogq_q31(q31x4_t src)`
`127`	`127`	`{`
`128`	`128`
`129`	`129`	`int32_t i;`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ static void arm_fir_q7_49_64_mve(const arm_fir_instance_q7 * S,`
`152`	`152`	`}`
`153`	`153`
`154`	`154`
`155`		`-ARM_DSP_ATTRIBUTE void arm_fir_q7_33_48_mve(const arm_fir_instance_q7 * S,`
	`155`	`+static void arm_fir_q7_33_48_mve(const arm_fir_instance_q7 * S,`
`156`	`156`	`const q7_t * __restrict pSrc,`
`157`	`157`	`q7_t * __restrict pDst, uint32_t blockSize)`
`158`	`158`	`{`
`@@ -175,7 +175,7 @@ static void arm_fir_q7_17_32_mve(const arm_fir_instance_q7 * S,`
`175`	`175`	`}`
`176`	`176`
`177`	`177`
`178`		`-ARM_DSP_ATTRIBUTE void arm_fir_q7_1_16_mve(const arm_fir_instance_q7 * S,`
	`178`	`+static void arm_fir_q7_1_16_mve(const arm_fir_instance_q7 * S,`
`179`	`179`	`const q7_t * __restrict pSrc,`
`180`	`180`	`q7_t * __restrict pDst, uint32_t blockSize)`
`181`	`181`	`{`
Original file line number	Diff line number	Diff line change
`@@ -754,7 +754,7 @@ extern void arm_bitreversal_32(`
`754`	`754`
`755`	`755`	`*/`
`756`	`756`
`757`		`-ARM_DSP_ATTRIBUTE void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float32_t * p1)`
	`757`	`+static void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float32_t * p1)`
`758`	`758`	`{`
`759`	`759`	`uint32_t L = S->fftLen;`
`760`	`760`	`float32_t * pCol1, * pCol2, * pMid1, * pMid2;`
`@@ -868,7 +868,7 @@ ARM_DSP_ATTRIBUTE void arm_cfft_radix8by2_f32 (arm_cfft_instance_f32 * S, float3`
`868`	`868`	`arm_radix8_butterfly_f32 (pCol2, L, (float32_t *) S->pTwiddle, 2U);`
`869`	`869`	`}`
`870`	`870`
`871`		`-ARM_DSP_ATTRIBUTE void arm_cfft_radix8by4_f32 (arm_cfft_instance_f32 * S, float32_t * p1)`
	`871`	`+static void arm_cfft_radix8by4_f32 (arm_cfft_instance_f32 * S, float32_t * p1)`
`872`	`872`	`{`
`873`	`873`	`uint32_t L = S->fftLen >> 1;`
`874`	`874`	`float32_t * pCol1, pCol2, pCol3, pCol4, pEnd1, pEnd2, pEnd3, *pEnd4;`