Skip to content

Commit 3ba5a1e

Browse files
committed
Macro rename for samv71q-pinctrl.h PE5X AFEC0 AD3 was erroneusly AFEC1
The pin macro for SAM V71 Q relative to PE5 use as AFEC0 AD3 is now named PE5X_AFE0_AD3. Previously it was named as if it is relative to AFEC1 AD3 (PE5X_AFE1_AD3). A check can be made by reading the pinout table of ATSAMV71 for 144 pinout (datasheet: https://ww1.microchip.com/downloads/aemDocuments/documents/MCU32/ProductDocuments/DataSheets/SAM-E70-S70-V70-V71-Family-Data-Sheet-DS60001527.pdf) (start fo the table: page 28; relevant table section: page 33, LQFP pin 28). The pinconfig YAML for the s70, e70 and v7x has a typo for the AFEC. The typo is this: AFEC0 AD3 and AD4 was referenced for AFEC1. The solution was: - Edit the pinconfigs YAML for [s,e]70, v7x. - Run the sampinconfig.py script to regenerate the includes Signed-off-by: zebo9x <ivan.zebo@gmail.com>
1 parent d6221e7 commit 3ba5a1e

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

include/dt-bindings/pinctrl/same70q-pinctrl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1986,8 +1986,8 @@
19861986
#define PE4B_TC3_TIOB10 \
19871987
SAM_PINMUX(e, 4, b, periph)
19881988

1989-
/* pe4x_afe1_ad4 */
1990-
#define PE4X_AFE1_AD4 \
1989+
/* pe4x_afe0_ad4 */
1990+
#define PE4X_AFE0_AD4 \
19911991
SAM_PINMUX(e, 4, x, extra)
19921992

19931993
/* pe5_gpio */
@@ -2002,6 +2002,6 @@
20022002
#define PE5B_TC3_TCLK10 \
20032003
SAM_PINMUX(e, 5, b, periph)
20042004

2005-
/* pe5x_afe1_ad3 */
2006-
#define PE5X_AFE1_AD3 \
2005+
/* pe5x_afe0_ad3 */
2006+
#define PE5X_AFE0_AD3 \
20072007
SAM_PINMUX(e, 5, x, extra)

include/dt-bindings/pinctrl/sams70q-pinctrl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1874,8 +1874,8 @@
18741874
#define PE4B_TC3_TIOB10 \
18751875
SAM_PINMUX(e, 4, b, periph)
18761876

1877-
/* pe4x_afe1_ad4 */
1878-
#define PE4X_AFE1_AD4 \
1877+
/* pe4x_afe0_ad4 */
1878+
#define PE4X_AFE0_AD4 \
18791879
SAM_PINMUX(e, 4, x, extra)
18801880

18811881
/* pe5_gpio */
@@ -1890,6 +1890,6 @@
18901890
#define PE5B_TC3_TCLK10 \
18911891
SAM_PINMUX(e, 5, b, periph)
18921892

1893-
/* pe5x_afe1_ad3 */
1894-
#define PE5X_AFE1_AD3 \
1893+
/* pe5x_afe0_ad3 */
1894+
#define PE5X_AFE0_AD3 \
18951895
SAM_PINMUX(e, 5, x, extra)

include/dt-bindings/pinctrl/samv70q-pinctrl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1910,8 +1910,8 @@
19101910
#define PE4B_TC3_TIOB10 \
19111911
SAM_PINMUX(e, 4, b, periph)
19121912

1913-
/* pe4x_afe1_ad4 */
1914-
#define PE4X_AFE1_AD4 \
1913+
/* pe4x_afe0_ad4 */
1914+
#define PE4X_AFE0_AD4 \
19151915
SAM_PINMUX(e, 4, x, extra)
19161916

19171917
/* pe5_gpio */
@@ -1926,6 +1926,6 @@
19261926
#define PE5B_TC3_TCLK10 \
19271927
SAM_PINMUX(e, 5, b, periph)
19281928

1929-
/* pe5x_afe1_ad3 */
1930-
#define PE5X_AFE1_AD3 \
1929+
/* pe5x_afe0_ad3 */
1930+
#define PE5X_AFE0_AD3 \
19311931
SAM_PINMUX(e, 5, x, extra)

include/dt-bindings/pinctrl/samv71q-pinctrl.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1998,8 +1998,8 @@
19981998
#define PE4B_TC3_TIOB10 \
19991999
SAM_PINMUX(e, 4, b, periph)
20002000

2001-
/* pe4x_afe1_ad4 */
2002-
#define PE4X_AFE1_AD4 \
2001+
/* pe4x_afe0_ad4 */
2002+
#define PE4X_AFE0_AD4 \
20032003
SAM_PINMUX(e, 4, x, extra)
20042004

20052005
/* pe5_gpio */
@@ -2014,6 +2014,6 @@
20142014
#define PE5B_TC3_TCLK10 \
20152015
SAM_PINMUX(e, 5, b, periph)
20162016

2017-
/* pe5x_afe1_ad3 */
2018-
#define PE5X_AFE1_AD3 \
2017+
/* pe5x_afe0_ad3 */
2018+
#define PE5X_AFE0_AD3 \
20192019
SAM_PINMUX(e, 5, x, extra)

pinconfigs/sam-s70-e70-v7x.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -805,11 +805,11 @@ pins:
805805
- [a, ebi, d12, [j, n]]
806806
- [b, tc3, tiob10]
807807
extra:
808-
- [x, afe1, ad4]
808+
- [x, afe0, ad4]
809809
pe5:
810810
pincodes: [q]
811811
periph:
812812
- [a, ebi, d13, [j, n]]
813813
- [b, tc3, tclk10]
814814
extra:
815-
- [x, afe1, ad3]
815+
- [x, afe0, ad3]

0 commit comments

Comments
 (0)