Skip to content

Commit 8979dff

Browse files
committed
monitor: remove addressing decode by default
Whenever an hex address is present in monitor, a yellow warning presents the function in that address. If is enabled by default. This commit changes it to default false. Anyone can re-enabled it by adding a "-d": west espressif monitor -d Signed-off-by: Sylvio Alves <[email protected]>
1 parent 02ec0ba commit 8979dff

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

west/tools.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ def do_add_parser(self, parser_adder):
144144
group.add_argument('-p', '--port', help='Serial port address')
145145
group.add_argument('-e', '--elf', help='ELF file')
146146
group.add_argument('-n', '--eol', default='CRLF', help='EOL to use')
147+
group.add_argument('-d', '--enable-address-decoding', action='store_true',
148+
help='Enable address decoding in the monitor')
147149

148150
return parser
149151

@@ -178,5 +180,12 @@ def monitor(self, module_path, args):
178180

179181
monitor_path = Path(module_path, "tools/idf_monitor/idf_monitor.py")
180182
cmd_path = Path(os.getcwd())
181-
cmd_exec((sys.executable, str(monitor_path), "-p", esp_port,
182-
"-b", args.baud, str(elf_path), "--eol", args.eol), cwd=cmd_path)
183+
184+
# Build command arguments
185+
cmd = [sys.executable, str(monitor_path), "-p", esp_port, "-b", args.baud, str(elf_path), "--eol", args.eol]
186+
187+
# Add "-d" flag by default unless explicitly enabled
188+
if not args.enable_address_decoding:
189+
cmd.append("-d")
190+
191+
cmd_exec(cmd, cwd=cmd_path)

0 commit comments

Comments
 (0)