espressif: mcuboot: get MCUBOOT_BOOT_MAX_ALIGN value from DT #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almir-okato
force-pushed
the
fix_esp_mcuboot_flash_enc_flash_imp_layer
branch
from
20db6f2 to
0aa5092
Compare
This change affects only MCUboot Zephyr Port for ESP chips or Zephyr application with MCUboot compatibilty (which builds the bootutil lib). In these cases, MCUBOOT_BOOT_MAX_ALIGN value must be taken from DT flash write-block-size if its greater than 8. Signed-off-by: Almir Okato <[email protected]>
almir-okato
force-pushed
the
fix_esp_mcuboot_flash_enc_flash_imp_layer
branch
from
0aa5092 to
e72d5d3
Compare
almir-okato
requested review from
LucasTambor,
marekmatej and
sylvioalves
as code owners
almir-okato
changed the title
marekmatej
reviewed
Aug 15, 2025
| @@ -7,6 +7,8 @@ | |||
| #ifndef __MCUBOOT_CONFIG_H__ | |||
| #define __MCUBOOT_CONFIG_H__ | |||
|
|
|||
| #include <zephyr/devicetree.h> | |||
There was a problem hiding this comment.
maybe putting this include under the ifdef CONFIG_SECURE_FLASH_ENC_ENABLED ?
There was a problem hiding this comment.
This file is used only from Zephyr application or Zephyr port builds, so this include should not be a problem.
Also there is no CONFIG_SECURE_FLASH_ENC_ENABLED config on Zephyr application side, the flash encryption enabled/disabled checking is done on runtime. The write-block size must match the flash encryption requirement prior to the build though.
marekmatej
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.