Use CONFIG_HAS_GDLIB as common define to use gigadevice hal. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOC_SERIES variables are not the same between GD32 and GD32V. Use sharable config value. Signed-off-by: TOKITA Hiroshi <[email protected]>
Member
|
Please raise this issue as part of zephyrproject-rtos/zephyr#38658 where CMakeLists.txt is being developed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GD32 and GD32V is different series, so SOC_FAMILY must be different.
(GD32V can't have CONFIG_SOC_FAMILY_GD32 by naming convention in soc/riscv/riscv-privilege, must be CONFIG_SOC_FAMILY_RISCV_PRIVILEGE.)
I think CONFIG_HAS_GDLIB is good to share define between GD32 and GD32V.
The define is respecting @feilongfl branch https://github.com/feilongfl/zephyr/tree/dev-GD32E103_EVAL.
(It is seem to be inherit from stm32. There may be a better name. )
related #34970.