gd32: add gd32f4xx #6

cameled · 2021-10-19T10:27:00Z

Add GD32F4xx firmware library V2.1.3.

cameled · 2021-10-19T10:29:29Z

GD32F405/407, GDF450 use the same gd32f4xx firmware library.
GD32F403 have different hardware and software implement.

gmarull

Please, squash into a single commit
Provide the origin download URL for the HAL in the commit message

GD32F4xx/LICENSE

nandojve · 2021-10-21T02:06:34Z

Hi @cameled ,

Thank you for helping us. I few minors to make sure everything is in the right place:

It is important make sure you are sending last version. I noted that last one is 2.1.3
make sure code uses Linux LF. You can run something like find * type f -print0 | xargs -0 dos2unix -k
make sure directory is upper case GD32F4XX and follow current directory structure:

GD32F4XX
  ├── CMSIS
  │   └── GD
  │       └── GD32F4XX
  └── standard_peripheral
      ├── Include
      └── Source

You may need adjust timer_init name, see ddde23c
You may need adjust some CAN defines, see 223ccbf

cameled · 2021-10-21T06:25:15Z

Hi @cameled ,

Thank you for helping us. I few minors to make sure everything is in the right place:

* It is important make sure you are sending last version. I noted that last one is  [2.1.3](http://www.gd32mcu.com/download/down/document_id/247/path_type/1)

* make sure code uses Linux LF. You can run something like `find * type f -print0 | xargs -0 dos2unix -k`

* make sure directory is upper case GD32F4XX and follow current directory structure:

GD32F4XX
  ├── CMSIS
  │   └── GD
  │       └── GD32F4XX
  └── standard_peripheral
      ├── Include
      └── Source

* You may need adjust timer_init name, see [ddde23c](https://github.com/zephyrproject-rtos/hal_gigadevice/commit/ddde23cadb1f089263fae2d167e4d83a742d373c)

* You may need adjust some CAN defines, see [223ccbf](https://github.com/zephyrproject-rtos/hal_gigadevice/commit/223ccbfd8ae4bb6b3ada14e4a44995baeefad762)

I have update the GD32F4XX.

Upgrade to V2.1.3. (done)
Linux LF check. (done)
GD32F4XX directory. (done)
Rename timer_init function. (done)
Fix gd32f4xx_can name conflict. (done)

cameled · 2021-10-21T07:38:42Z

Hi @nandojve
Could you please make some adjust on zephyrproject-rtos/zephyr#38661 SoC firmware library select logic?

nandojve · 2021-10-21T19:34:46Z

Hi @nandojve Could you please make some adjust on zephyrproject-rtos/zephyr#38661 SoC firmware library select logic?

If you detected any problem, please, suggest at zephyrproject-rtos/zephyr#38661.

nandojve · 2021-10-28T16:02:40Z

Hi @cameled ,

To get this in, we need a PR at Zephyr that build this library with a board. Are you open a PR for F405?
Now that zephyrproject-rtos/zephyr#38661 got merged, it will be easy to send it.

cameled · 2021-10-29T01:07:51Z

Hi @cameled ,

To get this in, we need a PR at Zephyr that build this library with a board. Are you open a PR for F405?

I have a GD32F450I-EVAL board, and gd32f4xx library will work with it.

Now that zephyrproject-rtos/zephyr#38661 got merged, it will be easy to send it.

Thast's great!

gmarull · 2021-10-29T07:51:25Z

FYI I'll open a PR for GD32F450I-EVAL board in the next couple of days, I just need to improve the organization of Kconfig options as current model doesn't fit F4XX (SoC name != HAL name as in F403).

Ref. https://github.com/teslabs/zephyr/tree/gd32f450

cameled · 2021-10-31T00:50:56Z

FYI I'll open a PR for GD32F450I-EVAL board in the next couple of days, I just need to improve the organization of Kconfig options as current model doesn't fit F4XX (SoC name != HAL name as in F403).

Ref. https://github.com/teslabs/zephyr/tree/gd32f450

Hi @gmarull
GD32F450I-EVAL have support on this PR zephyrproject-rtos/zephyr#39909 , review are welcome.

gmarull

Download URL is http://www.gd32mcu.com/download/down/document_id/247/path_type/1 (0cf1247 message needs to be adjusted)

GD32F4xx firmware library support GF32F405, GD32F407 and GF32F450. Origin: http://www.gd32mcu.com/en/download Filename: GD32F4xx Firmware Library Signed-off-by: HaiLong Yang <[email protected]>

cameled · 2021-11-02T01:54:12Z

Download URL is http://www.gd32mcu.com/download/down/document_id/247/path_type/1 (0cf1247 message needs to be adjusted)

I prefer the GD32F4 download site, people can easily to know where the gd32f4xx firmware library come from.

gmarull

Please, review my comments on conflicting names. Also, please create a section in the HAL README file/s to document which names have conflict and their new names.

GD32F4XX/standard_peripheral/Source/gd32f4xx_can.c

GD32F4XX/standard_peripheral/Include/gd32f4xx_timer.h

GD32F4XX/standard_peripheral/Include/gd32f4xx_can.h

gmarull

Thanks for the efforts, LGTM!

carlescufi · 2021-11-04T11:26:42Z

@nandojve could you please review?

nandojve · 2021-11-05T15:13:38Z

@nandojve could you please review?

Hi @carlescufi , yes, I can start in the weekend. It has been an unprecedented week and I had not have proper time to check Zephyr PRs since last week.

nandojve

Hi @cameled and @gmarull ,

LGTM in overall. However, first we should define what will be the standard that we will follow. Otherwise we can fall into the trap of opinions and create unnecessary conflicts.

In my view, this can be in following what we already have in tree or only after #8 with proper adjusts.

GD32F4XX/standard_peripheral/Include/gd32f4xx_timer.h

GD32F4XX/standard_peripheral/Include/gd32f4xx_can.h

gmarull · 2021-11-13T20:06:20Z

@cameled can you use gd32_/GD32_ prefixes instead of __? Then we should be good to go.

GD32 timer_init function name conflict with Zephyr. Rename it to gd32_timer_init to temporarily solve the conflict. Signed-off-by: HaiLong Yang <[email protected]>

GD32 CAN have some name conflict with Zephyr. Add prefix 'GD32_' to these GD32 CAN macro name. Signed-off-by: HaiLong Yang <[email protected]>

Zephyr have BIT macro defined in sys/util_macro.h, add a redefine check for gd32 BIT MACRO. Signed-off-by: HaiLong Yang <[email protected]>

cameled · 2021-11-14T06:08:36Z

@cameled can you use gd32_/GD32_ prefixes instead of __? Then we should be good to go.

Done.

nandojve

LGTM

cameled force-pushed the gd32f4xx branch 2 times, most recently from 60cbedd to fdc9571 Compare October 19, 2021 11:28

gmarull mentioned this pull request Oct 20, 2021

hal: add GD32F4xx series HAL version 2.1.0 #7

Closed

gmarull suggested changes Oct 20, 2021

View reviewed changes

GD32F4xx/LICENSE Outdated Show resolved Hide resolved

gmarull requested a review from nandojve October 20, 2021 21:22

cameled force-pushed the gd32f4xx branch 2 times, most recently from 70c03e0 to 0cf1247 Compare October 21, 2021 03:17

github-actions bot mentioned this pull request Nov 1, 2021

boards: arm: GD32F450I-EVAL: add initial support zephyrproject-rtos/zephyr#39958

Merged

gmarull reviewed Nov 1, 2021

View reviewed changes

gmarull mentioned this pull request Nov 1, 2021

pinctrl: initial support for GD32 zephyrproject-rtos/zephyr#39974

Merged

hal: Add GD32F4xx firmware library v2.1.3

77ab94c

GD32F4xx firmware library support GF32F405, GD32F407 and GF32F450. Origin: http://www.gd32mcu.com/en/download Filename: GD32F4xx Firmware Library Signed-off-by: HaiLong Yang <[email protected]>

cameled force-pushed the gd32f4xx branch from 55b4483 to 22c0f73 Compare November 2, 2021 01:54

gmarull suggested changes Nov 2, 2021

View reviewed changes

GD32F4XX/standard_peripheral/Source/gd32f4xx_can.c Outdated Show resolved Hide resolved

GD32F4XX/standard_peripheral/Include/gd32f4xx_timer.h Outdated Show resolved Hide resolved

cameled force-pushed the gd32f4xx branch from 22c0f73 to 4520bcf Compare November 3, 2021 15:41

gmarull reviewed Nov 3, 2021

View reviewed changes

GD32F4XX/standard_peripheral/Include/gd32f4xx_can.h Outdated Show resolved Hide resolved

cameled force-pushed the gd32f4xx branch from 4520bcf to 09ab10a Compare November 3, 2021 15:54

gmarull approved these changes Nov 3, 2021

View reviewed changes

nandojve suggested changes Nov 5, 2021

View reviewed changes

GD32F4XX/standard_peripheral/Include/gd32f4xx_timer.h Outdated Show resolved Hide resolved

GD32F4XX/standard_peripheral/Include/gd32f4xx_can.h Outdated Show resolved Hide resolved

cameled force-pushed the gd32f4xx branch from 09ab10a to 69a720b Compare November 8, 2021 09:16

github-actions bot mentioned this pull request Nov 11, 2021

boards: arm: Introduce gd32f350r_eval board zephyrproject-rtos/zephyr#40283

Merged

2 tasks

cameled added 3 commits November 14, 2021 13:57

gd32f4xx: timer: Rename timer_init function

55be617

GD32 timer_init function name conflict with Zephyr. Rename it to gd32_timer_init to temporarily solve the conflict. Signed-off-by: HaiLong Yang <[email protected]>

gd32f4xx: can: Rename CAN macro name

4bb2ad5

GD32 CAN have some name conflict with Zephyr. Add prefix 'GD32_' to these GD32 CAN macro name. Signed-off-by: HaiLong Yang <[email protected]>

hal: add redefine check for BIT macro

8ac8109

Zephyr have BIT macro defined in sys/util_macro.h, add a redefine check for gd32 BIT MACRO. Signed-off-by: HaiLong Yang <[email protected]>

cameled force-pushed the gd32f4xx branch from 69a720b to 8ac8109 Compare November 14, 2021 06:07

gmarull requested a review from nandojve November 14, 2021 10:21

nandojve approved these changes Nov 14, 2021

View reviewed changes

gmarull merged commit 7bd8904 into zephyrproject-rtos:main Nov 14, 2021

cameled deleted the gd32f4xx branch November 15, 2021 03:19

feilongfl mentioned this pull request Nov 22, 2021

[wip]add pinconfig and hal for gd32c10xxx #13

Closed

gd32: add gd32f4xx #6

gd32: add gd32f4xx #6

Uh oh!

Conversation

cameled commented Oct 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cameled commented Oct 19, 2021

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nandojve commented Oct 21, 2021

Uh oh!

cameled commented Oct 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cameled commented Oct 21, 2021

Uh oh!

nandojve commented Oct 21, 2021

Uh oh!

nandojve commented Oct 28, 2021

Uh oh!

cameled commented Oct 29, 2021

Uh oh!

gmarull commented Oct 29, 2021

Uh oh!

cameled commented Oct 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

cameled commented Nov 2, 2021

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gmarull left a comment

Choose a reason for hiding this comment

Uh oh!

carlescufi commented Nov 4, 2021

Uh oh!

nandojve commented Nov 5, 2021

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gmarull commented Nov 13, 2021

Uh oh!

cameled commented Nov 14, 2021

Uh oh!

nandojve left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cameled commented Oct 19, 2021 •

edited

Loading

cameled commented Oct 21, 2021 •

edited

Loading

cameled commented Oct 31, 2021 •

edited

Loading