Skip to content

Commit 144ade3

Browse files
haduongquangmanuargue
authored andcommitted
s32ze: canxl: always use OsIf_GetCounter before OsIf_GetElapsed
OsIf_GetCounter shall be used to obtain current counter value before passing it to OsIf_GetElapsed. Fix build warning. Signed-off-by: Ha Duong Quang <[email protected]>
1 parent a7e86fe commit 144ade3

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

s32/drivers/s32ze/Can_CANEXCEL/src/CanEXCEL_Ip.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -453,6 +453,7 @@ static Canexcel_Ip_StatusType Canexcel_ResetController(uint8 instance)
453453
uint32 uS2Ticks = OsIf_MicrosToTicks(CANEXCEL_IP_TIMEOUT_DURATION, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
454454
Canexcel_Ip_StatusType returnResult = CANEXCEL_STATUS_SUCCESS;
455455

456+
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
456457
/* Wait Hardware to became available after clock start */
457458
while ((CANEXCEL.EXL_SIC[instance]->SYSS & CANXL_SIC_SYSS_FRZACKF_MASK) == 0U)
458459
{
@@ -815,6 +816,7 @@ Canexcel_Ip_StatusType Canexcel_Ip_TxDescriptor(uint8 instance, uint8 descNo, ui
815816
{
816817
uint32 timeStart = 0U;
817818
uint32 timeElapsed = 0U;
819+
uint32 uS2Ticks = OsIf_MicrosToTicks(CANEXCEL_IP_TIMEOUT_DURATION, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
818820
Canexcel_Ip_StateType * state = Canexcel_Ip_apxState[instance];
819821
Canexcel_Ip_StatusType returnResult = CANEXCEL_STATUS_SUCCESS;
820822

@@ -825,14 +827,13 @@ Canexcel_Ip_StatusType Canexcel_Ip_TxDescriptor(uint8 instance, uint8 descNo, ui
825827
}
826828
else
827829
{
828-
uint32 uS2Ticks = OsIf_MicrosToTicks(CANEXCEL_IP_TIMEOUT_DURATION, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
829-
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
830830
/* Set system lock Status */
831831
#if (CANEXCEL_IP_HAS_SYSLOCK01 == STD_ON)
832832
CANEXCEL.EXL_DESC_CTR[instance]->DSCMBCTRLAR[descNo].DCSYSLOCK = 1U;
833833
#else
834834
(void)CANEXCEL.EXL_DESC_CTR[instance]->DSCMBCTRLAR[descNo].DCSYSLOCK;
835835
#endif
836+
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
836837
while (CANEXCEL_DESCNTSTATUS_LOCKED_HW == CanXL_GetDescControlStatus(CANEXCEL.EXL_DESC_CTR[instance], descNo))
837838
{
838839
timeElapsed += OsIf_GetElapsed(&timeStart, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);

s32/drivers/s32ze/Can_CANEXCEL/src/CanEXCEL_Ip_HwAccess.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,7 @@ Canexcel_Ip_StatusType CanXL_SoftReset(CANXL_SIC_Type * base)
237237
Canexcel_Ip_StatusType returnResult = CANEXCEL_STATUS_SUCCESS;
238238
uint32 uS2Ticks = OsIf_MicrosToTicks(CANEXCEL_IP_TIMEOUT_DURATION, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
239239
base->SYSMC = CANXL_SIC_SYSMC_SOFRST_MASK;
240+
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
240241
while ((base->SYSMC & CANXL_SIC_SYSMC_SOFRST_MASK) == CANXL_SIC_SYSMC_SOFRST_MASK)
241242
{
242243
timeElapsed += OsIf_GetElapsed(&timeStart, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
@@ -275,7 +276,7 @@ void CanXL_ClearRAM(const CANEXCEL_StructType * CANXL, uint8 instance)
275276
}
276277
}
277278
/* Clear the filter bank check the size in device reg as CANXL_IP_FILTER_BANK_SIZE */
278-
volatile uint32 * ptr = &CANXL->EXL_FILTER[instance]->AFCFG0;
279+
volatile uint32 * ptr = (volatile uint32 *)&CANXL->EXL_FILTER[instance]->AFCFG0;
279280
for (idx = 0u; idx <= (uint16)(CANXL_IP_FILTER_BANK_SIZE/4U); idx++)
280281
{
281282
ptr[idx] = 0U;
@@ -358,6 +359,7 @@ Canexcel_Ip_StatusType CanXL_EnterFreezeMode(CANXL_SIC_Type * base)
358359
}
359360
if (CANEXCEL_STATUS_SUCCESS == returnResult)
360361
{
362+
timeElapsed = 0U;
361363
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
362364
while (0U == (base->SYSS & CANXL_SIC_SYSS_FRZACKF_MASK))
363365
{
@@ -376,6 +378,7 @@ Canexcel_Ip_StatusType CanXL_EnterFreezeMode(CANXL_SIC_Type * base)
376378
SchM_Enter_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_01();
377379
base->SYSMC |= CANXL_SIC_SYSMC_LPMREQ_MASK;
378380
SchM_Exit_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_01();
381+
timeElapsed = 0U;
379382
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
380383
while (0U == (base->SYSS & CANXL_SIC_SYSS_LPMACKF_MASK))
381384
{
@@ -432,6 +435,7 @@ Canexcel_Ip_StatusType CanXL_ExitFreezeMode(CANXL_SIC_Type * base)
432435
SchM_Enter_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_02();
433436
base->SYSMC &= ~CANXL_SIC_SYSMC_FRZREQ_MASK;
434437
SchM_Exit_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_02();
438+
timeElapsed = 0U;
435439
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
436440
while (0U == (base->SYSS & CANXL_SIC_SYSS_FRZACKF_MASK))
437441
{
@@ -449,6 +453,8 @@ Canexcel_Ip_StatusType CanXL_ExitFreezeMode(CANXL_SIC_Type * base)
449453
SchM_Enter_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_02();
450454
base->SYSMC |= CANXL_SIC_SYSMC_LPMREQ_MASK;
451455
SchM_Exit_Can_43_CANEXCEL_CAN_EXCLUSIVE_AREA_02();
456+
timeElapsed = 0U;
457+
timeStart = OsIf_GetCounter(CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);
452458
while (0U == (base->SYSS & CANXL_SIC_SYSS_LPMACKF_MASK))
453459
{
454460
timeElapsed += OsIf_GetElapsed(&timeStart, CANEXCEL_IP_SERVICE_TIMEOUT_TYPE);

0 commit comments

Comments
 (0)