Support RA6 RA4 RA2 hal layer #26

duynguyenxa · 2024-07-09T06:25:52Z

This PR is a draft version to support the following feature on hal_renesas:
BSP support:
RA2A1
RA2L1
RA4M1
RA4M2
RA4M3
RA4E1
RA4E2
RA4W1
RA6M1
RA6M2
RA6M3
RA6M4
RA6M5
RA6E1
RA6E2

Module:
SCI UART: Remove DTC override setting

soburi · 2024-07-14T07:02:00Z

drivers/ra/fsp/src/r_sci_uart/r_sci_uart.c

+    /* If a transfer instance is used for reception, apply UART specific settings and open the transfer instance. */
+    if (NULL != p_cfg->p_transfer_rx)
+    {
+        transfer_info_t * p_info = p_cfg->p_transfer_rx->p_cfg->p_info;


This line is not in FSP v5.3.0.
Please describe why added this line.

We will need to update the base version in the future.
Changes from a baseline version should be tracked as separate commits.

soburi · 2024-07-14T07:09:12Z

drivers/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4E2B9.h

Some files seem to be different from those in FSP v5.3.0.
It would be a good idea to split these into separate commits and explain why they are different, if necessary.
This would make future management more difficult.

soburi · 2024-08-02T11:03:08Z

@duynguyenxa

(Move from zephyrproject-rtos/zephyr#76081 (comment))

The CMSIS header has a difference with v5.3.0.
If it is not required at this time, I think it is good to use the v5.3.0 version.
And this PR has the same modification for the SCI driver for SCI-B in #24 (comment).

Let's record this as well.

And this PR has no other problems.

Add RA6M1 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6M2 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6M3 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6M4 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6M5 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6E1 hal support Signed-off-by: Quy Tran <[email protected]>

Add RA6E2 hal support Signed-off-by: Quy Tran <[email protected]>

Modify RX transfer info for sci uart reception with DTC Remove redundant configuration Update README patch list of the modification of SCI UART source Signed-off-by: The Nguyen <[email protected]>

Add initial support for RA2L1 Signed-off-by: Quy Tran <[email protected]>

duynguyenxa · 2024-08-05T07:19:35Z

@duynguyenxa

(Move from zephyrproject-rtos/zephyr#76081 (comment))

The CMSIS header has a difference with v5.3.0. If it is not required at this time, I think it is good to use the v5.3.0 version. And this PR has the same modification for the SCI driver for SCI-B in #24 (comment).

Let's record this as well.

And this PR has no other problems.

@soburi , @ydamigos , @thaoluonguw , @KhiemNguyenT all items are updated

soburi · 2024-08-05T07:32:37Z

R7FA4E2B9.h
R7FA4M1AB.h
R7FA4M2AD.h
R7FA4M3AF.h
R7FA4W1AD.h

These are still seems to difference with v5.3.0.
If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Initial support bsp config for RA4E2 board Signed-off-by: TriNguyen <[email protected]>

Initial support bsp config for RA4M1 board Signed-off-by: TriNguyen <[email protected]>

Initial support bsp config for RA4M2 board Signed-off-by: TriNguyen <[email protected]>

Initial support bsp config for RA4M3 board Signed-off-by: TriNguyen <[email protected]>

Initial support bsp config for RA4W1 board Signed-off-by: TriNguyen <[email protected]>

Update PLL multiple calculation value Signed-off-by: Quy Tran <[email protected]>

Add new implementation for R_BSP_SecurityInit on Zephyr Signed-off-by: The Nguyen <[email protected]>

soburi · 2024-08-05T07:48:19Z

Files drivers/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M2AD.h and /home/tokita/fsp/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M2AD.h differ
Files drivers/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M3AF.h and /home/tokita/fsp/ra/fsp/src/bsp/cmsis/Device/RENESAS/Include/R7FA4M3AF.h differ

Just two more!

duynguyenxa · 2024-08-05T07:48:54Z

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h

These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Sorry I push the wrong it's OK now please help to recheck

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h

These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

@soburi , Sorry I mistakenly push only the patch, please help to recheck again

soburi · 2024-08-05T07:53:27Z

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Sorry I push the wrong it's OK now please help to recheck

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

@soburi , Sorry I mistakenly push only the patch, please help to recheck again

#26 (comment)

duynguyenxa · 2024-08-05T07:54:59Z

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Sorry I push the wrong it's OK now please help to recheck

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

@soburi , Sorry I mistakenly push only the patch note, please help to recheck again

soburi

LGTM

soburi · 2024-08-05T07:57:33Z

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Sorry I push the wrong it's OK now please help to recheck

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

@soburi , Sorry I mistakenly push only the patch note, please help to recheck again

Oops, sorry.

duynguyenxa · 2024-08-05T07:57:34Z

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

Sorry I push the wrong it's OK now please help to recheck

R7FA4E2B9.h R7FA4M1AB.h R7FA4M2AD.h R7FA4M3AF.h R7FA4W1AD.h
These are still seems to difference with v5.3.0. If required the diffs, please log, or if it is no needed, I think it is easy to maintain to leave same with v5.3.0.

@soburi , Sorry I mistakenly push only the patch, please help to recheck again

#26 (comment)

It's fixed at https://github.com/zephyrproject-rtos/hal_renesas/compare/8abb13d81d5f0bfd6db882296cbc66c5feea5286..795b884f504ab742ac3886f7d2c3e73d69bee0cb

soburi · 2024-08-05T08:02:19Z

@ydamigos @KhiemNguyenT
Could you take a look, please?

soburi · 2024-08-07T02:25:32Z

@ydamigos @KhiemNguyenT

Could you progress this a bit?
The SCI_UART will be available if this PR and #71174 merge, some boards will be able to merge.

thaoluonguw · 2024-08-07T07:41:34Z

I am OK with these updates. Thank you.

soburi requested changes Jul 14, 2024

View reviewed changes

This was referenced Jul 19, 2024

Support Renesas RA6 MCUs devices zephyrproject-rtos/zephyr#76080

Merged

Support Renesas RA4 devices zephyrproject-rtos/zephyr#76081

Merged

duynguyenxa force-pushed the support_ra6_ra4_ra2_PR2.0 branch from c2d795c to a8585a4 Compare August 2, 2024 11:36

quytranpzz and others added 9 commits August 5, 2024 14:01

hal: renesas: Add supporting for RA6M1

6afb05d

Add RA6M1 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6M2

94a0687

Add RA6M2 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6M3

2535d50

Add RA6M3 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6M4

fe7c907

Add RA6M4 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6M5

49ece03

Add RA6M5 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6E1

88dafbd

Add RA6E1 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: Add supporting for RA6E2

6673c52

Add RA6E2 hal support Signed-off-by: Quy Tran <[email protected]>

hal: renesas: uart: Remove DTC config override uart async API

4331fe3

Modify RX transfer info for sci uart reception with DTC Remove redundant configuration Update README patch list of the modification of SCI UART source Signed-off-by: The Nguyen <[email protected]>

hal: renesas: Add support for RA2L1

0c59758

Add initial support for RA2L1 Signed-off-by: Quy Tran <[email protected]>

duynguyenxa force-pushed the support_ra6_ra4_ra2_PR2.0 branch from a8585a4 to 4b56607 Compare August 5, 2024 07:15

duynguyenxa marked this pull request as ready for review August 5, 2024 07:23

TriNguyen added 3 commits August 5, 2024 14:37

hal: renesas: Add BSP config RA4E2

a0007af

Initial support bsp config for RA4E2 board Signed-off-by: TriNguyen <[email protected]>

hal: renesas: Add BSP config RA4M1

36c1d17

Initial support bsp config for RA4M1 board Signed-off-by: TriNguyen <[email protected]>

hal: renesas: Add BSP config RA4M2

6f97630

Initial support bsp config for RA4M2 board Signed-off-by: TriNguyen <[email protected]>

duynguyenxa force-pushed the support_ra6_ra4_ra2_PR2.0 branch from 4b56607 to 8abb13d Compare August 5, 2024 07:39

TriNguyen and others added 4 commits August 5, 2024 14:45

hal: renesas: Add BSP config RA4M3

e336079

Initial support bsp config for RA4M3 board Signed-off-by: TriNguyen <[email protected]>

hal: renesas: Add BSP config RA4W1

51893ad

Initial support bsp config for RA4W1 board Signed-off-by: TriNguyen <[email protected]>

hal: renesas: Update pll multiple calculation

1af7563

Update PLL multiple calculation value Signed-off-by: Quy Tran <[email protected]>

hal: renesas: ra: add a portable for bsp_security.h

795b884

Add new implementation for R_BSP_SecurityInit on Zephyr Signed-off-by: The Nguyen <[email protected]>

duynguyenxa force-pushed the support_ra6_ra4_ra2_PR2.0 branch from 8abb13d to 795b884 Compare August 5, 2024 07:46

soburi approved these changes Aug 5, 2024

View reviewed changes

duynguyenxa closed this Aug 5, 2024

duynguyenxa reopened this Aug 5, 2024

KhiemNguyenT requested review from KhiemNguyenT and ydamigos August 7, 2024 06:54

KhiemNguyenT self-assigned this Aug 7, 2024

KhiemNguyenT approved these changes Aug 7, 2024

View reviewed changes

KhiemNguyenT merged commit 24543f3 into zephyrproject-rtos:main Aug 7, 2024

soburi mentioned this pull request Aug 7, 2024

boards: arm: Add initial support for Renesas EK-RA2A1 zephyrproject-rtos/zephyr#71174

Merged

Support RA6 RA4 RA2 hal layer #26

Support RA6 RA4 RA2 hal layer #26

Uh oh!

Conversation

duynguyenxa commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soburi Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

soburi Jul 14, 2024

Choose a reason for hiding this comment

Uh oh!

soburi commented Aug 2, 2024

Uh oh!

duynguyenxa commented Aug 5, 2024

Uh oh!

soburi commented Aug 5, 2024

Uh oh!

soburi commented Aug 5, 2024

Uh oh!

duynguyenxa commented Aug 5, 2024

Uh oh!

soburi commented Aug 5, 2024

Uh oh!

duynguyenxa commented Aug 5, 2024

Uh oh!

soburi left a comment

Choose a reason for hiding this comment

Uh oh!

soburi commented Aug 5, 2024

Uh oh!

duynguyenxa commented Aug 5, 2024

Uh oh!

soburi commented Aug 5, 2024

Uh oh!

soburi commented Aug 7, 2024

Uh oh!

thaoluonguw commented Aug 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

duynguyenxa commented Jul 9, 2024 •

edited

Loading