From be6ebe89e38e6ccfea1b2fc5814fb6b8f72d5d45 Mon Sep 17 00:00:00 2001 From: Erwan Gouriou Date: Fri, 31 Jan 2025 11:27:50 +0100 Subject: [PATCH 1/4] stm32cube: stm32h7: eth: Fix calculation of the tail pointer Cherry-picking commit ceda3ceeca2ee77a76d2de2ee6b560ad87c90a48 in STM32H7 Cube HAL https://github.com/STMicroelectronics/stm32h7xx-hal-driver/ Fixed in hal_stm32 main branch following cube version update from version v1.11.2 to version v1.12.0. Signed-off-by: Erwan Gouriou --- stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_eth.c b/stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_eth.c index 183eda6b4..c62471b69 100644 --- a/stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_eth.c +++ b/stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_eth.c @@ -1218,7 +1218,7 @@ static void ETH_UpdateDescriptor(ETH_HandleTypeDef *heth) if (heth->RxDescList.RxBuildDescCnt != desccount) { /* Set the tail pointer index */ - tailidx = (descidx + 1U) % ETH_RX_DESC_CNT; + tailidx = (ETH_RX_DESC_CNT + descidx - 1U) % ETH_RX_DESC_CNT; /* DMB instruction to avoid race condition */ __DMB(); From 5837af29f1dac6feee39e2585311b9c150160d97 Mon Sep 17 00:00:00 2001 From: Erwan Gouriou Date: Fri, 31 Jan 2025 11:47:30 +0100 Subject: [PATCH 2/4] stm32cube: stm32h5: eth: Fix calculation of the tail pointer Fixed in hal_stm32 main branch following cube version update from version v1.3.0 to version v1.4.0. Signed-off-by: Erwan Gouriou --- stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c b/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c index 204b3dc10..1902128fd 100644 --- a/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c +++ b/stm32cube/stm32h5xx/drivers/src/stm32h5xx_hal_eth.c @@ -1218,7 +1218,7 @@ static void ETH_UpdateDescriptor(ETH_HandleTypeDef *heth) if (heth->RxDescList.RxBuildDescCnt != desccount) { /* Set the tail pointer index */ - tailidx = (descidx + 1U) % ETH_RX_DESC_CNT; + tailidx = (ETH_RX_DESC_CNT + descidx - 1U) % ETH_RX_DESC_CNT; /* DMB instruction to avoid race condition */ __DMB(); From 83de1bf2338565cd1385c09e5379817b4e23bd70 Mon Sep 17 00:00:00 2001 From: Mathieu Choplain Date: Wed, 28 Aug 2024 11:17:36 +0200 Subject: [PATCH 3/4] ci: don't test on deprecated python versions Remove Python 3.7 and 3.8 from the CI test matrix, as these versions are deprecated / EOL. This enables usage of Python 3.9+ features in scripts, such as str.removeprefix/str.removesuffix, and should cause any issue since the scripts are always executed manually anyways. Signed-off-by: Mathieu Choplain --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a65d9bbd0..289e74b4e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,7 +8,7 @@ jobs: strategy: fail-fast: false matrix: - python-version: ['3.7', '3.8', '3.9', '3.10'] + python-version: ['3.9', '3.10'] steps: - uses: actions/checkout@v1 - name: Set up Python From 0f014fb7f374f4883fa898628e542b6b781b9435 Mon Sep 17 00:00:00 2001 From: Mathieu Choplain Date: Mon, 9 Sep 2024 11:28:32 +0200 Subject: [PATCH 4/4] ci: update upload-artifact action to v4 The upload-artifact@v2 action was deprecated since a while, and is now completely disabled (forceful CI failure). Update to v4 to get CI back. This also requires changing the artifact names, as the v4 action no longer supports uploading different artifacts with the same name. Signed-off-by: Mathieu Choplain --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 289e74b4e..2112164d7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,7 +31,7 @@ jobs: --cov-report html \ -vv - name: store coverage report - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v4 with: - name: coverage + name: coverage-${{ matrix.python-version }} path: htmlcov