hal_stm32: update the WB and WBA STM32 HAL_LL #270
Conversation
marwaiehm-st
force-pushed
the
update_hal_wb_wba
branch
from
61761ab to
4b14cd5
Compare
There was a problem hiding this comment.
On this last commit, I'm confused of the need be #265 which was merged few weeks ago.
Can you confirm this is required and this matches with latest changes in zephyr repo ?
There was a problem hiding this comment.
In the Zephyr repo, we renamed the JTAG reset pin for all the WBA boards.
This commit (#265) is adding the pinctrls for WBA6, which already contains the needed JTAG pinctrl debug_njtrst_pb4. Because of that, I added the commit that renames debug_jtrst_pb4 to debug_njtrst_pb4 for the WBA5 boards.
There was a problem hiding this comment.
I changed the commit message to be more significant to the modifications.
There was a problem hiding this comment.
@marwaiehm-st I remember this topic was closed. By the way... Please be sure to align the zephyr part also:
https://github.com/zephyrproject-rtos/zephyr/blob/68b2e7d677cc17f668df4f2d693b6296d4cf8201/dts/arm/st/wba/stm32wba.dtsi#L505
Otherwise I guess we will be not able to compile for WBA after this PR will be merged.
There was a problem hiding this comment.
@asm5878 This modification is aligned with the changes in the PR that adds support for the WBA6 boards: zephyrproject-rtos/zephyr#88407
You are right, it will cause a build failure, so the two PRs (Zephyr and HAL) should be merged at the same time.
There was a problem hiding this comment.
You are right, it will cause a build failure, so the two PRs (Zephyr and HAL) should be merged at the same time.
Ok, so we should ensure that Zephyr PR is ready before merging current PR (to avoid hal PR is merged in between).
To achieve this, can you put the Zephyr PR in ready for review ?
There was a problem hiding this comment.
Done, I have put it ready for review.
marwaiehm-st
force-pushed
the
update_hal_wb_wba
branch
from
4b14cd5 to
dea01fa
Compare
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
Approved but DNM until Zephyr PR is also closed to be merged.
asm5878
left a comment
asm5878
left a comment
There was a problem hiding this comment.
Fine for me also, but DNM until zephyr PR is ready
|
Please rebase |
Update Cube version for STM32WBxx series on https://github.com/STMicroelectronics from version v1.20.0 to version v1.22.0 Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
Update Cube version for STM32WBAxx series on https://github.com/STMicroelectronics from version v1.5.0 to version v1.6.0 Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
Re - generate common_ll headers after Cube updates Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
Renamed 'debug_jtrst_pb4' to 'debug_njtrst_pb4' for STM32WBA5 boards. Ensured consistency with the existing pinctrl definitions for STM32WBA6 boards. Signed-off-by: F. Ramu <[email protected]> Signed-off-by: IBEN EL HADJ MESSAOUD Marwa <[email protected]>
marwaiehm-st
force-pushed
the
update_hal_wb_wba
branch
from
dea01fa to
1bcd9b5
Compare
5 participants
stm32cube: update stm32wba to cube version V1.6.0
stm32cube: update stm32wb to cube version V1.22.0
update pinctrl dtsi for STM32WBAxx devices