newlib: Enable C99 format specifier support

stephanosio · stephanosio · commit 01fb90531b93 · 2021-11-16T10:51:10.000+09:00
This commit enables the C99 format specifier support for the newlib
full variant since it is required for C99 standard compatibility.

Without this, Zephyr applications cannot make use of the format
specifiers newly added in the C99 standard such as `%hhu` and `%hhd`.

Note that the C99 format specifier support is kept disabled for the
newlib nano variant (i.e. `CT_LIBC_NEWLIB_NANO_IO_C99FMT=n`) because
enabling it can lead to increased code size.

This also aligns the Zephyr SDK's behaviour to that of the GNU Arm
Embedded toolchain, which only enables the C99 format specifier support
in the newlib full variant.

Signed-off-by: Stephanos Ioannidis &lt;root@stephanos.io&gt;
diff --git a/configs/arc.config b/configs/arc.config
@@ -15,6 +15,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/arc64.config b/configs/arc64.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/arm.config b/configs/arm.config
@@ -15,6 +15,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/arm64.config b/configs/arm64.config
@@ -15,6 +15,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/i586.config b/configs/i586.config
@@ -16,6 +16,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/iamcu.config b/configs/iamcu.config
@@ -16,6 +16,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/mips.config b/configs/mips.config
@@ -14,6 +14,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/nios2.config b/configs/nios2.config
@@ -15,6 +15,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/riscv64.config b/configs/riscv64.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/sparc.config b/configs/sparc.config
@@ -14,6 +14,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/x86_64-zephyr-elf.config b/configs/x86_64-zephyr-elf.config
@@ -16,6 +16,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_intel_apl_adsp.config b/configs/xtensa_intel_apl_adsp.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_intel_bdw_adsp.config b/configs/xtensa_intel_bdw_adsp.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_intel_byt_adsp.config b/configs/xtensa_intel_byt_adsp.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_intel_s1000.config b/configs/xtensa_intel_s1000.config
@@ -16,6 +16,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_nxp_imx8m_adsp.config b/configs/xtensa_nxp_imx8m_adsp.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_nxp_imx_adsp.config b/configs/xtensa_nxp_imx_adsp.config
@@ -17,6 +17,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/configs/xtensa_sample_controller.config b/configs/xtensa_sample_controller.config
@@ -16,6 +16,7 @@ CT_NEWLIB_DEVEL_URL="https://github.com/zephyrproject-rtos/newlib-cygwin.git"
 CT_NEWLIB_DEVEL_REVISION="2893dbb10f1fe3bf431a26f89a22e12a5020dc02"
 CT_LIBC_NEWLIB_TARGET_CFLAGS="-O2"
 # CT_LIBC_NEWLIB_ENABLE_TARGET_OPTSPACE is not set
+CT_LIBC_NEWLIB_IO_C99FMT=y
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
diff --git a/release-notes.md b/release-notes.md
@@ -5,6 +5,9 @@
 - gcc:
   * Added multilibs for the RISC-V RV32E targets.
 
+- newlib:
+  * Enabled C99 format specifier support for newlib full variant.
+
 - qemu:
   * Added MIPS little endian emulation
   * Update xilinx qemu to 5.1.0
