Update GDB to used python3.8

galak · galak · commit a0502aae7046 · 2020-05-15T13:18:36.000-05:00
Its hard to find a version of GDB that works on a large number of
systems.  It looks like python3.8 can be installed on most systems these
days so lets try to utilize that version.

On ubuntu systems you can install python3.8 via (if not supported by
default):

	sudo apt-get install python3.8-dev

On fedora systems you can install via:

	sudo dnf install python38

Signed-off-by: Kumar Gala &lt;kumar.gala@linaro.org&gt;
diff --git a/configs/arc.config b/configs/arc.config
@@ -37,5 +37,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/arm.config b/configs/arm.config
@@ -38,5 +38,6 @@ CT_CC_GCC_MULTILIB_LIST="rmprofile"
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/arm64.config b/configs/arm64.config
@@ -37,6 +37,7 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_GDB_CROSS_EXTRA_CONFIG_ARRAY="--enable-targets=arm-zephyr-eabi"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/i586.config b/configs/i586.config
@@ -38,5 +38,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/iamcu.config b/configs/iamcu.config
@@ -38,6 +38,7 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_NCURSES_V_6_0=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/mips.config b/configs/mips.config
@@ -36,5 +36,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/nios2.config b/configs/nios2.config
@@ -37,5 +37,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/riscv64.config b/configs/riscv64.config
@@ -40,5 +40,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/sparc.config b/configs/sparc.config
@@ -36,5 +36,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/x86_64-zephyr-elf.config b/configs/x86_64-zephyr-elf.config
@@ -37,5 +37,6 @@ CT_CC_GCC_EXTRA_CONFIG_ARRAY="--with-gnu-ld --with-gnu-as --enable-initfini-arra
 CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_intel_apl_adsp.config b/configs/xtensa_intel_apl_adsp.config
@@ -44,5 +44,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_intel_bdw_adsp.config b/configs/xtensa_intel_bdw_adsp.config
@@ -44,5 +44,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_intel_byt_adsp.config b/configs/xtensa_intel_byt_adsp.config
@@ -44,5 +44,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_intel_s1000.config b/configs/xtensa_intel_s1000.config
@@ -44,5 +44,6 @@ CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
 CT_GDB_CROSS_EXTRA_CONFIG_ARRAY="--enable-xtensa-use-target-regnum --disable-xtensa-remote-g-packet"
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_nxp_imx8m_adsp.config b/configs/xtensa_nxp_imx8m_adsp.config
@@ -44,5 +44,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_nxp_imx_adsp.config b/configs/xtensa_nxp_imx_adsp.config
@@ -44,5 +44,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/configs/xtensa_sample_controller.config b/configs/xtensa_sample_controller.config
@@ -43,5 +43,6 @@ CT_CC_LANG_CXX=y
 CT_CC_GCC_LIBSTDCXX_NANO=y
 CT_DEBUG_GDB=y
 CT_GDB_V_8_3=y
+CT_GDB_CROSS_PYTHON_BINARY="python3.8"
 CT_ISL_V_0_18=y
 CT_LIBICONV_NEEDED=y
diff --git a/patches/gdb/8.3.1/0009-Fix-incorrect-use-of-is-operator-for-comparison-in-p.patch b/patches/gdb/8.3.1/0009-Fix-incorrect-use-of-is-operator-for-comparison-in-p.patch
@@ -0,0 +1,38 @@
+From b6484282f85bf7f11451b2441599c241d302ad9d Mon Sep 17 00:00:00 2001
+From: Raul Tambre <raul@tambre.ee>
+Date: Sat, 4 May 2019 15:48:17 -0400
+Subject: [PATCH] Fix incorrect use of 'is' operator for comparison in
+ python/lib/gdb/command/prompt.py
+
+The 'is' operator is not meant to be used for comparisons. It currently working
+is an implementation detail of CPython.  CPython 3.8 has added a SyntaxWarning
+for this.
+---
+ gdb/python/lib/gdb/command/prompt.py | 4 ++--
+ 2 files changed, 8 insertions(+), 2 deletions(-)
+
+diff --git a/gdb/python/lib/gdb/command/prompt.py b/gdb/python/lib/gdb/command/prompt.py
+index 3d662a7d3f..04b9e49c22 100644
+--- a/gdb/python/lib/gdb/command/prompt.py
++++ b/gdb/python/lib/gdb/command/prompt.py
+@@ -45,7 +45,7 @@ The currently defined substitutions are:
+         self.hook_set = False
+ 
+     def get_show_string (self, pvalue):
+-        if self.value is not '':
++        if self.value:
+            return "The extended prompt is: " + self.value
+         else:
+            return "The extended prompt is not set."
+@@ -57,7 +57,7 @@ The currently defined substitutions are:
+         return ""
+ 
+     def before_prompt_hook(self, current):
+-        if self.value is not '':
++        if self.value:
+             return gdb.prompt.substitute_prompt(self.value)
+         else:
+             return None
+-- 
+2.25.4
+
