newlib: remove settting -DMISSING_SYSCALL_NAMES

galak · galak · commit ac6459c4c264 · 2020-02-02T11:47:26.000-06:00
This was a hold over from the old sdk and creates a confusing situation
in which the libc portion of newlib uses one naming convention and the
libgloss uses another.  Drop setting -DMISSING_SYSCALL_NAMES makes
everything consistent as well as makes the toolchain in sync with other
3rd party GNU toolchains (ARM GNU embedded, RISCV, etc).

Signed-off-by: Kumar Gala &lt;kumar.gala@linaro.org&gt;
diff --git a/configs/arc.config b/configs/arc.config
@@ -9,7 +9,6 @@ CT_ARCH_ARC=y
 CT_MULTILIB=y
 CT_TARGET_CFLAGS="-mno-sdata"
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -23,7 +22,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/arm.config b/configs/arm.config
@@ -9,7 +9,6 @@ CT_ARCH_ARM=y
 CT_ARCH_ARM_INTERWORKING=y
 CT_MULTILIB=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -23,7 +22,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/arm64.config b/configs/arm64.config
@@ -9,7 +9,6 @@ CT_ARCH_ARM=y
 CT_MULTILIB=y
 CT_ARCH_64=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -23,7 +22,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/i586.config b/configs/i586.config
@@ -10,7 +10,6 @@ CT_ARCH_TUNE="pentium"
 CT_MULTILIB=y
 CT_TARGET_CFLAGS="-m32"
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -24,7 +23,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/iamcu.config b/configs/iamcu.config
@@ -10,7 +10,6 @@ CT_ARCH_TUNE="lakemont"
 CT_ARCH_X86_IAMCU=y
 CT_TARGET_CFLAGS="-miamcu -m32"
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -24,7 +23,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/mips.config b/configs/mips.config
@@ -8,7 +8,6 @@ CT_LOCAL_PATCH_DIR="${CT_TOP_DIR}/../../patches"
 CT_ARCH_MIPS=y
 CT_MULTILIB=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -22,7 +21,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/nios2.config b/configs/nios2.config
@@ -9,7 +9,6 @@ CT_ARCH_NIOS2=y
 CT_MULTILIB=y
 CT_ARCH_USE_MMU=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -23,7 +22,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/riscv64.config b/configs/riscv64.config
@@ -12,7 +12,6 @@ CT_ARCH_64=y
 CT_ARCH_ARCH="rv32ima"
 CT_ARCH_ABI="ilp32"
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -26,7 +25,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/sparc.config b/configs/sparc.config
@@ -8,7 +8,6 @@ CT_LOCAL_PATCH_DIR="${CT_TOP_DIR}/../../patches"
 CT_ARCH_SPARC=y
 CT_MULTILIB=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -22,7 +21,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/x86_64-zephyr-elf.config b/configs/x86_64-zephyr-elf.config
@@ -8,7 +8,6 @@ CT_ARCH_X86=y
 CT_MULTILIB=y
 CT_ARCH_64=y
 CT_TARGET_VENDOR="zephyr"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -22,7 +21,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/xtensa_intel_apl_adsp.config b/configs/xtensa_intel_apl_adsp.config
@@ -15,7 +15,6 @@ CT_TARGET_VENDOR="zephyr"
 CT_NEWLIB_SRC_DEVEL=y
 CT_NEWLIB_DEVEL_URL="https://github.com/jcmvbkbc/newlib-xtensa.git"
 CT_NEWLIB_DEVEL_BRANCH="xtensa"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -29,7 +28,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/xtensa_intel_s1000.config b/configs/xtensa_intel_s1000.config
@@ -14,7 +14,6 @@ CT_TARGET_VENDOR="zephyr"
 CT_NEWLIB_SRC_DEVEL=y
 CT_NEWLIB_DEVEL_URL="https://github.com/jcmvbkbc/newlib-xtensa.git"
 CT_NEWLIB_DEVEL_BRANCH="xtensa"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -28,7 +27,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
diff --git a/configs/xtensa_sample_controller.config b/configs/xtensa_sample_controller.config
@@ -14,7 +14,6 @@ CT_TARGET_VENDOR="zephyr"
 CT_NEWLIB_SRC_DEVEL=y
 CT_NEWLIB_DEVEL_URL="https://github.com/jcmvbkbc/newlib-xtensa.git"
 CT_NEWLIB_DEVEL_BRANCH="xtensa"
-CT_LIBC_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NEWLIB_IO_LL=y
 CT_LIBC_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NEWLIB_FSEEK_OPTIMIZATION is not set
@@ -28,7 +27,6 @@ CT_LIBC_NEWLIB_RETARGETABLE_LOCKING=y
 # CT_LIBC_NEWLIB_NANO_FORMATTED_IO is not set
 CT_LIBC_NEWLIB_EXTRA_SECTIONS=y
 CT_LIBC_NANO_NEWLIB=y
-CT_LIBC_NANO_NEWLIB_TARGET_CFLAGS="-DMISSING_SYSCALL_NAMES"
 CT_LIBC_NANO_NEWLIB_IO_FLOAT=y
 # CT_LIBC_NANO_NEWLIB_FSEEK_OPTIMIZATION is not set
 CT_LIBC_NANO_NEWLIB_DISABLE_SUPPLIED_SYSCALLS=y
