xtensa: sample_controller32: for Xtensa MPU support #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
reviewed
May 6, 2024
Member
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
Need to update ci.yml to build the new xtensa-sample_controller32_zephyr-elf toolchain.
Also QEMU changes from zephyrproject-rtos/qemu#8 should be pulled as well.
Member
Author
|
I have changed |
Member
Author
|
This needs zephyrproject-rtos/qemu#9 to fix QEMU build. |
Member
|
@dcpleung zephyrproject-rtos/qemu#9 is merged. Please update this PR to point to the merged commit. |
Member
Author
Done. Updated the QEMU |
dcpleung
force-pushed
the
xtensa/mpu
branch
from
7ff7ad5 to
18a3308
Compare
The overlay comes from: https://github.com/jcmvbkbc/xtensa-toolchain-build commit 435c5e8b108de520565886f3f2349cc6be3fe712 under directory overlays/ This would allow us to use QEMU to test the Xtensa MPU code on main Zephyr repo. Signed-off-by: Daniel Leung <[email protected]>
Member
stephanosio
requested changes
Sep 27, 2024
Comment on lines
1589
to
1591
| xtensa-sample_controller32_zephyr-elf) | ||
| PLATFORM_ARGS+="-p qemu_xtensa/sample_controller32/mpu " | ||
| ;; |
Member
There was a problem hiding this comment.
This needs to be disabled until the board support is merged on the Zephyr side; otherwise, CI will fail.
This commit disables the testing of the Xtensa sample_controller32 toolchain because the corresponding Zephyr board support has not been merged. Revert this commit when the support for this platform is merged on the Zephyr side. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay comes from:
https://github.com/jcmvbkbc/xtensa-toolchain-build
commit 435c5e8b108de520565886f3f2349cc6be3fe712
under directory overlays/
This would allow us to use QEMU to test the Xtensa MPU code on main Zephyr repo.