picolibc: get --picolibc-buildtype=release working #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides both minsize and release versions of picolibc in the SDK, allowing users to select between them while building their application. Signed-off-by: Keith Packard <[email protected]>
In release builds, several targets would get both asm and C versions of strchr included, which is a fatal picolibc build error. Pull in the fix for that. Signed-off-by: Keith Packard <[email protected]>
gcc's spec file processing had a bug where it would truncate the 'release' paths when using a 'sysroot' style install (which uses getenv in spec files). Signed-off-by: Keith Packard <[email protected]>
Not strictly necessary for Zephyr which doesn't use this for linking, but still nice to have a working toolchain anyways. Signed-off-by: Keith Packard <[email protected]>
Need to use BUILD_DIR instead of WORKSPACE as the latter hasn't been set at this point. Signed-off-by: Keith Packard <[email protected]>
Member
|
Closing as stale. Please re-open if this is still relevant. |
Contributor
Author
|
Part of 0.18, so this issue should be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took a patch to gcc and a patch to picolibc