tests: Remove tox assert

Allow running tests without tox, so remove the check for a tox
environment.

Signed-off-by: Pieter De Gendt <[email protected]>

Author: pdgendt

tests/conftest.py

@@ -87,12 +87,12 @@ def _check_git_capabilities(tmpdir_factory):
         pass
 
 @pytest.fixture(scope='session')
-def _session_repos():
+def _session_repos(tmp_path_factory):
     '''Just a helper, do not use directly.'''
 
     # It saves time to create repositories once at session scope, then
     # clone the results as needed in per-test fixtures.
-    session_repos = os.path.join(os.environ['TOXTEMPDIR'], 'session_repos')
+    session_repos = str(tmp_path_factory.mktemp('session_repos'))
     print('initializing session repositories in', session_repos)
     shutil.rmtree(session_repos, ignore_errors=True)
 

tests/test_alias.py

@@ -2,14 +2,11 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-import os
 import subprocess
 
 import pytest
 from conftest import cmd
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 
 @pytest.fixture(autouse=True)
 def autouse_tmpdir(config_tmpdir, west_init_tmpdir):

tests/test_commands.py

@@ -1,13 +1,9 @@
 # Copyright (c) 2021, Nordic Semiconductor ASA
 
-import os
-
 import pytest
 
 from west.commands import Verbosity, WestCommand
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 gv = WestCommand._parse_git_version
 
 

tests/test_config.py

@@ -14,8 +14,6 @@
 from west import configuration as config
 from west.util import PathType
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 SYSTEM = config.ConfigFile.SYSTEM
 GLOBAL = config.ConfigFile.GLOBAL
 LOCAL = config.ConfigFile.LOCAL

tests/test_help.py

@@ -8,7 +8,6 @@
 
 from west.app.main import BUILTIN_COMMAND_GROUPS
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
 
 def test_builtin_help_and_dash_h(west_init_tmpdir):
     # Test "west help" and "west -h" are the same for built-in

tests/test_main.py

@@ -1,10 +1,8 @@
-import os
 import subprocess
 import sys
 
 import west.version
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
 
 def test_main():
     # A quick check that the package can be executed as a module which

tests/test_manifest.py

@@ -53,8 +53,6 @@
     validate,
 )
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 FPI = ImportFlag.FORCE_PROJECTS  # to force project imports to use the callback
 
 if platform.system() == 'Windows':

tests/test_project.py

@@ -28,8 +28,6 @@
 from west.manifest import ImportFlag as MIF
 from west.manifest import Manifest, ManifestImportFailed, ManifestProject, Project
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 #
 # Helpers
 #

tests/test_project_caching.py

@@ -18,8 +18,6 @@
     rev_parse,
 )
 
-assert 'TOXTEMPDIR' in os.environ, "you must run these tests using tox"
-
 #
 # Helpers
 #